starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #12324] [MERGED] Update accessible names for 'add profile' page buttons #28983

New Issue
Open
opened 2026-01-31 09:32:03 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:32:03 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12324
Author: @carlos-zamora
Created: 2/1/2022
Status: ✅ Merged
Merged: 2/2/2022
Merged by: @undefined

Base: main ← Head: dev/cazamor/a11y-polish-new-profile-btn

📝 Commits (3)

  • 7853074 Update accessible name for 'new profile' button
  • 78d43de Do the same for 'duplicate' button
  • 1131263 Reintroduce .Content

📊 Changes

2 files changed (+8 additions, -6 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/AddProfile.cpp (+6 -0)
📝 src/cascadia/TerminalSettingsEditor/AddProfile.xaml (+2 -6)

📄 Description

Summary of the Pull Request

When using a screen reader, the buttons on the "add a new profile" page were being read weirdly:

  • "New empty profile" button read as "create new button button"
  • "duplicate" button read as "duplicate button button"

It's generally standard to read out the text inside the button, so I did just that by reusing the existing localized resources. This also removes the redundant "button" that is said by the screen reader.

I also removed the unused AutomationId and unnecessary Button.Content tags.

#11156 can be closed upon validation by the accessibility team.

Validation Steps Performed

✅ navigate to both buttons using Narrator; make sure it sounds right

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12324 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 2/1/2022 **Status:** ✅ Merged **Merged:** 2/2/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/cazamor/a11y-polish-new-profile-btn` --- ### 📝 Commits (3) - [`7853074`](https://github.com/microsoft/terminal/commit/78530742c3286ca76ced3321a2d1bce7af05d92e) Update accessible name for 'new profile' button - [`78d43de`](https://github.com/microsoft/terminal/commit/78d43dec2e1b32f719660724658beee862e841e4) Do the same for 'duplicate' button - [`1131263`](https://github.com/microsoft/terminal/commit/1131263d88499c1af6959f0419e1915492ce553c) Reintroduce .Content ### 📊 Changes **2 files changed** (+8 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/AddProfile.cpp` (+6 -0) 📝 `src/cascadia/TerminalSettingsEditor/AddProfile.xaml` (+2 -6) </details> ### 📄 Description ## Summary of the Pull Request When using a screen reader, the buttons on the "add a new profile" page were being read weirdly: - "New empty profile" button read as "create new button button" - "duplicate" button read as "duplicate button button" It's generally standard to read out the text inside the button, so I did just that by reusing the existing localized resources. This also removes the redundant "button" that is said by the screen reader. I also removed the unused `AutomationId` and unnecessary `Button.Content` tags. #11156 can be closed upon validation by the accessibility team. ## Validation Steps Performed ✅ navigate to both buttons using Narrator; make sure it sounds right --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:32:04 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28983
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?