starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

One broken stub in a fragment file causes the whole file to not load #15340

New Issue
Closed
opened 2026-01-31 04:35:39 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 04:35:39 +00:00
Owner
Copy Link

Originally created by @PankajBhojwani on GitHub (Sep 24, 2021).

Originally assigned to: @lhecker on GitHub.

Windows Terminal version (or Windows build number)

Current main build

Other Software

No response

Steps to reproduce

Put the following fragment file in AppData\Local\Microsoft\Windows Terminal\Fragments\{any-name-here}:

{
  "profiles": [
    {
      "name": "broken profile",
      "font": "thisFontDoesntExist"
    },
    {
      "name": "Cool Profile"
    }
  ]
}

Then start WT

Expected Behavior

"Cool Profile" should show up in the dropdown

Actual Behavior

"Cool Profile" does not show up, the presence of the broken profile causes the non-broken profile to not load

Originally created by @PankajBhojwani on GitHub (Sep 24, 2021). Originally assigned to: @lhecker on GitHub. ### Windows Terminal version (or Windows build number) Current main build ### Other Software _No response_ ### Steps to reproduce Put the following fragment file in `AppData\Local\Microsoft\Windows Terminal\Fragments\{any-name-here}`: ``` { "profiles": [ { "name": "broken profile", "font": "thisFontDoesntExist" }, { "name": "Cool Profile" } ] } ``` Then start WT ### Expected Behavior "Cool Profile" should show up in the dropdown ### Actual Behavior "Cool Profile" does not show up, the presence of the broken profile causes the non-broken profile to not load
claunia added the Resolution-Fix-CommittedArea-SettingsIssue-BugProduct-Terminal labels 2026-01-31 04:35:39 +00:00
claunia commented 2026-01-31 04:35:40 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Sep 27, 2021):

The new code is consistent with the previous behavior. You can try it with:

{
    "profiles": [
        {
            "name": "broken profile",
            "unfocusedAppearance": ""
        },
        {
            "name": "Cool Profile"
        }
    ]
}

I'll tag this issue as needs-discussion, as we'd have to decide what the new failure handling would need to look like. After all, errors in the user's settings.json aren't just silently ignored either. A warning might be appropriate here...

@lhecker commented on GitHub (Sep 27, 2021): The new code is consistent with the previous behavior. You can try it with: ```json { "profiles": [ { "name": "broken profile", "unfocusedAppearance": "" }, { "name": "Cool Profile" } ] } ``` I'll tag this issue as needs-discussion, as we'd have to decide what the new failure handling would need to look like. After all, errors in the user's settings.json aren't just silently ignored either. A warning might be appropriate here...
claunia commented 2026-01-31 04:35:41 +00:00
Author
Owner
Copy Link

@PankajBhojwani commented on GitHub (Sep 27, 2021):

I have a branch pre-#11184 and with that example, "Cool Profile" loads while "broken profile" does not, so I think this was a recent regression! In #10601 we added try-catch blocks around the individual profile and update stubs within a fragment file to ensure we continue parsing fragments even if we find broken ones, which I believe the new implementation is missing.

We decided to silently ignore issues in fragment parsing because fragment issues are rarely the fault of the user, so we didn't think there was any point in alerting the user about that. Totally down to brainstorm other ways to avoid silently failing though

@PankajBhojwani commented on GitHub (Sep 27, 2021): I have a branch pre-#11184 and with that example, `"Cool Profile"` loads while `"broken profile"` does not, so I think this was a recent regression! In #10601 we added try-catch blocks around the _individual_ profile and update stubs within a fragment file to ensure we continue parsing fragments even if we find broken ones, which I believe the new implementation is missing. We decided to silently ignore issues in fragment parsing because fragment issues are rarely the fault of the user, so we didn't think there was any point in alerting the user about that. Totally down to brainstorm other ways to avoid silently failing though
claunia commented 2026-01-31 04:35:41 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Sep 27, 2021):

@PankajBhojwani Ah I see. I was testing with the wrong version of WT... I'll sneak a fix for this into #11343.

@lhecker commented on GitHub (Sep 27, 2021): @PankajBhojwani Ah I see. I was testing with the wrong version of WT... ~I'll sneak a fix for this into #11343.~
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Bug Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15340
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?