Multiple failing unit tests #15355

Closed
opened 2026-01-31 04:36:02 +00:00 by claunia · 3 comments
Owner

Originally created by @j4james on GitHub (Sep 26, 2021).

Originally assigned to: @lhecker on GitHub.

Windows Terminal version (or Windows build number)

10.0.18363.1500, Commit 2be394f421

Other Software

No response

Steps to reproduce

  1. Checkout a recent version of the Terminal.
  2. Build the code.
  3. Execute runut in the tools directory.

Expected Behavior

The unit tests should all pass.

Actual Behavior

I'm getting quite a lot of failures.

TerminalAppLocalTests::CommandlineTest::ParseFocusTabArgs#metadataSet0 [Failed]
TerminalAppLocalTests::CommandlineTest::ParseFocusTabArgs#metadataSet1 [Failed]
TerminalAppLocalTests::SettingsTests::TestIterateCommands [Failed]
TerminalAppLocalTests::SettingsTests::TestIterateOnGeneratedNamedCommands [Failed]
TerminalAppLocalTests::SettingsTests::TestIterateOnBadJson [Failed]
TerminalAppLocalTests::SettingsTests::TestNestedCommands [Failed]
TerminalAppLocalTests::SettingsTests::TestNestedInNestedCommand [Failed]
TerminalAppLocalTests::SettingsTests::TestNestedInIterableCommand [Failed]
TerminalAppLocalTests::SettingsTests::TestIterableInNestedCommand [Failed]
TerminalAppLocalTests::SettingsTests::TestMixedNestedAndIterableCommand [Failed]
TerminalAppLocalTests::SettingsTests::TestIterableColorSchemeCommands [Failed]
TerminalAppLocalTests::TabTests::MoveFocusFromZoomedPane [Failed]
SettingsModelLocalTests::ProfileTests::TestGenGuidsForProfiles [Failed]
SettingsModelLocalTests::DeserializationTests::TestLayerUserDefaultsOnDynamics [Failed]
SettingsModelLocalTests::SerializationTests::Profile [Failed]

I haven't actually looked to see what's going wrong, so it's possible it's just me.

Originally created by @j4james on GitHub (Sep 26, 2021). Originally assigned to: @lhecker on GitHub. ### Windows Terminal version (or Windows build number) 10.0.18363.1500, Commit 2be394f421b9b23a15e5573fb02b9c7a25768941 ### Other Software _No response_ ### Steps to reproduce 1. Checkout a recent version of the Terminal. 2. Build the code. 3. Execute `runut` in the tools directory. ### Expected Behavior The unit tests should all pass. ### Actual Behavior I'm getting quite a lot of failures. TerminalAppLocalTests::CommandlineTest::ParseFocusTabArgs#metadataSet0 [Failed] TerminalAppLocalTests::CommandlineTest::ParseFocusTabArgs#metadataSet1 [Failed] TerminalAppLocalTests::SettingsTests::TestIterateCommands [Failed] TerminalAppLocalTests::SettingsTests::TestIterateOnGeneratedNamedCommands [Failed] TerminalAppLocalTests::SettingsTests::TestIterateOnBadJson [Failed] TerminalAppLocalTests::SettingsTests::TestNestedCommands [Failed] TerminalAppLocalTests::SettingsTests::TestNestedInNestedCommand [Failed] TerminalAppLocalTests::SettingsTests::TestNestedInIterableCommand [Failed] TerminalAppLocalTests::SettingsTests::TestIterableInNestedCommand [Failed] TerminalAppLocalTests::SettingsTests::TestMixedNestedAndIterableCommand [Failed] TerminalAppLocalTests::SettingsTests::TestIterableColorSchemeCommands [Failed] TerminalAppLocalTests::TabTests::MoveFocusFromZoomedPane [Failed] SettingsModelLocalTests::ProfileTests::TestGenGuidsForProfiles [Failed] SettingsModelLocalTests::DeserializationTests::TestLayerUserDefaultsOnDynamics [Failed] SettingsModelLocalTests::SerializationTests::Profile [Failed] I haven't actually looked to see what's going wrong, so it's possible it's just me.
Author
Owner

@zadjii-msft commented on GitHub (Sep 27, 2021):

Yep, I've got a similar set of errors over here. I'm gonna tap in @lhecker for his settings refactor work.

@zadjii-msft commented on GitHub (Sep 27, 2021): Yep, I've got a similar set of errors over here. I'm gonna tap in @lhecker for his settings refactor work.
Author
Owner

@lhecker commented on GitHub (Sep 27, 2021):

Oh... We don't run those as part of CI, right? I forgot about that...

@lhecker commented on GitHub (Sep 27, 2021): Oh... We don't run those as part of CI, right? I forgot about that...
Author
Owner

@Rosefield commented on GitHub (Sep 27, 2021):

I added a fix to the MoveFocusFromZoomedPane test (to make it confirm that we are still zoomed instead of not zoomed) to #11153

@Rosefield commented on GitHub (Sep 27, 2021): I added a fix to the `MoveFocusFromZoomedPane` test (to make it confirm that we are still zoomed instead of not zoomed) to #11153
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15355