starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Miscellaneous Settings UI nits #15369

New Issue
Closed
opened 2026-01-31 04:36:28 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 04:36:28 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Sep 28, 2021).

discovered in the 1.12 bug bash on 9/28, but these aren't 1.12 blocking issues

  • Navigation View Sidebar] the names of the new VS names don't fit (nor do they get a tooltip)
  • [Actions page] there's an unnamed action (appears as Microsoft.Terminal.Settings.Editor.KeyBinding). After adding it, when clicking "Add new" again or saving, it disappears. Saving it also doesn't appear in the JSON.
  • [Appearance tab of a profile] Background image path does not appear in the text box
  • [Appearance tab of a profile] "Reset to inherited value" button for the padding slider needs to be hit twice to make the button go away
  • image Needs padding under it,
  • image Button should have "Delete" after the icon
  • "Intense Text Style" Also lowercase t and s on text style
  • The settings icon in the tab should be updated to the new gear icon (used in the Open JSON file nav item)
    image

The following were noted after #12241 merged

Originally created by @zadjii-msft on GitHub (Sep 28, 2021). _discovered in the 1.12 bug bash on 9/28, but these aren't 1.12 blocking issues_ * [x] Navigation View Sidebar] the names of the new VS names don't fit (nor do they get a tooltip) - Proposal: add tooltips? Don't just crop? - Fixed in #12448 * [x] [Actions page] there's an unnamed action (appears as `Microsoft.Terminal.Settings.Editor.KeyBinding`). After adding it, when clicking "Add new" again or saving, it disappears. Saving it also doesn't appear in the JSON. * [x] [Appearance tab of a profile] Background image path does not appear in the text box * [x] [Appearance tab of a profile] "Reset to inherited value" button for the padding slider needs to be hit twice to make the button go away * [x] ![image](https://user-images.githubusercontent.com/18356694/135151407-431423ed-4a61-4e19-b00c-45cb2691ec45.png) Needs padding under it, * [x] ... should be lowercase a on appearance, * [x] ... should probably have "Add" after the plus button * [x] ... and scoot the button to the left (same distance that the rename button has with the color scheme dropdown) * fixed in #12451 * [x] ![image](https://user-images.githubusercontent.com/18356694/135151440-ddb6b3c4-a9e8-42c3-8685-05554e1acc15.png) Button should have "Delete" after the icon * [x] "Intense Text Style" Also lowercase t and s on text style * [ ] The settings icon in the tab should be updated to the new gear icon (used in the Open JSON file nav item) ![image](https://user-images.githubusercontent.com/48369326/153055317-da8ec0b7-b476-4f36-af89-09d614a947af.png) - Mike note: I'm on this. There's a lot of places we use the wrong font - in #12469 <hr> The following were noted after #12241 merged * [x] The commandline box could be wider. It takes up a fairly low percent of the expander, esp. when the terminal is maximized ![image](https://user-images.githubusercontent.com/18356694/151963472-72673386-979a-44ab-bfd7-81e14e2fb0a7.png) - Fixed in #12326 * [x] #12328 * [x] #12335 * [x] #12350 * [ ] #12359 * [ ] more...
claunia commented 2026-01-31 04:36:30 +00:00
Author
Owner
Copy Link

@StanzillaManticore commented on GitHub (Feb 3, 2022):

Imo, the hamburger menu in the settings should be removed, it's really not doing any good for UX and just takes space.

@StanzillaManticore commented on GitHub (Feb 3, 2022): Imo, the hamburger menu in the settings should be removed, it's really not doing any good for UX and just takes space.
claunia commented 2026-01-31 04:36:30 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 3, 2022):

@StanzillaManticore Fair point! How do you propose expanding the nav view when the window is relatively narrow, without the hamburger?

image

image

@zadjii-msft commented on GitHub (Feb 3, 2022): @StanzillaManticore Fair point! How do you propose expanding the nav view when the window is relatively narrow, without the hamburger? ![image](https://user-images.githubusercontent.com/18356694/152407988-46e3a7d3-c1d4-402f-a7d9-738181ef226c.png) ![image](https://user-images.githubusercontent.com/18356694/152408012-ea2ce900-cafb-4968-a80a-9549b8925fb5.png)
claunia commented 2026-01-31 04:36:30 +00:00
Author
Owner
Copy Link

@Stanzilla commented on GitHub (Feb 3, 2022):

Oh accidently used my work account, so, I would do the same thing that it does currently where it hides the label when the window gets too small but otherwise always display them.

If it is a goal for users be able to see the label names even if the window is super small, maybe make the left side resizable?

@Stanzilla commented on GitHub (Feb 3, 2022): Oh accidently used my work account, so, I would do the same thing that it does currently where it hides the label when the window gets too small but otherwise always display them. If it is a goal for users be able to see the label names even if the window is super small, maybe make the left side resizable?
claunia commented 2026-01-31 04:36:30 +00:00
Author
Owner
Copy Link

@tropicaaal commented on GitHub (Feb 4, 2022):

One thing that might look better would be making the settings backdrop a single color. From what I've seen, NavigationView isn't really designed to look right with TabView above it, which results in these sort of cut-off corners, rather than the NavigationView blending in the the window's titlebar.

image

@tropicaaal commented on GitHub (Feb 4, 2022): One thing that might look better would be making the settings backdrop a single color. From what I've seen, NavigationView isn't really designed to look right with TabView above it, which results in these sort of cut-off corners, rather than the NavigationView blending in the the window's titlebar. ![image](https://user-images.githubusercontent.com/42101043/152550003-cfa825f0-5f7a-406a-8c24-972a18c13412.png)
claunia commented 2026-01-31 04:36:31 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Mar 25, 2022):

:tada:This issue was addressed in #12469, which has now been successfully released as Windows Terminal Preview v1.13.1073.🎉

Handy links:

@ghost commented on GitHub (Mar 25, 2022): :tada:This issue was addressed in #12469, which has now been successfully released as `Windows Terminal Preview v1.13.1073`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.13.1073) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Help Wanted Issue-Task Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15369
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?