starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Terminal just crashed when renaming tab #12350

New Issue
Closed
opened 2026-01-31 03:13:09 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 03:13:09 +00:00
Owner
Copy Link

Originally created by @NeilMacMullen on GitHub (Feb 1, 2021).

I raised a feedback hub report which I labelled with "20d02aa3-09d9-4c5b-8ede-f7057e42d5f3" for searchability.

Terminal Preview (1.6.10272.0) just crashed on me when attempting to rename a tab.

I had 5 powershell tabs open
Each of these had already been renamed and recolored but right clicking on the tab header.

I opened another tab and right clicked to change the color (this succeeded)
Immediately afterwards I right clicked to change the name. The new-name edit box did not appear. After a couple of seconds the entire terminal crashed and disappeared.

Originally created by @NeilMacMullen on GitHub (Feb 1, 2021). I raised a feedback hub report which I labelled with "20d02aa3-09d9-4c5b-8ede-f7057e42d5f3" for searchability. Terminal Preview (1.6.10272.0) just crashed on me when attempting to rename a tab. I had 5 powershell tabs open Each of these had already been renamed and recolored but right clicking on the tab header. I opened another tab and right clicked to change the color (this succeeded) Immediately afterwards I right clicked to change the name. The new-name edit box did not appear. After a couple of seconds the entire terminal crashed and disappeared.
claunia commented 2026-01-31 03:13:12 +00:00
Author
Owner
Copy Link

@NeilMacMullen commented on GitHub (Feb 1, 2021):

I have been trying to reproduce this without success so far. If I find a good recipe I'll post it here.

@NeilMacMullen commented on GitHub (Feb 1, 2021): I have been trying to reproduce this without success so far. If I find a good recipe I'll post it here.
claunia commented 2026-01-31 03:13:12 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 1, 2021):

By any chance, did you hover over the "Close..." option while trying to open the tab renamer? That menu flyout pretty consistently crashes the Terminal :(

@zadjii-msft commented on GitHub (Feb 1, 2021): By any chance, did you hover over the "Close..." option while trying to open the tab renamer? That menu flyout pretty consistently crashes the Terminal :(
claunia commented 2026-01-31 03:13:12 +00:00
Author
Owner
Copy Link

@NeilMacMullen commented on GitHub (Feb 1, 2021):

You mean close for the tab rather than close for the whole terminal?

It's certainly possible I did either by accident - the tabs would have been quite narrow and close to the right hand side of the title bar by this stage. I still haven't been able to reproduce it though, even with deliberately heading for the close icon!

@NeilMacMullen commented on GitHub (Feb 1, 2021): You mean close for the tab rather than close for the whole terminal? It's certainly _possible_ I did either by accident - the tabs would have been quite narrow and close to the right hand side of the title bar by this stage. I still haven't been able to reproduce it though, even with deliberately heading for the close icon!
claunia commented 2026-01-31 03:13:13 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 1, 2021):

image

^ This boy right here. There's a bug in XAML islands with nested menu flyouts that ends up crashing the app. We're tracking that in #8238 (et al)

@zadjii-msft commented on GitHub (Feb 1, 2021): ![image](https://user-images.githubusercontent.com/18356694/106488517-67c95400-6479-11eb-9933-51f2c609d9b6.png) ^ This boy right here. There's a bug in XAML islands with nested menu flyouts that ends up crashing the app. We're tracking that in #8238 (et al)
claunia commented 2026-01-31 03:13:13 +00:00
Author
Owner
Copy Link

@NeilMacMullen commented on GitHub (Feb 1, 2021):

Yes - I think it must be a dup of that. I can crash it every time now just by opening the menu and moving the mouse up and down over and past the the Close option. I suspect I did this accidentally on the original bug report by "overshooting" the rename tab option. I'll close this one.

@NeilMacMullen commented on GitHub (Feb 1, 2021): Yes - I think it must be a dup of that. I can crash it every time now just by opening the menu and moving the mouse up and down over and past the the Close option. I suspect I did this accidentally on the original bug report by "overshooting" the rename tab option. I'll close this one.
claunia commented 2026-01-31 03:13:14 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 1, 2021):

No worries, just glad there's not a new crash to worry about 😅

@zadjii-msft commented on GitHub (Feb 1, 2021): No worries, just glad there's not a _new_ crash to worry about 😅
claunia commented 2026-01-31 03:13:14 +00:00
Author
Owner
Copy Link

@NeilMacMullen commented on GitHub (Feb 1, 2021):

Always nice when there's just one root cause ;-)

@NeilMacMullen commented on GitHub (Feb 1, 2021): Always nice when there's just one root cause ;-)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Needs-Attention Needs-Triage Product-Terminal Resolution-Duplicate Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12350
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?