starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

UI nits from WinUI Controlsv2 #16675

New Issue
Open
opened 2026-01-31 05:19:19 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 05:19:19 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Feb 6, 2022).

In Terminal 1.13 we updated our version of WinUI to closer align with the Windows 11 styles. (in technical terms, we updated to ControlsV2). This had a variety of minor visual artifacts associated with it:

Relevant PRS:

Originally created by @zadjii-msft on GitHub (Feb 6, 2022). In Terminal 1.13 we updated our version of WinUI to closer align with the Windows 11 styles. (in technical terms, we updated to ControlsV2). This had a variety of minor visual artifacts associated with it: * [x] #12395 - upstream discussion: https://github.com/microsoft/microsoft-ui-xaml/issues/6684 - potential workaround: https://github.com/microsoft/terminal/issues/9218 - fixed in #12608 * [ ] New Tab icons aren't quite the right size: https://github.com/microsoft/terminal/issues/12395#issuecomment-1030874694 * [x] #12398 - Upstream: https://github.com/microsoft/microsoft-ui-xaml/issues/6685 * [x] #12350 * [ ] #12388 - Also includes: - [ ] #13285 - [ ] #13068 - [x] #9775 - [x] #13428 * [x] Colors are inconsistent between active tab, nav view, and tab content - ![terminal-winui2 6-colors](https://user-images.githubusercontent.com/48369326/153054807-07b8be24-b0dc-477c-b5b7-0cfa6a351811.png) - But actually, that's just how it is in Xaml Controls Gallery too: ![image](https://user-images.githubusercontent.com/18356694/156260918-bdd8393a-c605-44ae-90c1-008101cc651d.png) * [x] #12574 * [x] #13495 Relevant PRS: * #12241 * #11720 * #12144 * #12287 * #12326 * #12374 * #12376 * #12381
claunia added the Product-TerminalArea-UserInterfaceIssue-Scenario labels 2026-01-31 05:19:19 +00:00
claunia commented 2026-01-31 05:19:20 +00:00
Author
Owner
Copy Link

@vefatica commented on GitHub (Apr 20, 2022):

Now the release version is suffering. Black seems a bad choice for the background of the tab portion of the window. The icon for opening the dropdown menu (down arrowhead?) is too small.

image

@vefatica commented on GitHub (Apr 20, 2022): Now the release version is suffering. Black seems a bad choice for the background of the tab portion of the window. The icon for opening the dropdown menu (down arrowhead?) is too small. ![image](https://user-images.githubusercontent.com/61856645/164270034-fafed12e-2bc6-46ea-adfe-242bfb3b0e8b.png)
claunia commented 2026-01-31 05:19:20 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Apr 20, 2022):

Unfortunately for us, those colors were chosen under official guidance from the UI folks.

@DHowett commented on GitHub (Apr 20, 2022): Unfortunately for us, those colors were chosen under official guidance from the UI folks.
claunia commented 2026-01-31 05:19:20 +00:00
Author
Owner
Copy Link

@vefatica commented on GitHub (Apr 20, 2022):

How about the size of the symbol on the dropdown menu's icon? It's not the same size as the symbols on the icons for new tab, minimize, maximize, and close (compare to previous UI version). It just looks like a mistake!

@vefatica commented on GitHub (Apr 20, 2022): How about the size of the symbol on the dropdown menu's icon? It's not the same size as the symbols on the icons for new tab, minimize, maximize, and close (compare to previous UI version). It just looks like a mistake!
claunia commented 2026-01-31 05:19:21 +00:00
Author
Owner
Copy Link

@tropicaaal commented on GitHub (Apr 21, 2022):

Could the padding with the settings UI be increased? On larger window sizes it begins to look really cramped with almost no space between the title and content, and also seems to be inconsistent with other WinUI apps.

Current
image

Clock app
image

XAML Controls Gallery
image

Store
image

The WinUI design toolkit generally uses 56x44px padding across NavigationView:
image

@tropicaaal commented on GitHub (Apr 21, 2022): Could the padding with the settings UI be increased? On larger window sizes it begins to look really cramped with almost no space between the title and content, and also seems to be inconsistent with other WinUI apps. Current ![image](https://user-images.githubusercontent.com/42101043/164561491-2add0328-425f-48c5-a89b-cf41c424e4d0.png) Clock app ![image](https://user-images.githubusercontent.com/42101043/164561681-fa36d24f-da07-490d-a586-f42c28c4d31e.png) XAML Controls Gallery ![image](https://user-images.githubusercontent.com/42101043/164561787-0b83e687-a871-40fd-bbde-5962642a4aff.png) Store ![image](https://user-images.githubusercontent.com/42101043/164561891-51864e78-c551-4f76-b94a-2e0e213603d9.png) The WinUI design toolkit generally uses 56x44px padding across NavigationView: ![image](https://user-images.githubusercontent.com/42101043/164562188-25dc2456-dd7f-4f24-9b4a-bf7c025bf629.png)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Scenario Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16675
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?