starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Ssh MouseEvent doesn't work with touch input #15689

New Issue
Open
opened 2026-01-31 04:45:41 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 04:45:41 +00:00
Owner
Copy Link

Originally created by @juleshummelink on GitHub (Oct 26, 2021).

Windows Terminal version (or Windows build number)

1.10.2714.0

Other Software

found it out by using HTOP on a debian linux server connected via SSH

Steps to reproduce

  1. Ssh into a linux machine via the ssh [IP] command.
  2. Open HTOP by typing sudo htop
  3. Click with your mouse on a row, it becomes selected. Now touch on another row. Nothing happens.

Expected Behavior

Touch inputs are passed to SSH.

Actual Behavior

Touch doesn't work.

Originally created by @juleshummelink on GitHub (Oct 26, 2021). ### Windows Terminal version (or Windows build number) 1.10.2714.0 ### Other Software found it out by using HTOP on a debian linux server connected via SSH ### Steps to reproduce 1. Ssh into a linux machine via the `ssh [IP]` command. 2. Open HTOP by typing `sudo htop` 3. Click with your mouse on a row, it becomes selected. Now touch on another row. Nothing happens. ### Expected Behavior Touch inputs are passed to SSH. ### Actual Behavior Touch doesn't work.
claunia commented 2026-01-31 04:45:42 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 15, 2021):

Huh. It should. We must have put the mouse handling in specifically the pressed event and not the tapped event or something like that.

@zadjii-msft commented on GitHub (Nov 15, 2021): Huh. It should. We must have put the mouse handling in specifically the pressed event and not the tapped event or something like that.
claunia commented 2026-01-31 04:45:42 +00:00
Author
Owner
Copy Link

@juleshummelink commented on GitHub (Nov 15, 2021):

I found that the bug is not ssh related. Touch works nowhere inside the terminal window. It works only in the tab bar and to scroll...

Steps to reproduce:

  • type echo https://google.com/ and hit enter
  • Clicking on the link while holding ctrl will open the page in a browser, touching the link again does nothing.
@juleshummelink commented on GitHub (Nov 15, 2021): I found that the bug is not ssh related. Touch works nowhere inside the terminal window. It works only in the tab bar and to scroll... Steps to reproduce: - type `echo https://google.com/` and hit enter - Clicking on the link while holding <kbd>ctrl</kbd> will open the page in a browser, touching the link again does nothing.
claunia commented 2026-01-31 04:45:42 +00:00
Author
Owner
Copy Link

@awfulcooking commented on GitHub (May 4, 2024):

Does seem to affect TUIs in general rather than specific to SSH 🙂

e.g. htop in WSL, TUIs from Windows .exe.

(v1.19.11213.0 on W11 23H2)

@awfulcooking commented on GitHub (May 4, 2024): Does seem to affect TUIs in general rather than specific to SSH 🙂 e.g. htop in WSL, TUIs from Windows .exe. (v1.19.11213.0 on W11 23H2)
claunia commented 2026-01-31 04:45:42 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (May 4, 2024):

FYI, the reason this doesn't work is because the touch handler in Windows Terminal is completely separate from the click handler, and the only thing the touch handler supports is panning the scrollback buffer.

As a test, I commented out the code here:
3996806503/src/cascadia/TerminalControl/TermControl.cpp (L1707-L1713)

And that allows the touch events to be passed through to the regular click handler, which is good enough to get left clicks working. But of course the scrollback panning is then not supported, and it also doesn't handle right clicks. A proper fix will require more work than that.

It's also worth noting that touch input does actually work in openconsole/conhost.

@j4james commented on GitHub (May 4, 2024): FYI, the reason this doesn't work is because the touch handler in Windows Terminal is completely separate from the click handler, and the only thing the touch handler supports is panning the scrollback buffer. As a test, I commented out the code here: https://github.com/microsoft/terminal/blob/3996806503bd573aa59a27d1ee8e98bd1d135b8b/src/cascadia/TerminalControl/TermControl.cpp#L1707-L1713 And that allows the touch events to be passed through to the regular click handler, which is good enough to get left clicks working. But of course the scrollback panning is then not supported, and it also doesn't handle right clicks. A proper fix will require more work than that. It's also worth noting that touch input does actually work in openconsole/conhost.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Input Area-TerminalControl Help Wanted Issue-Bug Priority-2 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15689
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?