Terminal Core: Whenever we scroll the buffer, we RepaintAll #1572

Closed
opened 2026-01-30 22:30:55 +00:00 by claunia · 2 comments
Owner

Originally created by @zadjii-msft on GitHub (Jun 9, 2019).

Originally assigned to: @miniksa on GitHub.

In Terminal::_WriteBuffer, when we scroll the buffer, we tell the renderer to TriggerRedrawAll. This isn't necessary, we should probably just be telling the renderer to scroll the lines on screen.

The RedrawAll call was just a kludge while we were getting the Terminal stood up. Now that everything's working a bit better, we should make sure that RedrawAll is only called when absolutely necessary.

Originally created by @zadjii-msft on GitHub (Jun 9, 2019). Originally assigned to: @miniksa on GitHub. In `Terminal::_WriteBuffer`, when we scroll the buffer, we tell the renderer to `TriggerRedrawAll`. This isn't necessary, we should probably just be telling the renderer to scroll the lines on screen. The RedrawAll call was just a kludge while we were getting the Terminal stood up. Now that everything's working a bit better, we should make sure that RedrawAll is only called when absolutely necessary.
Author
Owner

@DHowett-MSFT commented on GitHub (Jan 28, 2020):

Related to #778.

@DHowett-MSFT commented on GitHub (Jan 28, 2020): Related to #778.
Author
Owner

@miniksa commented on GitHub (Apr 15, 2020):

This was resolved in #5185

@miniksa commented on GitHub (Apr 15, 2020): This was resolved in #5185
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1572