starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-09 02:26:45 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Assertion Failure calculating glyph spacing with certain UTF-8 chars #778

New Issue
Closed
opened 2026-01-30 22:03:53 +00:00 by claunia · 2 comments
claunia commented 2026-01-30 22:03:53 +00:00
Owner
Copy Link

Originally created by @oising on GitHub (May 7, 2019).

Originally assigned to: @miniksa on GitHub.

  • Your Windows build number: (Type ver at a Windows Command Prompt)

10.0.18362.53

  • What you're doing and what's happening: (Copy & paste specific commands and their output, or include screen shots)

Attempting to display the contents of an UTF-8 encoded text file, and an assertion failure occurs in std::vector, in turn caused by an array index out of bounds exception in CustomTextLayout.cpp with _textClusterColumns:

   for (auto i = run.glyphStart; i < (run.glyphStart + run.glyphCount); i++)
        {
            // Advance is how wide in pixels the glyph is
            auto& advance = _glyphAdvances[i];

            // Offsets is how far to move the origin (in pixels) from where it is
            auto& offset = _glyphOffsets[i];

            // Get how many columns we expected the glyph to have and mutiply into pixels.
            const auto columns = _textClusterColumns[i];    // <<< HERE
  • What's wrong / what should be happening instead:

it shud wurkkk.

I've attached the UTF-8 "torture test" text file that triggers the exception. I'm guessing this could be useful to integrate into your CI. Don't forget to chcp 65001 before cat'ing it in cmd ;)

UTF-8-demo.txt

Originally created by @oising on GitHub (May 7, 2019). Originally assigned to: @miniksa on GitHub. * Your Windows build number: (Type `ver` at a Windows Command Prompt) 10.0.18362.53 * What you're doing and what's happening: (Copy & paste specific commands and their output, or include screen shots) Attempting to display the contents of an UTF-8 encoded text file, and an assertion failure occurs in `std::vector`, in turn caused by an array index out of bounds exception in `CustomTextLayout.cpp` with `_textClusterColumns`: ```cpp for (auto i = run.glyphStart; i < (run.glyphStart + run.glyphCount); i++) { // Advance is how wide in pixels the glyph is auto& advance = _glyphAdvances[i]; // Offsets is how far to move the origin (in pixels) from where it is auto& offset = _glyphOffsets[i]; // Get how many columns we expected the glyph to have and mutiply into pixels. const auto columns = _textClusterColumns[i]; // <<< HERE ``` * What's wrong / what should be happening instead: it shud wurkkk. I've attached the UTF-8 "torture test" text file that triggers the exception. I'm guessing this could be useful to integrate into your CI. Don't forget to `chcp 65001` before `cat`'ing it in cmd ;) [UTF-8-demo.txt](https://github.com/microsoft/Terminal/files/3153810/UTF-8-demo.txt)
claunia added the Resolution-Fix-AvailableArea-RenderingIssue-BugProduct-Terminal labels 2026-01-30 22:03:53 +00:00
claunia commented 2026-01-30 22:03:54 +00:00
Author
Owner
Copy Link

@krokofant commented on GitHub (Aug 8, 2019):

I'm wondering if this is what I'm experiencing. When I first installed the Terminal it looked okay without the extra spacing but now the glyphs have more space than usual.

Windows Terminal
image

PowerShell Core
image

@krokofant commented on GitHub (Aug 8, 2019): I'm wondering if this is what I'm experiencing. When I first installed the Terminal it looked okay without the extra spacing but now the glyphs have more space than usual. **Windows Terminal** ![image](https://user-images.githubusercontent.com/5908498/62689315-dfc0d600-b9ca-11e9-8d94-517c8280260a.png) **PowerShell Core** ![image](https://user-images.githubusercontent.com/5908498/62690526-1ef02680-b9cd-11e9-82c0-4af9638746db.png)
claunia commented 2026-01-30 22:03:54 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 22, 2020):

Hey so this crash is gone in 0.8. I bet it was fixed even longer ago, but ain't nobody got time for bisecting. Sure, the alignment problems are still there occasionally, but I believe that's tracked by other issues. I'm gonna close this for now. Thanks!

@zadjii-msft commented on GitHub (Jan 22, 2020): Hey so this crash is gone in 0.8. I bet it was fixed even longer ago, but _ain't nobody got time for bisecting_. Sure, the alignment problems are still there occasionally, but I believe that's tracked by other issues. I'm gonna close this for now. Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Issue-Bug Product-Terminal Resolution-Fix-Available
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#778
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?