starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #4912] [MERGED] til::rectangle #26033

New Issue
Open
opened 2026-01-31 09:13:30 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:13:30 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4912
Author: @miniksa
Created: 3/13/2020
Status: ✅ Merged
Merged: 3/14/2020
Merged by: @undefined

Base: master ← Head: dev/miniksa/til_rectangle

📝 Commits (6)

  • 56420f0 Pull out til::rectangle for separate submission.
  • 3861693 Add natvis.
  • 8b0d892 Code format, of course.
  • 21bde5a didn't need to define assignment, let it be default for rule of 5.
  • 1fba953 some typos
  • 2d0888e Use CheckSub to be clearer about the math and drop some parentheses per nit comment.

📊 Changes

10 files changed (+1517 additions, -4 deletions)

View changed files

📝 src/inc/til.h (+1 -0)
📝 src/inc/til/point.h (+2 -2)
➕ src/inc/til/rectangle.h (+484 -0)
📝 src/inc/til/size.h (+2 -2)
📝 src/inc/til/some.h (+58 -0)
➕ src/til/ut_til/RectangleTests.cpp (+932 -0)
📝 src/til/ut_til/SomeTests.cpp (+32 -0)
📝 src/til/ut_til/til.unit.tests.vcxproj (+1 -0)
📝 src/til/ut_til/til.unit.tests.vcxproj.filters (+1 -0)
📝 tools/ConsoleTypes.natvis (+4 -0)

📄 Description

Summary of the Pull Request

Introduces convenience type til::rectangle which automatically implements our best practices for rectangle-related types and provides automatic conversions in/out of the relevant types.

PR Checklist

  • In support of Differential Rendering #778
  • I work here.
  • Tests added/passed
  • I'm a core contributor.

Detailed Description of the Pull Request / Additional comments

  • Automatically converts in from anything with a Left/Top/Right/Bottom or left/top/right/bottom (Win32 RECT)
  • Automatically converts Console type SMALL_RECT and shifts it from inclusive to exclusive on instantiation
  • Automatically converts out to SMALL_RECT (converting back to inclusive), RECT, or D2D1_RECT_F.
  • Constructs from bare integers written into source file
  • Constructs from a single til::point as a 1x1 size rectangle with top-left corner (origin) at that point
  • Constructs from a single til::size as a WxH size rectangle with top-left corner (origin) at 0,0
  • Constructs from a til::point and a til::size representing the top-left corner and the width by height.
  • Constructs from a til::point and another til::point representing the top-left corner and the exclusive bottom-right corner.
  • Default constructs to empty
  • Uses Chromium numerics for all basic math operations (+, -, *, /)
  • Provides equality tests
  • Provides operator bool to know when it's valid (has an area > 0) and empty() to know the contrary
  • Accessors for left/top/right/bottom
  • Type converting accessors (that use safe conversions and throw) for left/top/right/bottom
  • Convenience methods for finding width/height (with Chromium numerics operations) and type-converting templates (with Chromium numerics conversions).
  • Accessors for origin (top-left point) and the size/dimensions (as a til::size).
  • Intersect operation on operator & to find where two til::rectangles overlap, returned as a til::rectangle.
  • Union operation on operator | to find the total area covered by two til::rectangles, returned as a til::rectangle.
  • Subtract operation on operator - to find the area remaining after one til::rectangle is removed from another, returned as a til::some<til::rectangle, 4>.
  • TAEF/WEX Output and Comparators so they will print very nicely with VERIFY and Log macros in our testing suite.
  • Additional comparators, TAEF/WEX output, and tests written on til::some to support the Subtract operation.
  • A natvis

Validation Steps Performed

  • See automated tests of functionality.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4912 **Author:** [@miniksa](https://github.com/miniksa) **Created:** 3/13/2020 **Status:** ✅ Merged **Merged:** 3/14/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/miniksa/til_rectangle` --- ### 📝 Commits (6) - [`56420f0`](https://github.com/microsoft/terminal/commit/56420f064161a5ff596abf4b90c9c891d38064e3) Pull out til::rectangle for separate submission. - [`3861693`](https://github.com/microsoft/terminal/commit/386169316b6a5a9544cba435581a7d7670980212) Add natvis. - [`8b0d892`](https://github.com/microsoft/terminal/commit/8b0d892c8e7c126fbbecd886ea55fac5fefbbdc9) Code format, of course. - [`21bde5a`](https://github.com/microsoft/terminal/commit/21bde5a5339fba2ae7ccee7f43c753dd334e113f) didn't need to define assignment, let it be default for rule of 5. - [`1fba953`](https://github.com/microsoft/terminal/commit/1fba95398e4e7f38f7c97080e93260f8ff9f209e) some typos - [`2d0888e`](https://github.com/microsoft/terminal/commit/2d0888eea95dd0248ec96fc3aed50dab011e7fb4) Use CheckSub to be clearer about the math and drop some parentheses per nit comment. ### 📊 Changes **10 files changed** (+1517 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/inc/til.h` (+1 -0) 📝 `src/inc/til/point.h` (+2 -2) ➕ `src/inc/til/rectangle.h` (+484 -0) 📝 `src/inc/til/size.h` (+2 -2) 📝 `src/inc/til/some.h` (+58 -0) ➕ `src/til/ut_til/RectangleTests.cpp` (+932 -0) 📝 `src/til/ut_til/SomeTests.cpp` (+32 -0) 📝 `src/til/ut_til/til.unit.tests.vcxproj` (+1 -0) 📝 `src/til/ut_til/til.unit.tests.vcxproj.filters` (+1 -0) 📝 `tools/ConsoleTypes.natvis` (+4 -0) </details> ### 📄 Description ## Summary of the Pull Request Introduces convenience type `til::rectangle` which automatically implements our best practices for rectangle-related types and provides automatic conversions in/out of the relevant types. ## PR Checklist * [x] In support of Differential Rendering #778 * [X] I work here. * [x] Tests added/passed * [x] I'm a core contributor. ## Detailed Description of the Pull Request / Additional comments - Automatically converts in from anything with a Left/Top/Right/Bottom or left/top/right/bottom (Win32 `RECT`) - Automatically converts Console type `SMALL_RECT` and shifts it from **inclusive** to **exclusive** on instantiation - Automatically converts out to `SMALL_RECT` (converting back to **inclusive**), `RECT`, or `D2D1_RECT_F`. - Constructs from bare integers written into source file - Constructs from a single `til::point` as a 1x1 size rectangle with top-left corner (origin) at that point - Constructs from a single `til::size` as a WxH size rectangle with top-left corner (origin) at 0,0 - Constructs from a `til::point` and a `til::size` representing the top-left corner and the width by height. - Constructs from a `til::point` and another `til::point` representing the top-left corner and the **exclusive** bottom-right corner. - Default constructs to empty - Uses Chromium numerics for all basic math operations (+, -, *, /) - Provides equality tests - Provides `operator bool` to know when it's valid (has an area > 0) and `empty()` to know the contrary - Accessors for left/top/right/bottom - Type converting accessors (that use safe conversions and throw) for left/top/right/bottom - Convenience methods for finding width/height (with Chromium numerics operations) and type-converting templates (with Chromium numerics conversions). - Accessors for origin (top-left point) and the size/dimensions (as a `til::size`). - Intersect operation on `operator &` to find where two `til::rectangle`s overlap, returned as a `til::rectangle`. - Union operation on `operator |` to find the total area covered by two `til::rectangles`, returned as a `til::rectangle`. - Subtract operation on `operator -` to find the area remaining after one `til::rectangle` is removed from another, returned as a `til::some<til::rectangle, 4>`. - TAEF/WEX Output and Comparators so they will print very nicely with `VERIFY` and `Log` macros in our testing suite. - Additional comparators, TAEF/WEX output, and tests written on `til::some` to support the Subtract operation. - A natvis ## Validation Steps Performed - See automated tests of functionality. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:13:30 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26033
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?