starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #4897] [MERGED] til::point #26012

New Issue
Open
opened 2026-01-31 09:13:21 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:13:21 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4897
Author: @miniksa
Created: 3/12/2020
Status: ✅ Merged
Merged: 3/13/2020
Merged by: @undefined

Base: master ← Head: dev/miniksa/til_point

📝 Commits (2)

  • 7352b05 Pull til::point from dev/miniksa/bitmap for separate PR processing.
  • bc04b62 code format pass for excess whitespace.

📊 Changes

6 files changed (+718 additions, -1 deletions)

View changed files

📝 src/inc/til.h (+1 -0)
➕ src/inc/til/point.h (+248 -0)
➕ src/til/ut_til/PointTests.cpp (+461 -0)
📝 src/til/ut_til/til.unit.tests.vcxproj (+1 -0)
📝 src/til/ut_til/til.unit.tests.vcxproj.filters (+2 -0)
📝 tools/ConsoleTypes.natvis (+5 -1)

📄 Description

Summary of the Pull Request

Introduces convenience type til::point which automatically implements our best practices for point-related types and provides automatic conversions in/out of the relevant types.

PR Checklist

  • In support of Differential Rendering #778
  • I work here.
  • Tests added/passed
  • I'm a core contributor.

Detailed Description of the Pull Request / Additional comments

  • Automatically converts in from anything with a X/Y (console COORD) or x/y (Win32 POINT)
  • Automatically converts out to COORD, POINT, or D2D1_POINT_2F.
  • Constructs from bare integers written into source file
  • Default constructs to empty
  • Uses Chromium Math for all basic math operations (+, -, *, /)
  • Provides equality tests
  • Accessors for x/y
  • Type converting accessors (that use safe conversions and throw) for x/y
  • TAEF/WEX Output and Comparators so they will print very nicely with VERIFY and Log macros in our testing suite.
  • A natvis

Validation Steps Performed

  • See automated tests of functionality.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4897 **Author:** [@miniksa](https://github.com/miniksa) **Created:** 3/12/2020 **Status:** ✅ Merged **Merged:** 3/13/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/miniksa/til_point` --- ### 📝 Commits (2) - [`7352b05`](https://github.com/microsoft/terminal/commit/7352b05fe53590643d0cdd72d9d32c85c62ad58b) Pull til::point from dev/miniksa/bitmap for separate PR processing. - [`bc04b62`](https://github.com/microsoft/terminal/commit/bc04b621cae1c5f7f67f18d291f563a0f5cc1131) code format pass for excess whitespace. ### 📊 Changes **6 files changed** (+718 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/inc/til.h` (+1 -0) ➕ `src/inc/til/point.h` (+248 -0) ➕ `src/til/ut_til/PointTests.cpp` (+461 -0) 📝 `src/til/ut_til/til.unit.tests.vcxproj` (+1 -0) 📝 `src/til/ut_til/til.unit.tests.vcxproj.filters` (+2 -0) 📝 `tools/ConsoleTypes.natvis` (+5 -1) </details> ### 📄 Description ## Summary of the Pull Request Introduces convenience type `til::point` which automatically implements our best practices for point-related types and provides automatic conversions in/out of the relevant types. ## PR Checklist * [x] In support of Differential Rendering #778 * [X] I work here. * [x] Tests added/passed * [x] I'm a core contributor. ## Detailed Description of the Pull Request / Additional comments - Automatically converts in from anything with a X/Y (console `COORD`) or x/y (Win32 `POINT`) - Automatically converts out to `COORD`, `POINT`, or `D2D1_POINT_2F`. - Constructs from bare integers written into source file - Default constructs to empty - Uses Chromium Math for all basic math operations (+, -, *, /) - Provides equality tests - Accessors for x/y - Type converting accessors (that use safe conversions and throw) for x/y - TAEF/WEX Output and Comparators so they will print very nicely with `VERIFY` and `Log` macros in our testing suite. - A natvis ## Validation Steps Performed - See automated tests of functionality. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:13:21 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26012
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?