starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Incorrect background color when copying content to the clipboard as HTML #16191

New Issue
Open
opened 2026-01-31 05:00:18 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 05:00:18 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Dec 17, 2021).

Windows Terminal version

1.12.3472.0

Windows build number

10.0.19041.1348

Other Software

No response

Steps to reproduce

  1. Open a bash shell in Windows Terminal.
  2. Change the default palette to pink on purple using an OSC escape sequence:
    printf "\e]10;rgb:ff/88/88;rgb:88/44/88\e\\"
  3. Enable the reverse screen mode, so it changes to purple on pink:
    printf "\e[?5h"
  4. Copy some content from the window and paste somewhere that accepts HTML. You can test in a simple html file like this:
    <p contenteditable="true"></p>
  5. Repeat the same process in an OpenConsole/conhost window. You'll need a recent build for the palette and mode sequences to work, and remember to hold down Alt while copying in order for it to copy the content as HTML.

Expected Behavior

The background color of the pasted content should match the pink background that is displayed on screen.

Actual Behavior

When copying from Windows Terminal, the default background fill is black (or whatever the background was of the starting color scheme).

image

When copying from OpenConsole/conhost, the default background fill is purple, i.e. it's taking the palette change into account, but not the reverse screen mode.

image

Just looking at the code, I think the WPF control probably gets this right. It calculates the background using GetAttributeColors with a default TextAttribute instance, and then takes the second returned value (i.e. the background). That should return the actual runtime color that the renderer is using.

So my proposed fix is we do exactly the same thing in the Windows Terminal and conhost implementations.

Originally created by @j4james on GitHub (Dec 17, 2021). ### Windows Terminal version 1.12.3472.0 ### Windows build number 10.0.19041.1348 ### Other Software _No response_ ### Steps to reproduce 1. Open a bash shell in Windows Terminal. 2. Change the default palette to pink on purple using an OSC escape sequence: `printf "\e]10;rgb:ff/88/88;rgb:88/44/88\e\\"` 3. Enable the reverse screen mode, so it changes to purple on pink: `printf "\e[?5h"` 4. Copy some content from the window and paste somewhere that accepts HTML. You can test in a simple html file like this: `<p contenteditable="true"></p>` 5. Repeat the same process in an OpenConsole/conhost window. You'll need a recent build for the palette and mode sequences to work, and remember to hold down <kbd>Alt</kbd> while copying in order for it to copy the content as HTML. ### Expected Behavior The background color of the pasted content should match the pink background that is displayed on screen. ### Actual Behavior When copying from Windows Terminal, the default background fill is black (or whatever the background was of the starting color scheme). ![image](https://user-images.githubusercontent.com/4181424/146619995-5629e97a-8964-4574-b577-b237f32a329d.png) When copying from OpenConsole/conhost, the default background fill is purple, i.e. it's taking the palette change into account, but not the reverse screen mode. ![image](https://user-images.githubusercontent.com/4181424/146620071-c0452f2e-0e8d-48ea-8ae7-176abad94622.png) Just looking at the code, I think the WPF control probably gets this right. It calculates the background using `GetAttributeColors` with a default `TextAttribute` instance, and then takes the second returned value (i.e. the background). That should return the actual runtime color that the renderer is using. So my proposed fix is we do exactly the same thing in the Windows Terminal and conhost implementations.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Output Issue-Bug Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16191
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?