starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #16270] Use full TextAttribute when copying data into Clipboard #30886

New Issue
Closed
opened 2026-01-31 09:43:34 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:43:34 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/16270

State: closed
Merged: No

This PR replaces TextBuffer::TextAndColor with TextBuffer::TextAndAttribute which gives us the opportunity to use all of the text attribute we save within buffer while copying data into the clipboard.

We'll use til::small_rle for storing the attributes for each row in the selection rect. This helps in minimizing the memory required for storing all the attribute of a row.

This PR also fixes two bugs in the formatted copy:

  • We were applying line breaks after every selected TextBuffer row, even though the row could have been a wrapped row. This caused wrapped rows to break when they shouldn't. Fix: we now add a newline (<BR> in HTML, \line in RTF) only when we see \r or \n in the text.
  • We were mishandling Unicode text (\uN) within RTF copy. Every next character that uses a surrogate pair or high codepoint was missing in the copied text when pasted to Word. Fix: command \uc4 should have been \uc1, which is used to tell how many characters will be used as a fallback for a unicode character. We always use 1 ? character as the fallback (and not 4, as was the case).

Validation Steps Performed

  • All copying scenarios work as before.
  • Used this echo string from #12586 to validate we are copying all characters of the string.
echo "This is some Ascii \ {}`nLow code units: á é í ó ú `u{2b81} `u{2b82}`nHigh code units: `u{a7b5} `u{a7b7}`nSurrogates: `u{1f366} `u{1f47e} `u{1f440}"

PR Checklist

**Original Pull Request:** https://github.com/microsoft/terminal/pull/16270 **State:** closed **Merged:** No --- This PR replaces `TextBuffer::TextAndColor` with `TextBuffer::TextAndAttribute` which gives us the opportunity to use all of the text attribute we save within buffer while copying data into the clipboard. We'll use `til::small_rle` for storing the attributes for each row in the selection rect. This helps in minimizing the memory required for storing all the attribute of a row. This PR also fixes two bugs in the formatted copy: - We were applying line breaks after every _selected_ `TextBuffer` row, even though the row could have been a wrapped row. This caused wrapped rows to break when they shouldn't. **Fix: we now add a newline (`<BR>` in HTML, `\line` in RTF) only when we see `\r` or `\n` in the text.** - We were mishandling Unicode text (`\uN`) within RTF copy. Every next character that uses a surrogate pair or high codepoint was missing in the copied text when pasted to **Word**. **Fix: command `\uc4` should have been `\uc1`**, which is used to tell how many characters will be used as a fallback for a unicode character. We always use 1 `?` character as the fallback (and not 4, as was the case). ## Validation Steps Performed - All copying scenarios work as before. - Used this echo string from #12586 to validate we are copying *all* characters of the string. ```pwsh echo "This is some Ascii \ {}`nLow code units: á é í ó ú `u{2b81} `u{2b82}`nHigh code units: `u{a7b5} `u{a7b7}`nSurrogates: `u{1f366} `u{1f47e} `u{1f440}" ``` ## PR Checklist - [x] Closes #16191 - [x] Add other attributes to formatted-copy - [x] Refactor `GenRTF` and `GenHTML` to loop using `TextAttrbute` RLE runs. - [ ] Refactor most of our Copy codepaths to get rid of `GetText` and the stuff we do with `TextAndColor`/`TextAndAttribute`. `GenHTML` and `GenRTF` read from the buffer directly.
claunia added the pull-request label 2026-01-31 09:43:34 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30886
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?