starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

We broke \\wsl$ paths with osc 9;9? #16339

New Issue
Closed
opened 2026-01-31 05:04:35 +00:00 by claunia · 8 comments
claunia commented 2026-01-31 05:04:35 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Jan 3, 2022).

this change makes osc 9;9 work with linux paths but breaks \\wsl$ ones
docs at https://docs.microsoft.com/windows/terminal/tutorials/new-tab-same-directory will need to be updated

Originally posted by @LuanVSO in https://github.com/microsoft/terminal/issues/9223#issuecomment-1001721456

Originally created by @zadjii-msft on GitHub (Jan 3, 2022). > this change makes osc 9;9 work with linux paths but breaks `\\wsl$` ones > docs at https://docs.microsoft.com/windows/terminal/tutorials/new-tab-same-directory will need to be updated _Originally posted by @LuanVSO in https://github.com/microsoft/terminal/issues/9223#issuecomment-1001721456_
claunia commented 2026-01-31 05:04:36 +00:00
Author
Owner
Copy Link

@LuanVSO commented on GitHub (Jan 3, 2022):

The new behavior is kind of better because it accepts untranslated Linux paths, you just need to remove the call to wslpath from the script to make it work again

@LuanVSO commented on GitHub (Jan 3, 2022): The new behavior is kind of better because it accepts untranslated Linux paths, you just need to remove the call to `wslpath` from the script to make it work again
claunia commented 2026-01-31 05:04:37 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 3, 2022):

FWIW, launching WSL with \\wsl$ itself does not have an issue. I can't see how #9223 broke it, unless for some reason the OSC 9;9 it generates is using / instead of \. That's going to burn some folks, but not nearly as many as the other behavior did!

image
@DHowett commented on GitHub (Jan 3, 2022): FWIW, launching WSL with `\\wsl$` itself does not have an issue. I can't see how #9223 broke it, unless for some reason the OSC 9;9 it generates is using `/` instead of `\`. That's going to burn some folks, but not nearly as many as the other behavior did! <img width="349" alt="image" src="https://user-images.githubusercontent.com/189190/147979705-365a5928-854d-4131-985e-48226f4c34d8.png">
claunia commented 2026-01-31 05:04:37 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 3, 2022):

image

Another victim of our path absoluting code.

@DHowett commented on GitHub (Jan 3, 2022): <img width="358" alt="image" src="https://user-images.githubusercontent.com/189190/147979900-d6a6f298-1b7d-4668-bd1b-139dc5370e8f.png"> Another victim of our path absoluting code.
claunia commented 2026-01-31 05:04:37 +00:00
Author
Owner
Copy Link

@LuanVSO commented on GitHub (Jan 4, 2022):

oh, so it's already fixed by #12050

@LuanVSO commented on GitHub (Jan 4, 2022): oh, so it's already fixed by #12050
claunia commented 2026-01-31 05:04:38 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 4, 2022):

I'm not sure actually- didn't that only fix instances where the directory was one character long?

@DHowett commented on GitHub (Jan 4, 2022): I'm not sure actually- didn't that only fix instances where the directory was one character long?
claunia commented 2026-01-31 05:04:38 +00:00
Author
Owner
Copy Link

@LuanVSO commented on GitHub (Jan 4, 2022):

i tested it on my build of terminal from that branch and it worked fine.
image
image

tested with a windows path too.
got any more whacky path to test?

@LuanVSO commented on GitHub (Jan 4, 2022): i tested it on my build of terminal from that branch and it worked fine. ![image](https://user-images.githubusercontent.com/43626415/147995948-3555fabe-30e0-4851-b2d5-ff212652a418.png) ![image](https://user-images.githubusercontent.com/43626415/147995980-2a4a9d1c-b6c4-4af4-b9cd-c95359f52559.png) tested with a windows path too. got any more whacky path to test?
claunia commented 2026-01-31 05:04:38 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 4, 2022):

Naw, this looks great! Thanks!

@DHowett commented on GitHub (Jan 4, 2022): Naw, this looks great! Thanks!
claunia commented 2026-01-31 05:04:38 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 6, 2022):

Thanks for fixing that for us! 😄

@zadjii-msft commented on GitHub (Jan 6, 2022): Thanks for fixing that for us! 😄
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalConnection Issue-Bug Needs-Triage Priority-1 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16339
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?