starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Make keys in the command palette look like actual keys, like in VS Code #9223

New Issue
Closed
opened 2026-01-31 01:49:05 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 01:49:05 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Jun 23, 2020).

Omitted from initial implementation in #6635.

Add little borders & boxes to really emphasize that the keys are keys to press. I don't know how to do this in XAML, but I think it would be a bit of nice polish.

Originally created by @zadjii-msft on GitHub (Jun 23, 2020). Omitted from initial implementation in #6635. Add little borders & boxes to really emphasize that the keys are _keys_ to press. I don't know how to do this in XAML, but I think it would be a bit of nice polish.
claunia commented 2026-01-31 01:49:06 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (Jun 25, 2020):

Omitted from initial implementation in #6635.

Add little borders & boxes to really emphasize that the keys are keys to press. I don't know how to do this in XAML, but I think it would be a bit of nice polish.

I think PowerToys does something similar with its Key Remapping.
image

Maybe you could decide on a "house style" to try to be consistent?

@mdtauk commented on GitHub (Jun 25, 2020): > Omitted from initial implementation in #6635. > > Add little borders & boxes to really emphasize that the keys are _keys_ to press. I don't know how to do this in XAML, but I think it would be a bit of nice polish. I think PowerToys does something similar with its Key Remapping. ![image](https://user-images.githubusercontent.com/7389110/85791420-b10a3600-b729-11ea-8434-e1052cdee5d3.png) Maybe you could decide on a "house style" to try to be consistent?
claunia commented 2026-01-31 01:49:07 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 25, 2020):

Strong veto. When we have key chords (as opposed to just key notes, see #1334), then we'll definitely want to keep the current design, for something like Ctrl+K+Ctrl+U.

from @zadjii-msft

This is at odds with #1334 now. We currently have a version that displays each key chord in its own pill.

@DHowett commented on GitHub (Jun 25, 2020): > Strong veto. When we have key _chords_ (as opposed to just key _notes_, see #1334), then we'll definitely want to keep the current design, for something like <kbd>Ctrl+K</kbd>+<kbd>Ctrl+U</kbd>. _from @zadjii-msft_ This is at odds with #1334 now. We currently have a version that displays each key _chord_ in its own pill.
claunia commented 2026-01-31 01:49:07 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 25, 2020):

When we have chords composed of notes (i.e, when implementing #1334), we should come back around to update this UI too 😉

@zadjii-msft commented on GitHub (Jun 25, 2020): When we have chords composed of notes (i.e, when implementing #1334), we should come back around to update this UI too 😉
claunia commented 2026-01-31 01:49:07 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 22, 2020):

:tada:This issue was addressed in #6635, which has now been successfully released as Windows Terminal Preview v1.2.2022.0.🎉

Handy links:

@ghost commented on GitHub (Jul 22, 2020): :tada:This issue was addressed in #6635, which has now been successfully released as `Windows Terminal Preview v1.2.2022.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.2.2022.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Help Wanted Issue-Task Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9223
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?