[PR #10045] [MERGED] Disable path validation, add warning #27869

Open
opened 2026-01-31 09:24:47 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10045
Author: @zadjii-msft
Created: 5/6/2021
Status: Merged
Merged: 5/12/2021
Merged by: @undefined

Base: mainHead: dev/migrie/b/9541-dont-validate-paths


📝 Commits (4)

  • a13fd5e Disable path validation, add warning
  • 00ae811 Merge remote-tracking branch 'origin/main' into dev/migrie/b/9541-dont-validate-paths
  • 37e5da4 wording nits
  • 4f841c6 howd you get there...?

📊 Changes

3 files changed (+29 additions, -17 deletions)

View changed files

📝 src/cascadia/TerminalConnection/ConptyConnection.cpp (+13 -1)
📝 src/cascadia/TerminalConnection/Resources/en-US/Resources.resw (+5 -1)
📝 src/cascadia/TerminalSettingsModel/Profile.cpp (+11 -15)

📄 Description

This is primarily being done to unblock #9223.

Prior to this, we'd validate that the user's startingDirectory existed
here. If it was invalid, we'd gracefully fall back to %USERPROFILE%.

However, that could cause hangs when combined with WSL. When the WSL
filesystem is slow to respond, we'll end up waiting indefinitely for
their filesystem driver to respond. This can result in the whole terminal
becoming unresponsive.

Similarly, with #9223 we want users to be able to specify WSL paths in a
profile, but this bit of validation logic totally prevents that from working,
because it'll just replace the path with %USERPROFILE%.

If the path is eventually invalid, we'll display warning in the
ConptyConnection, when the process fails to launch.

Closes #9541
Closes #9114

image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10045 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 5/6/2021 **Status:** ✅ Merged **Merged:** 5/12/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/9541-dont-validate-paths` --- ### 📝 Commits (4) - [`a13fd5e`](https://github.com/microsoft/terminal/commit/a13fd5e47a810687e97a2c6a044cf02fd65ca29e) Disable path validation, add warning - [`00ae811`](https://github.com/microsoft/terminal/commit/00ae811517f6bad34a4047d0e2d288d599be0ee0) Merge remote-tracking branch 'origin/main' into dev/migrie/b/9541-dont-validate-paths - [`37e5da4`](https://github.com/microsoft/terminal/commit/37e5da4fa7d3c69a251dad3f2bc7565f687b0b6a) wording nits - [`4f841c6`](https://github.com/microsoft/terminal/commit/4f841c6bbd41811089767cac878b7eff95a2d04a) howd you get there...? ### 📊 Changes **3 files changed** (+29 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalConnection/ConptyConnection.cpp` (+13 -1) 📝 `src/cascadia/TerminalConnection/Resources/en-US/Resources.resw` (+5 -1) 📝 `src/cascadia/TerminalSettingsModel/Profile.cpp` (+11 -15) </details> ### 📄 Description This is primarily being done to unblock #9223. Prior to this, we'd validate that the user's `startingDirectory` existed here. If it was invalid, we'd gracefully fall back to `%USERPROFILE%`. However, that could cause hangs when combined with WSL. When the WSL filesystem is slow to respond, we'll end up waiting indefinitely for their filesystem driver to respond. This can result in the whole terminal becoming unresponsive. Similarly, with #9223 we want users to be able to specify WSL paths in a profile, but this bit of validation logic totally prevents that from working, because it'll just replace the path with `%USERPROFILE%`. If the path is eventually invalid, we'll display warning in the `ConptyConnection`, when the process fails to launch. Closes #9541 Closes #9114 ![image](https://user-images.githubusercontent.com/18356694/117318675-426d2d00-ae50-11eb-9cc0-0b23c397472c.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:24:47 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27869