Change radio button options in settings to listbox options #16956

Closed
opened 2026-01-31 05:28:23 +00:00 by claunia · 4 comments
Owner

Originally created by @Lo0oG on GitHub (Mar 9, 2022).

Description of the new feature/enhancement

Since the settings area changed over to the Windows 11 style, extra navigation is needed to the any settings that use radio buttons to display the options.

image

An example below is the theme setting.

image

If these radio options were changed into listbox options (similar to the language option) then the currently set value would be visible immediatly and could be changed easier without the need for extra navigation to expand the box.

Originally created by @Lo0oG on GitHub (Mar 9, 2022). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement Since the settings area changed over to the Windows 11 style, extra navigation is needed to the any settings that use radio buttons to display the options. ![image](https://user-images.githubusercontent.com/50969206/157496473-277b70bc-9b43-4f5c-a88f-7074eea612f5.png) An example below is the theme setting. ![image](https://user-images.githubusercontent.com/50969206/157496591-e7956dcc-869b-4e68-8bd8-2601dc8ba935.png) If these radio options were changed into listbox options (similar to the language option) then the currently set value would be visible immediatly and could be changed easier without the need for extra navigation to expand the box. <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). -->
Author
Owner

@zadjii-msft commented on GitHub (Mar 10, 2022):

Yep, this is something we're planning on doing, just haven't had the chance to do yet.

image

https://github.com/microsoft/terminal/compare/dev/migrie/b/12648-radio-to-combobox has a super simple proof of concept of how easy this should be to do. I haven't validated a11y properties on that though, which I think was our biggest concern? But this is super easy so we may want to pull in for 1.14. @PankajBhojwani for thoughts. He may remember why we hadn't done this before.

@zadjii-msft commented on GitHub (Mar 10, 2022): Yep, this is something we're planning on doing, just haven't had the chance to do yet. ![image](https://user-images.githubusercontent.com/18356694/157659897-bf13b865-a5f0-4909-8236-4540502d71a1.png) https://github.com/microsoft/terminal/compare/dev/migrie/b/12648-radio-to-combobox has a super simple proof of concept of how easy this should be to do. I haven't validated a11y properties on that though, which I _think_ was our biggest concern? But this is super easy so we may want to pull in for 1.14. @PankajBhojwani for thoughts. He may remember why we hadn't done this before.
Author
Owner

@DHowett commented on GitHub (Mar 10, 2022):

i love it

@DHowett commented on GitHub (Mar 10, 2022): i love it
Author
Owner

@ghost commented on GitHub (May 24, 2022):

:tada:This issue was addressed in #12833, which has now been successfully released as Windows Terminal v1.13.1143.🎉

Handy links:

@ghost commented on GitHub (May 24, 2022): :tada:This issue was addressed in #12833, which has now been successfully released as `Windows Terminal v1.13.1143`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.13.1143) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Author
Owner

@ghost commented on GitHub (May 24, 2022):

:tada:This issue was addressed in #12833, which has now been successfully released as Windows Terminal Preview v1.14.143.🎉

Handy links:

@ghost commented on GitHub (May 24, 2022): :tada:This issue was addressed in #12833, which has now been successfully released as `Windows Terminal Preview v1.14.143`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.14.143) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16956