starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Shader files not loading in 1.7 #12833

New Issue
Closed
opened 2026-01-31 03:26:09 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 03:26:09 +00:00
Owner
Copy Link

Originally created by @Nacimota on GitHub (Mar 3, 2021).

Originally assigned to: @PankajBhojwani on GitHub.

Environment

Windows build number: 10.0.19042.0
Windows Terminal version: 1.7.572.0

Steps to reproduce

  1. Build/Install Windows Terminal 1.7.572.0
  2. Set experimental.pixelShaderPath on a profile (or globally) such that it points to an appropriately structured HLSL file (such as Invert.hlsl from the samples folder)
  3. Run the terminal (with the appropriate profile if necessary)

Expected behavior

The pixel shader is loaded and executed.

Actual behavior

The pixel shader is not loaded.

Comments

I have not been able to load any shader files at all in 1.7 from the official release, nor when I build it from source. Poking around in the debugger, I can see that the shader file path is definitely there when the JSON is read in:

CascadiaSettingsSerialization.cpp 1.7 branch

However it seems to disappear at some point between being read and sent to SetPixelShaderPath(). I'm not sure if it's being deserialized correctly because I don't really understand how I'm supposed to inspect the settings object; it doesn't behave the way I'd expect it to (just C++ things, I assume).

release-1.7

DxRenderer.cpp 1.7 branch

release-1.6

DxRenderer.cpp 1.6 branch

I've tried this on other machines that have never had any version of the Terminal installed and they all exhibit the same issue.

Originally created by @Nacimota on GitHub (Mar 3, 2021). Originally assigned to: @PankajBhojwani on GitHub. # Environment ```none Windows build number: 10.0.19042.0 Windows Terminal version: 1.7.572.0 ``` # Steps to reproduce 1. Build/Install Windows Terminal 1.7.572.0 2. Set `experimental.pixelShaderPath` on a profile (or globally) such that it points to an appropriately structured HLSL file (such as `Invert.hlsl` from the samples folder) 3. Run the terminal (with the appropriate profile if necessary) # Expected behavior The pixel shader is loaded and executed. # Actual behavior The pixel shader is not loaded. # Comments I have not been able to load any shader files at all in 1.7 from the official release, nor when I build it from source. Poking around in the debugger, I can see that the shader file path is definitely there when the JSON is read in: ![CascadiaSettingsSerialization.cpp 1.7 branch](https://user-images.githubusercontent.com/651955/109766645-2d063780-7c42-11eb-9724-ffde02aebf36.png) However it seems to disappear at some point between being read and sent to `SetPixelShaderPath()`. I'm not sure if it's being deserialized correctly because I don't really understand how I'm supposed to inspect the settings object; it doesn't behave the way I'd expect it to (just C++ things, I assume). ### release-1.7 ![DxRenderer.cpp 1.7 branch](https://user-images.githubusercontent.com/651955/109764925-df88cb00-7c3f-11eb-8c78-e297cf2c4382.png) ### release-1.6 ![DxRenderer.cpp 1.6 branch](https://user-images.githubusercontent.com/651955/109765459-9d13be00-7c40-11eb-981a-e67a96545f29.png) I've tried this on other machines that have never had any version of the Terminal installed and they all exhibit the same issue.
claunia commented 2026-01-31 03:26:10 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 3, 2021):

Well that's batty. Maybe that's what's causing #9338?

I'm gonna real quick @DHowett because he was helping investigate another bug where the shader path would get absolutely mangled before making it into the DxRenderer.

@zadjii-msft commented on GitHub (Mar 3, 2021): Well that's _batty_. Maybe that's what's causing #9338? I'm gonna real quick @DHowett because he was helping investigate another bug where the shader path would get absolutely mangled before making it into the DxRenderer.
claunia commented 2026-01-31 03:26:11 +00:00
Author
Owner
Copy Link

@Nacimota commented on GitHub (Mar 3, 2021):

Well that's batty. Maybe that's what's causing #9338?

I did see that issue, but I decided to post a separate one because they're using 1.6, which has no problems for me, and they're also experiencing an error message, which I'm not getting even if use a non-existent path (because it just becomes an empty string, I guess). Could still be related though? ¯\_(ツ)_/¯

@Nacimota commented on GitHub (Mar 3, 2021): > Well that's _batty_. Maybe that's what's causing #9338? I did see that issue, but I decided to post a separate one because they're using 1.6, which has no problems for me, and they're also experiencing an error message, which I'm not getting even if use a non-existent path (because it just becomes an empty string, I guess). Could still be related though? ¯\\\_(ツ)\_/¯
claunia commented 2026-01-31 03:26:11 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 3, 2021):

Yea, after re-reading #9338, they do definitely seem different. The warning dialog in that one's really throwing me for a loop. I mean, this one's crazy too. They're both crazy, just, each their own unique kind of crazy 😄

@zadjii-msft commented on GitHub (Mar 3, 2021): Yea, after re-reading #9338, they do definitely seem different. The warning dialog in that one's really throwing me for a loop. I mean, this one's crazy too. They're both crazy, just, each their own unique kind of crazy 😄
claunia commented 2026-01-31 03:26:11 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Mar 3, 2021):

@PankajBhojwani Check this out!

TerminalSettings.h:117

        GETSET_PROPERTY(hstring, PixelShaderPath);

But look at all the other settings ...

        GETSET_SETTING(TerminalApp::TerminalSettings, bool, RetroTerminalEffect, false);
        GETSET_SETTING(TerminalApp::TerminalSettings, bool, ForceFullRepaintRendering, false);
        GETSET_SETTING(TerminalApp::TerminalSettings, bool, SoftwareRendering, false);
        GETSET_SETTING(TerminalApp::TerminalSettings, bool, ForceVTInput, false);

When we create a new TerminalSettings leaf object, it has no PixelShaderPath because it is not an inheritable setting.

The danger of macros with a bunch of identical names.

@DHowett commented on GitHub (Mar 3, 2021): @PankajBhojwani Check this out! TerminalSettings.h:117 ``` GETSET_PROPERTY(hstring, PixelShaderPath); ``` But look at all the other settings ... ``` GETSET_SETTING(TerminalApp::TerminalSettings, bool, RetroTerminalEffect, false); GETSET_SETTING(TerminalApp::TerminalSettings, bool, ForceFullRepaintRendering, false); GETSET_SETTING(TerminalApp::TerminalSettings, bool, SoftwareRendering, false); GETSET_SETTING(TerminalApp::TerminalSettings, bool, ForceVTInput, false); ``` When we create a new TerminalSettings leaf object, it has no PixelShaderPath because _it is not an inheritable setting_. The danger of macros with a bunch of identical names.
claunia commented 2026-01-31 03:26:11 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 3, 2021):

Maybe we should GET rid of the GETSET_ prefix, because that's not really relevant anymore. Or maybe just change GETSET_SETTING to SETTING. That would be at least visually distinct and mentally distinct from GETSET_PROPERTY

@zadjii-msft commented on GitHub (Mar 3, 2021): Maybe we should `GET` rid of the `GETSET_` prefix, because that's not really relevant anymore. Or maybe just change `GETSET_SETTING` to `SETTING`. That would be at least visually distinct and mentally distinct from `GETSET_PROPERTY`
claunia commented 2026-01-31 03:26:12 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 14, 2021):

:tada:This issue was addressed in #9371, which has now been successfully released as Windows Terminal v1.7.1033.0.🎉

Handy links:

@ghost commented on GitHub (Apr 14, 2021): :tada:This issue was addressed in #9371, which has now been successfully released as `Windows Terminal v1.7.1033.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.7.1033.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 03:26:12 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 14, 2021):

:tada:This issue was addressed in #9371, which has now been successfully released as Windows Terminal Preview v1.8.1032.0.🎉

Handy links:

@ghost commented on GitHub (Apr 14, 2021): :tada:This issue was addressed in #9371, which has now been successfully released as `Windows Terminal Preview v1.8.1032.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.8.1032.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Area-Settings Issue-Bug Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12833
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?