[PR #12833] [MERGED] Replace RadioButton expanders with ComboBoxes #29254

Open
opened 2026-01-31 09:33:46 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12833
Author: @zadjii-msft
Created: 4/5/2022
Status: Merged
Merged: 4/6/2022
Merged by: @undefined

Base: mainHead: dev/migrie/b/12648-radio-to-combobox


📝 Commits (6)

  • 745c77d Simple proof of concept
  • 2d0684e Merge remote-tracking branch 'origin/main' into dev/migrie/b/12648-radio-to-combobox
  • b87e379 I think this is all of them
  • 9906090 if you omit this, then the text flies off into space, cause of course it does
  • 8a1bfa7 this template isn't needed anymore
  • 490b8f1 PR feedback

📊 Changes

6 files changed (+90 additions, -95 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/Appearances.xaml (+19 -24)
📝 src/cascadia/TerminalSettingsEditor/GlobalAppearance.xaml (+14 -14)
📝 src/cascadia/TerminalSettingsEditor/Interaction.xaml (+14 -14)
📝 src/cascadia/TerminalSettingsEditor/Launch.xaml (+21 -21)
📝 src/cascadia/TerminalSettingsEditor/Profiles_Advanced.xaml (+14 -14)
📝 src/cascadia/TerminalSettingsEditor/Profiles_Appearance.xaml (+8 -8)

📄 Description

Replaces all the RadioButton expanders with ComboBoxes, which can have the options inline, as opposed to in the expander content. For example, here's a single commit with the changes for a single one of these settings: 745c77d03e

Checklist

Before, after:

image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12833 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 4/5/2022 **Status:** ✅ Merged **Merged:** 4/6/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/12648-radio-to-combobox` --- ### 📝 Commits (6) - [`745c77d`](https://github.com/microsoft/terminal/commit/745c77d03e402a35901bfc5516486e315b0f673f) Simple proof of concept - [`2d0684e`](https://github.com/microsoft/terminal/commit/2d0684e6f7494a9e061a1ff64e64c4a9d5a9b246) Merge remote-tracking branch 'origin/main' into dev/migrie/b/12648-radio-to-combobox - [`b87e379`](https://github.com/microsoft/terminal/commit/b87e3796e68b14af2820653cbfb7ff84f1c44f3b) I think this is all of them - [`9906090`](https://github.com/microsoft/terminal/commit/9906090d6fd21a1374f60e418434825302813a4b) if you omit this, then the text flies off into space, cause of course it does - [`8a1bfa7`](https://github.com/microsoft/terminal/commit/8a1bfa7b4bc043d307a760407d18742c3255f0ae) this template isn't needed anymore - [`490b8f1`](https://github.com/microsoft/terminal/commit/490b8f1814279fe326446b95856553607f7c1c67) PR feedback ### 📊 Changes **6 files changed** (+90 additions, -95 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/Appearances.xaml` (+19 -24) 📝 `src/cascadia/TerminalSettingsEditor/GlobalAppearance.xaml` (+14 -14) 📝 `src/cascadia/TerminalSettingsEditor/Interaction.xaml` (+14 -14) 📝 `src/cascadia/TerminalSettingsEditor/Launch.xaml` (+21 -21) 📝 `src/cascadia/TerminalSettingsEditor/Profiles_Advanced.xaml` (+14 -14) 📝 `src/cascadia/TerminalSettingsEditor/Profiles_Appearance.xaml` (+8 -8) </details> ### 📄 Description Replaces all the `RadioButton` expanders with `ComboBox`es, which can have the options inline, as opposed to in the expander content. For example, here's a single commit with the changes for a single one of these settings: https://github.com/microsoft/terminal/commit/745c77d03e402a35901bfc5516486e315b0f673f ### Checklist * [x] Closes #12648 * [x] Actually closes #9566 as well (by just removing all radio buttons) * [x] I work here * [x] Tested manually * [x] I'd love @carlos-zamora to have an a11y pass at this, just to see if it's egregious or not. ### Before, after: ![image](https://user-images.githubusercontent.com/18356694/161822068-939ff875-00ff-454a-8b58-cb843ba801f4.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:33:46 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29254