starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

sendInput should be previewable #17188

New Issue
Closed
opened 2026-01-31 05:34:47 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 05:34:47 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Apr 8, 2022).

Originally assigned to: @zadjii-msft on GitHub.

See #9818, 60f63b09cc, #3121. I literally have this prototyped, just need to check it in. It's important for future issues...

Originally created by @zadjii-msft on GitHub (Apr 8, 2022). Originally assigned to: @zadjii-msft on GitHub. See #9818, 60f63b09cc59f1a46d142952f49dbf7599bc4cf8, #3121. I literally have this prototyped, just need to check it in. It's important for future issues...
claunia commented 2026-01-31 05:34:49 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 29, 2022):

More cleanly pulled to its own branch: https://github.com/microsoft/terminal/pull/new/dev/migrie/f/12861-preview-input

Note: You'll also want the backspace trimming thing. That merged into TSFControl in 0f32692 but I don't know where its origin was before that.


    void TSFInputControl::ManuallyDisplayText(const winrt::hstring& text)
    {
        _focused = !text.empty();
        Canvas().Visibility(text.empty() ? Visibility::Collapsed : Visibility::Visible);

        _inputBuffer.clear();
        // _editContext.NotifyFocusLeave();
        _activeTextStart = 0;
        _inComposition = false;

        // HACK trim off leading DEL chars.
        std::wstring_view view{ text.c_str() };
        const auto strBegin = view.find_first_not_of(L"\x7f");
        if (strBegin != std::wstring::npos)
        {
            view = view.substr(strBegin * 2);
        }

        TextBlock().Text(winrt::hstring{ view });
        TextBlock().UpdateLayout();
        TryRedrawCanvas();
    }
@zadjii-msft commented on GitHub (Apr 29, 2022): More cleanly pulled to its own branch: https://github.com/microsoft/terminal/pull/new/dev/migrie/f/12861-preview-input Note: You'll also want the backspace trimming thing. That merged into TSFControl in 0f32692 but I don't know where its origin was before that. ```c++ void TSFInputControl::ManuallyDisplayText(const winrt::hstring& text) { _focused = !text.empty(); Canvas().Visibility(text.empty() ? Visibility::Collapsed : Visibility::Visible); _inputBuffer.clear(); // _editContext.NotifyFocusLeave(); _activeTextStart = 0; _inComposition = false; // HACK trim off leading DEL chars. std::wstring_view view{ text.c_str() }; const auto strBegin = view.find_first_not_of(L"\x7f"); if (strBegin != std::wstring::npos) { view = view.substr(strBegin * 2); } TextBlock().Text(winrt::hstring{ view }); TextBlock().UpdateLayout(); TryRedrawCanvas(); } ```
claunia commented 2026-01-31 05:34:49 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 29, 2022):

Curious how this will handle sendInputd escape sequences!

@DHowett commented on GitHub (Jun 29, 2022): Curious how this will handle `sendInput`d escape sequences!
claunia commented 2026-01-31 05:34:49 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 8, 2023):

Protip, revert 7c3fd2aeec

I backed it out because it:

  • worked wacky with wide glyphs / unicode surrogates and the backspacing code
  • the backspacing code was hacky kinda always
  • it didn't always scale and offset to the correct position
  • didn't really handle line wrapping well
  • with the pwsh ghost text, was very confusing

you may also need 8f0b6f8a2

@zadjii-msft commented on GitHub (Aug 8, 2023): Protip, revert 7c3fd2aeecf57d0320ff915d7c8c68e10acb1763 I backed it out because it: * worked wacky with wide glyphs / unicode surrogates and the backspacing code * the backspacing code was hacky kinda always * it didn't always scale and offset to the correct position * didn't really handle line wrapping well * with the pwsh ghost text, was very confusing --- you may also need 8f0b6f8a2
claunia commented 2026-01-31 05:34:49 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 17, 2023):

Punting out of 1.19. This was wacky as-is. We may want to come back to re-try this with more runway.

@zadjii-msft commented on GitHub (Aug 17, 2023): Punting out of 1.19. This was wacky as-is. We may want to come back to re-try this with more runway.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CmdPal Area-Settings Help Wanted In-PR Issue-Task Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17188
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?