starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Iconify window op causes conhost to hang #17717

New Issue
Closed
opened 2026-01-31 05:51:19 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 05:51:19 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Jun 14, 2022).

Windows Terminal version

Commit 9eb191d545

Windows build number

10.0.19044.1706

Other Software

No response

Steps to reproduce

  1. Build a recent version of OpenConsole.
  2. Open a bash shell.
  3. Execute printf "\e[2t"

Expected Behavior

The console window should be minimized.

Actual Behavior

The window is briefly minimized and then restored again, but at that point it's no longer responding. Can't move it. Can't close it. Have to go to taskman to kill it.

When run from within the debugger, it appears to be blocking inside the ShowWindow call, somewhere in "External Code".

Originally created by @j4james on GitHub (Jun 14, 2022). ### Windows Terminal version Commit 9eb191d5453fed890bad63952e425e1240aa8df5 ### Windows build number 10.0.19044.1706 ### Other Software _No response_ ### Steps to reproduce 1. Build a recent version of OpenConsole. 2. Open a bash shell. 3. Execute `printf "\e[2t"` ### Expected Behavior The console window should be minimized. ### Actual Behavior The window is briefly minimized and then restored again, but at that point it's no longer responding. Can't move it. Can't close it. Have to go to taskman to kill it. When run from within the debugger, it appears to be blocking inside the [`ShowWindow`](https://github.com/microsoft/terminal/blob/799b5d4add799ac2fbf5c855b774cd7dcb957697/src/host/outputStream.cpp#L289) call, somewhere in "External Code".
claunia commented 2026-01-31 05:51:20 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jun 14, 2022):

It looks like the "de-iconify" op is similarly affected. If you do something like this:

sleep 5; printf "\e[1t"

then immediately minimize the window, it won't be restored after 5 seconds. At that point it'll be frozen and will have to be manually killed.

@j4james commented on GitHub (Jun 14, 2022): It looks like the "de-iconify" op is similarly affected. If you do something like this: sleep 5; printf "\e[1t" then immediately minimize the window, it won't be restored after 5 seconds. At that point it'll be frozen and will have to be manually killed.
claunia commented 2026-01-31 05:51:20 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 15, 2022):

what the

If you break in ConhostInternalGetSet::ShowWindow, then add a breakpoint at the top of Window::ConsoleWindowProc, the second breakpoint isn't ever hit... That can't be right. I'd think user32 would send the console window a message, but we don't even get that?

@zadjii-msft commented on GitHub (Jun 15, 2022): what the If you break in `ConhostInternalGetSet::ShowWindow`, then add a breakpoint at the top of `Window::ConsoleWindowProc`, the second breakpoint isn't ever hit... That can't be right. I'd think user32 would send the console window a message, but we don't even get that?
claunia commented 2026-01-31 05:51:21 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 15, 2022):

Oh ho ho, that's it boys.

        [External Code]	
 	OpenConsole.exe!til::atomic_wait<unsigned int>(const std::atomic<unsigned int> & atomic, const unsigned int & current, unsigned long waitMilliseconds) Line 14	C++
 	OpenConsole.exe!til::ticket_lock::lock() Line 35	C++
 	OpenConsole.exe!CONSOLE_INFORMATION::LockConsole() Line 77	C++
 	OpenConsole.exe!LockConsole() Line 17	C++
>	OpenConsole.exe!Microsoft::Console::Interactivity::Win32::Window::ConsoleWindowProc(HWND__ * hWnd, unsigned int Message, unsigned __int64 wParam, __int64 lParam) Line 74	C++
 	OpenConsole.exe!Microsoft::Console::Interactivity::Win32::Window::s_ConsoleWindowProc(HWND__ * hWnd, unsigned int Message, unsigned __int64 wParam, __int64 lParam) Line 58	C++
 	[External Code]	
 	OpenConsole.exe!ConsoleInputThreadProcWin32(void * __formal) Line 1066	C++
 	[External Code]

OpenConsole.exe!ApiRoutines::WriteConsoleAImpl already took the lock on the driver message thread. Then the UI thread tries to re-lock, but it can't do that

@zadjii-msft commented on GitHub (Jun 15, 2022): Oh ho ho, that's it boys. ``` [External Code] OpenConsole.exe!til::atomic_wait<unsigned int>(const std::atomic<unsigned int> & atomic, const unsigned int & current, unsigned long waitMilliseconds) Line 14 C++ OpenConsole.exe!til::ticket_lock::lock() Line 35 C++ OpenConsole.exe!CONSOLE_INFORMATION::LockConsole() Line 77 C++ OpenConsole.exe!LockConsole() Line 17 C++ > OpenConsole.exe!Microsoft::Console::Interactivity::Win32::Window::ConsoleWindowProc(HWND__ * hWnd, unsigned int Message, unsigned __int64 wParam, __int64 lParam) Line 74 C++ OpenConsole.exe!Microsoft::Console::Interactivity::Win32::Window::s_ConsoleWindowProc(HWND__ * hWnd, unsigned int Message, unsigned __int64 wParam, __int64 lParam) Line 58 C++ [External Code] OpenConsole.exe!ConsoleInputThreadProcWin32(void * __formal) Line 1066 C++ [External Code] ``` `OpenConsole.exe!ApiRoutines::WriteConsoleAImpl` already took the lock on the driver message thread. Then the UI thread tries to re-lock, but it can't do that
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Windowing Issue-Bug Needs-Triage Priority-0 Product-Conhost Resolution-Fix-Committed Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17717
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?