No GitHub/Feedback link in About box. #17789

Closed
opened 2026-01-31 05:53:31 +00:00 by claunia · 6 comments
Owner

Originally created by @michael-hawker on GitHub (Jun 24, 2022).

Description of the new feature/enhancement

The current about dialog is pretty simple:

image

It'd be nice to see:

  • Terminal Icon
  • A link to GitHub (maybe w/ GitHub Icon)
  • A 'Send Feedback' link which leads here or Feedback Hub:
    image
Originally created by @michael-hawker on GitHub (Jun 24, 2022). # Description of the new feature/enhancement The current about dialog is pretty simple: ![image](https://user-images.githubusercontent.com/24302614/175428885-762497a4-4711-4085-b6bf-08b27f856c82.png) It'd be nice to see: - Terminal Icon - A link to GitHub (maybe w/ GitHub Icon) - A 'Send Feedback' link which leads here or Feedback Hub: ![image](https://user-images.githubusercontent.com/24302614/175429094-41542cd5-aadf-4d76-9716-433c4cb209ee.png)
Author
Owner

@zadjii-msft commented on GitHub (Jul 5, 2022):

FWIW We used to have this in the top level dropdown, but it was just generating noise.

In #789 we made it point at our GitHub issues, but at some point after that we redirected that to the FeedbackUriValue resource, which redirects to feedback hub now.

We've discussed offline the idea of putting this back somewhere, once again pointing at GitHub, and again with the in-app-feedback label (or something like that). Of course, we can just change the fwlink on our side to point at whatever, so just adding a link back should be easy enough.

@zadjii-msft commented on GitHub (Jul 5, 2022): FWIW We used to have this in the top level dropdown, but it was just generating noise. In #789 we made it point at our GitHub issues, but at some point after that we redirected that to the `FeedbackUriValue` resource, which redirects to feedback hub now. We've discussed offline the idea of putting this back _somewhere_, once again pointing at GitHub, and again with the `in-app-feedback` label (or something like that). Of course, we can just change the `fwlink` on our side to point at whatever, so just adding a link back should be easy enough.
Author
Owner

@AdamSotak commented on GitHub (Jul 14, 2022):

Hello, I would like to work on this.

I have already implemented these buttons:

WindowsTerminalAboutDialog

The buttons link directly to:

I would appreciate your feedback.

@AdamSotak commented on GitHub (Jul 14, 2022): Hello, I would like to work on this. I have already implemented these buttons: ![WindowsTerminalAboutDialog](https://user-images.githubusercontent.com/92621643/179002517-a3f4bf3a-dde8-45ad-b066-80875fa75d43.png) The buttons link directly to: - Source Code -> https://github.com/microsoft/terminal - Send Feedback -> https://github.com/microsoft/terminal/issues **(Change to Feedback Hub?)** I would appreciate your feedback.
Author
Owner

@zadjii-msft commented on GitHub (Jul 14, 2022):

I think that would be perfect! Honestly, GitHub is a way better place for feedback than Feedback Hub 😄

@zadjii-msft commented on GitHub (Jul 14, 2022): I think that would be perfect! Honestly, GitHub is a way better place for feedback than Feedback Hub 😄
Author
Owner

@DHowett commented on GitHub (Jul 14, 2022):

This might be one of those things where the stable version should direct users to the feedback hub, and the preview/dev versions should direct users to GitHub . . . @zadjii-msft, WDYT?

Motivation: I don't know if, when we become "DxD", we can rely on the large population of Stable users to have GitHub accounts.

@DHowett commented on GitHub (Jul 14, 2022): This might be one of those things where the stable version should direct users to the feedback hub, and the preview/dev versions should direct users to GitHub . . . @zadjii-msft, WDYT? Motivation: I don't know if, when we become "DxD", we can rely on the large population of Stable users to _have GitHub accounts._
Author
Owner

@zadjii-msft commented on GitHub (Jul 14, 2022):

That's a good idea, but let's start small. Let's just start with the links as @AdamSotak has it now for now, and we can sort out the fwlinks on our side in post.

@zadjii-msft commented on GitHub (Jul 14, 2022): That's a good idea, but let's start small. Let's just start with the links as @AdamSotak has it now for now, and we can sort out the fwlinks on our side in post.
Author
Owner

@ghost commented on GitHub (Sep 13, 2022):

:tada:This issue was addressed in #13510, which has now been successfully released as Windows Terminal Preview v1.16.252.🎉

Handy links:

@ghost commented on GitHub (Sep 13, 2022): :tada:This issue was addressed in #13510, which has now been successfully released as `Windows Terminal Preview v1.16.252`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.16.252) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17789