starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Readme doesn't match VS 2019 Preview Installer #789

New Issue
Closed
opened 2026-01-30 22:04:11 +00:00 by claunia · 7 comments
claunia commented 2026-01-30 22:04:11 +00:00
Owner
Copy Link

Originally created by @jongio on GitHub (May 7, 2019).

  • Your Windows build number: (Type ver at a Windows Command Prompt)

1903

  • What you're doing and what's happening: (Copy & paste specific commands and their output, or include screen shots)

Readme has this:

If you're running VS2019, you'll also need to install the "v141 Toolset" and "Visual C++ ATL for x86 and x64"

VS Preview install tool has this:
image

image

  • What's wrong / what should be happening instead:

Since the names don't exactly match it is unclear if I'm selecting the right options.

Originally created by @jongio on GitHub (May 7, 2019). * Your Windows build number: (Type `ver` at a Windows Command Prompt) 1903 * What you're doing and what's happening: (Copy & paste specific commands and their output, or include screen shots) Readme has this: > If you're running VS2019, you'll also need to install the "v141 Toolset" and "Visual C++ ATL for x86 and x64" VS Preview install tool has this: ![image](https://user-images.githubusercontent.com/2163001/57330436-e0e01f80-70ca-11e9-9423-2800ca640859.png) ![image](https://user-images.githubusercontent.com/2163001/57330448-ea698780-70ca-11e9-8ae8-c14fffc6f1f4.png) * What's wrong / what should be happening instead: Since the names don't exactly match it is unclear if I'm selecting the right options.
claunia added the Area-Build label 2026-01-30 22:04:11 +00:00
claunia commented 2026-01-30 22:04:12 +00:00
Author
Owner
Copy Link

@Pitta commented on GitHub (May 8, 2019):

feels like im getting caught up here as well since my local builds are failing.

@Pitta commented on GitHub (May 8, 2019): feels like im getting caught up here as well since my local builds are failing.
claunia commented 2026-01-30 22:04:12 +00:00
Author
Owner
Copy Link

@chunliu commented on GitHub (May 8, 2019):

you need to go to Individual components tab rather than Workloads tab to install it.

@chunliu commented on GitHub (May 8, 2019): you need to go to **Individual components** tab rather than **Workloads** tab to install it.
claunia commented 2026-01-30 22:04:12 +00:00
Author
Owner
Copy Link

@jongio commented on GitHub (May 8, 2019):

Yeah but the names still don’t match. Can you confirm what the exact names are and match then letter for letter?

From: Chun Liu notifications@github.com
Sent: Tuesday, May 7, 2019 10:53:39 PM
To: microsoft/Terminal
Cc: Jon Gallant; Author
Subject: Re: [microsoft/Terminal] Readme doesn't match VS 2019 Preview Installer (#534)

you need to go to Individual components tab rather than Workloads tab to install it.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTerminal%2Fissues%2F534%23issuecomment-490327195&data=01%7C01%7CJon.Gallant%40microsoft.com%7Cab9ab03824094c25f38708d6d3606094%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=j7Uy%2FQRvUVN%2B5RLggrdsC3z%2FXWuXBqbiCXNdjl1dF4Q%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAQQCOPIUG22ULN2XNHWT2DPUI6DHANCNFSM4HLMGBPQ&data=01%7C01%7CJon.Gallant%40microsoft.com%7Cab9ab03824094c25f38708d6d3606094%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=CxhIg1IZ2lYez%2BL2mwzMcbDfp04Cv5xrUgelA8Swt6k%3D&reserved=0.

@jongio commented on GitHub (May 8, 2019): Yeah but the names still don’t match. Can you confirm what the exact names are and match then letter for letter? ________________________________ From: Chun Liu <notifications@github.com> Sent: Tuesday, May 7, 2019 10:53:39 PM To: microsoft/Terminal Cc: Jon Gallant; Author Subject: Re: [microsoft/Terminal] Readme doesn't match VS 2019 Preview Installer (#534) you need to go to Individual components tab rather than Workloads tab to install it. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTerminal%2Fissues%2F534%23issuecomment-490327195&data=01%7C01%7CJon.Gallant%40microsoft.com%7Cab9ab03824094c25f38708d6d3606094%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=j7Uy%2FQRvUVN%2B5RLggrdsC3z%2FXWuXBqbiCXNdjl1dF4Q%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAQQCOPIUG22ULN2XNHWT2DPUI6DHANCNFSM4HLMGBPQ&data=01%7C01%7CJon.Gallant%40microsoft.com%7Cab9ab03824094c25f38708d6d3606094%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=CxhIg1IZ2lYez%2BL2mwzMcbDfp04Cv5xrUgelA8Swt6k%3D&reserved=0>.
claunia commented 2026-01-30 22:04:12 +00:00
Author
Owner
Copy Link

@chunliu commented on GitHub (May 8, 2019):

It is "C++ ATL for v141 build tools", not "Visual C++". But it is not necessary to install v141 toolset in VS2019.

@chunliu commented on GitHub (May 8, 2019): It is "C++ ATL for v141 build tools", not "Visual C++". But it is not necessary to install v141 toolset in VS2019.
claunia commented 2026-01-30 22:04:12 +00:00
Author
Owner
Copy Link

@timheuer commented on GitHub (May 8, 2019):

I added more explicitness for VS2019 in this PR: https://github.com/microsoft/Terminal/pull/560

Additionally here is what my ultimate config options were to my VS2019 installer I needed:
VC++ Added components under the "Desktop Development for C++"
image

Additional under "Individual Components"
image

Under "Universal Windows Platform Development" despite having UWP selected as a workload for me these were not installed and I had to ensure they were to load the TerminalApp/Settings projects:
image

@timheuer commented on GitHub (May 8, 2019): I added more explicitness for VS2019 in this PR: https://github.com/microsoft/Terminal/pull/560 Additionally here is what my ultimate config options were to my VS2019 installer I needed: VC++ Added components under the "Desktop Development for C++" ![image](https://user-images.githubusercontent.com/4821/57350003-24f61300-7111-11e9-9232-455f93835d99.png) Additional under "Individual Components" ![image](https://user-images.githubusercontent.com/4821/57350027-5242c100-7111-11e9-8ba9-348c3ae4b0ec.png) Under "Universal Windows Platform Development" despite having UWP selected as a workload for me these were not installed and I had to ensure they were to load the TerminalApp/Settings projects: ![image](https://user-images.githubusercontent.com/4821/57350062-74d4da00-7111-11e9-84a1-371b74f2a94c.png)
claunia commented 2026-01-30 22:04:13 +00:00
Author
Owner
Copy Link

@inoperable commented on GitHub (May 8, 2019):

And make sure that you got enough space because the I runned out of space (just for x86...) after 40gb random dependencies and 15gb+ bin obj's data...

@inoperable commented on GitHub (May 8, 2019): And make sure that you got enough space because the I runned out of space (just for x86...) after 40gb random dependencies and 15gb+ bin obj's data...
claunia commented 2026-01-30 22:04:13 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (May 14, 2019):

OK, I'm going to resolve this for now because we just merged #560 with more explicit instructions and names of the dependencies in the installer.

@miniksa commented on GitHub (May 14, 2019): OK, I'm going to resolve this for now because we just merged #560 with more explicit instructions and names of the dependencies in the installer.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Build
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#789
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?