starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Mark mode hyperlink navigation sometimes skips over entries #18313

New Issue
Open
opened 2026-01-31 06:10:08 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 06:10:08 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Aug 26, 2022).

Originally assigned to: @carlos-zamora on GitHub.

Here's a bunch of bugs we found during our bug bash that are related to tab to hyperlink and mark mode

  • If Shift+tab causes scroll and new selection is on multiple lines, we scroll to show the "end" (should show the whole thing)
  • Shift+tab skips over hyperlink that is (end) partially included in top row of view
  • If a selection exists, mark mode should happen on the existing selection (#13893)
  • Ctrl+enter on random selection clears selection. Maybe it should try to treat selection as a URL?
  • Mark mode --> move to middle of word --> ExpandSelectionToWord --> Shift+Right/Left --> weird updated selection (#13893 )
  • https://github.com/microsoft/terminal/pull/13494#issuecomment-1234559792
  • remove _selectionIsTargetingUrl, instead check if new selection matches old selection. If so, skip it.
Originally created by @carlos-zamora on GitHub (Aug 26, 2022). Originally assigned to: @carlos-zamora on GitHub. Here's a bunch of bugs we found during our bug bash that are related to tab to hyperlink and mark mode - [ ] If Shift+tab causes scroll and new selection is on multiple lines, we scroll to show the "end" (should show the whole thing) - [ ] Shift+tab skips over hyperlink that is (end) partially included in top row of view - [x] If a selection exists, mark mode should happen on the existing selection (#13893) - [x] Ctrl+enter on random selection clears selection. Maybe it should try to treat selection as a URL? - [x] Mark mode --> move to middle of word --> ExpandSelectionToWord --> Shift+Right/Left --> weird updated selection (#13893 ) - [ ] https://github.com/microsoft/terminal/pull/13494#issuecomment-1234559792 - [ ] remove `_selectionIsTargetingUrl`, instead check if new selection matches old selection. If so, skip it.
claunia added the Help WantedIssue-BugArea-InteractionProduct-Terminal labels 2026-01-31 06:10:08 +00:00
claunia commented 2026-01-31 06:10:09 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Sep 1, 2022):

Shift+tab skips over hyperlink that is (end) partially included in top row of view

Urgh. This is a problem with how we're using the pattern interval tree. Consider the following:

www.github.com/microsoft/term
------------------------------------- View Boundary (Top)
inal/issues/13854

The pattern interval tree doesn't detect the partial match. This issue can be replicated by ctrl+clicking.

@carlos-zamora commented on GitHub (Sep 1, 2022): > Shift+tab skips over hyperlink that is (end) partially included in top row of view Urgh. This is a problem with how we're using the pattern interval tree. Consider the following: ``` www.github.com/microsoft/term ------------------------------------- View Boundary (Top) inal/issues/13854 ``` The pattern interval tree doesn't detect the partial match. This issue can be replicated by ctrl+clicking.
claunia commented 2026-01-31 06:10:09 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 1, 2022):

Oh huh, I wonder if the selection changes referenced here also caused #14464 and #14462 🤔

@zadjii-msft commented on GitHub (Dec 1, 2022): Oh huh, I wonder if the selection changes referenced here also caused #14464 and #14462 🤔
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Interaction Help Wanted Issue-Bug Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18313
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?