starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Deleting the reference to a profile from a JSON fragment file prevents the profile from showing back up again even when the profile still exists in the fragment file. #18370

New Issue
Open
opened 2026-01-31 06:11:47 +00:00 by claunia · 8 comments
claunia commented 2026-01-31 06:11:47 +00:00
Owner
Copy Link

Originally created by @danmock on GitHub (Sep 2, 2022).

Windows Terminal version

1.14.2282.0

Windows build number

10.0.22000.0

Other Software

No response

Steps to reproduce

  1. Create a fragment file with a profile in it.
    • Absolute path: $Env:LocalAppData\Microsoft\Windows Terminal\Fragments\TestFragmentDir\testFragment.json
  2. Launch Windows Terminal.
  3. The profile from the fragment file appears in the profile drop down.
  4. Close Windows Terminal.
  5. Remove the reference to the testFragment.json profile from the settings.json file.
  6. Launch Windows Terminal.
  7. The profile from the fragment file does not appear in the profile drop down.
  8. The fragment file with the profile in it still exists, along with the profile.

Expected Behavior

Either:

  • Remove the profile from the fragment file testFragment.json in addition to the reference to said profile from the settings.json file.

or

  • Upon reopening Windows Terminal after removing the reference to the testFragment.json profile from the settings.json file, the reference should reappear (as the fragment file containing the profile still exists).

Actual Behavior

As listed in Steps to reproduce.

Scenario where this is an issue:

  • My team provides users a set of fragment files containing profiles (with very specific GUIDs).
    • The fragment files are automatically generated as part of a script which users execute.
    • These profiles define the CLIs which users must interact with for interfacing with a set of repositories.
  • User U tinkers with their settings.json file, removing several profiles, including references to the profiles from the fragment files that we provided them.
  • U no longer sees the profiles associated with the fragment files we gave them, even though the fragment files still exist and have not been modified.
  • U alerts our team that they see the profiles in the fragment files, yet Windows Terminal won't show them.
  • U informs that they are unable to access the CLIs associated with their work (as defined by the profiles in the fragment files).
  • U deletes their repository, re-clones it, then generates the fragment files again, in an attempt to get Windows Terminal to show the CLIs for the repository.
  • U smashes their keyboard into their monitor when nothing is working, and promptly leans back in their chair and contemplates their life choices.
Originally created by @danmock on GitHub (Sep 2, 2022). ### Windows Terminal version 1.14.2282.0 ### Windows build number 10.0.22000.0 ### Other Software _No response_ ### Steps to reproduce 1. Create a fragment file with a profile in it. - Absolute path: `$Env:LocalAppData\Microsoft\Windows Terminal\Fragments\TestFragmentDir\testFragment.json` 3. Launch Windows Terminal. 4. The profile from the fragment file appears in the profile drop down. 5. Close Windows Terminal. 6. Remove the reference to the `testFragment.json` profile from the `settings.json` file. 7. Launch Windows Terminal. 8. The profile from the fragment file does not appear in the profile drop down. 9. The fragment file with the profile in it still exists, along with the profile. ### Expected Behavior Either: - Remove the profile from the fragment file `testFragment.json` in addition to the reference to said profile from the `settings.json` file. or - Upon reopening Windows Terminal after removing the reference to the `testFragment.json` profile from the `settings.json` file, the reference should reappear (as the fragment file containing the profile still exists). ### Actual Behavior As listed in **_Steps to reproduce_**. <hr> Scenario where this is an issue: - My team provides users a set of fragment files containing profiles (with very specific GUIDs). - The fragment files are automatically generated as part of a script which users execute. - These profiles define the CLIs which users must interact with for interfacing with a set of repositories. - User **_U_** tinkers with their `settings.json` file, removing several profiles, including references to the profiles from the fragment files that we provided them. - **_U_** no longer sees the profiles associated with the fragment files we gave them, even though the fragment files still exist and have not been modified. - **_U_** alerts our team that they see the profiles in the fragment files, yet Windows Terminal won't show them. - **_U_** informs that they are unable to access the CLIs associated with their work (as defined by the profiles in the fragment files). - **_U_** deletes their repository, re-clones it, then generates the fragment files again, in an attempt to get Windows Terminal to show the CLIs for the repository. - **_U_** smashes their keyboard into their monitor when nothing is working, and promptly leans back in their chair and contemplates their life choices.
claunia added the Area-SettingsIssue-BugProduct-Terminal labels 2026-01-31 06:11:47 +00:00
claunia commented 2026-01-31 06:11:48 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Sep 3, 2022):

Thanks for filing this, @danmock. There's definitely a few things we could do to make this experience better.

Off the top of my head:

  • #10436 tracks adding a page where users can discover "extensions" (today that's only fragments, but it could also include future plugins ala #4000) and see what profiles/settings/color schemes they contributed. That would probably be a good place to nestle this "recover a deleted profile" feature.
  • #9997 tracks a number of other things we'd like to do to make the dynamic (that is, discovered at runtime) profile experience a bit easier and may be worth a read
  • Today, users can recover any lost profiles in the poorly-named "Duplicate" section of the "Add new profile" page

As a stop-gap, do any of those things help?

We'll make sure to discuss this at a team meeting.

@DHowett commented on GitHub (Sep 3, 2022): Thanks for filing this, @danmock. There's definitely a few things we could do to make this experience better. Off the top of my head: - #10436 tracks adding a page where users can discover "extensions" (today that's only fragments, but it could also include future plugins ala #4000) and see what profiles/settings/color schemes they contributed. That would probably be a good place to nestle this "recover a deleted profile" feature. - #9997 tracks a number of other things we'd like to do to make the dynamic (that is, discovered at runtime) profile experience a bit easier and may be worth a read - Today, users can recover any lost profiles in the poorly-named "Duplicate" section of the "Add new profile" page As a stop-gap, do any of those things help? We'll make sure to discuss this at a team meeting.
claunia commented 2026-01-31 06:11:48 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Sep 3, 2022):

I was about to write a response as well. To just state some things that @DHowett left unsaid: The specific PR which changed this is #11007. This change was quite important to make profile deletions less confusing. For instance Visual Studio 17.3 now ships with the "VSDebugConsole" fragment. Without this change it would be impossible to properly get rid of that profile for anyone who has Visual Studio installed. But if you do need it back it still shows up ready to be cloned at any time:

image

IMO, if anything, we should improve our UX in regards to profile creation to make the discovery of previously deleted profiles more obvious to users.

@lhecker commented on GitHub (Sep 3, 2022): I was about to write a response as well. To just state some things that @DHowett left unsaid: The specific PR which changed this is #11007. This change was quite important to make profile deletions less confusing. For instance Visual Studio 17.3 now ships with the "VSDebugConsole" fragment. Without this change it would be impossible to properly get rid of that profile for anyone who has Visual Studio installed. But if you do need it back it still shows up ready to be cloned at any time: ![image](https://user-images.githubusercontent.com/2256941/188245953-2d96914d-2c69-4fc3-a152-2e0c6333e0e3.png) IMO, if anything, we should improve our UX in regards to profile creation to make the discovery of previously deleted profiles more obvious to users.
claunia commented 2026-01-31 06:11:48 +00:00
Author
Owner
Copy Link

@danmock commented on GitHub (Sep 3, 2022):

Are the deleted profiles from the Duplicate a profile dropdown cached copies of the profiles as they existed when they were deleted?

@danmock commented on GitHub (Sep 3, 2022): Are the deleted profiles from the `Duplicate a profile` dropdown cached copies of the profiles as they existed when they were deleted?
claunia commented 2026-01-31 06:11:48 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Sep 3, 2022):

This is where it gets weird, and why I'm not comfortable closing this out as "solved" or anything.

The profiles in that list are the actual "deleted" ones. There's a few boring and indepth reasons for that... but suffice it to say we still deserialize all of the fragments and dynamic profiles and everything before we choose which ones to show.

When you create one using Duplicate, though, you get a new profile, with a new GUID that is a deep copy of the original fragment. It's not connected to it any more. It's a weird ethereal plane version of the original fragment. ☹️

@DHowett commented on GitHub (Sep 3, 2022): This is where it gets weird, and why I'm not comfortable closing this out as "solved" or anything. The profiles in that list are the actual "deleted" ones. There's a few boring and indepth reasons for that... but suffice it to say we still deserialize all of the fragments and dynamic profiles and everything before we choose which ones to show. When you create one using `Duplicate`, though, you get a _new profile, with a new GUID_ that is a deep copy of the original fragment. It's not connected to it any more. It's a weird ethereal plane version of the original fragment. ☹️
claunia commented 2026-01-31 06:11:49 +00:00
Author
Owner
Copy Link

@danmock commented on GitHub (Sep 3, 2022):

I see. For our use case that would be problematic since we require a specific GUID for the profile, for each profile.

@danmock commented on GitHub (Sep 3, 2022): I see. For our use case that would be problematic since we require a specific GUID for the profile, for each profile.
claunia commented 2026-01-31 06:11:49 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 12, 2022):

another related thread: #11510

@zadjii-msft commented on GitHub (Sep 12, 2022): another related thread: #11510
claunia commented 2026-01-31 06:11:49 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 18, 2024):

@DHowett So this... wasn't also closed by #18188?

@zadjii-msft commented on GitHub (Nov 18, 2024): @DHowett So this... _wasn't_ also closed by #18188?
claunia commented 2026-01-31 06:11:50 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 18, 2024):

Correct! It’s backwards from the others - the user deletes their personal stub for a fragment and it never comes back (by design today, but Carlos’ Wxtensions page will help solve this.)

@DHowett commented on GitHub (Nov 18, 2024): Correct! It’s backwards from the others - the user deletes their personal stub for a fragment and it never comes back (by design today, but Carlos’ Wxtensions page will help solve this.)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Bug Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18370
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?