starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

closeTab should accept an index param #9997

New Issue
Closed
opened 2026-01-31 02:09:39 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 02:09:39 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Aug 4, 2020).

Similar to the other closetab actions being introduced in #7176.

This is being tracked with the other support for customizing the new-tab dropdown, which will need the ability to specify and action for the "close tab" menu item

Originally created by @zadjii-msft on GitHub (Aug 4, 2020). Similar to the other close*tab* actions being introduced in #7176. This is being tracked with the other support for customizing the new-tab dropdown, which will need the ability to specify and action for the "close tab" menu item
claunia commented 2026-01-31 02:09:40 +00:00
Author
Owner
Copy Link

@KimKiHyuk commented on GitHub (Aug 21, 2020):

Could you elaborate on it?

I didn't catch why closetab should accept index parameter.

you want to modify CloseTabsAction and _HandleCloseTab like #7176 ?

then, _HandleCloseTab method will be modified like under code

void TerminalPage::_HandleCloseTab(const IInspectable& /*sender*/,
                                       const TerminalApp::ActionEventArgs& args)
{
     if (const auto& realArgs = actionArgs.ActionArgs().try_as<TerminalApp::CloseTabArgs>())
     {
            uint32_t index = realArgs.Index(); // do you want to get it?

            _CloseFocusedTab();
             args.Handled(true);
      }
}
@KimKiHyuk commented on GitHub (Aug 21, 2020): Could you elaborate on it? I didn't catch why closetab should accept index parameter. you want to modify ```CloseTabsAction``` and ```_HandleCloseTab``` like #7176 ? then, ```_HandleCloseTab``` method will be modified like under code ```cpp void TerminalPage::_HandleCloseTab(const IInspectable& /*sender*/, const TerminalApp::ActionEventArgs& args) { if (const auto& realArgs = actionArgs.ActionArgs().try_as<TerminalApp::CloseTabArgs>()) { uint32_t index = realArgs.Index(); // do you want to get it? _CloseFocusedTab(); args.Handled(true); } } ```
claunia commented 2026-01-31 02:09:40 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 25, 2020):

@KimKiHyuk Pretty much yea - except, it'll be more like how it's implemented in #7390. So the implementation would be more like:

void TerminalPage::_HandleCloseTab(const IInspectable& /*sender*/,
                                       const TerminalApp::ActionEventArgs& args)
{
    if (const auto& realArgs = actionArgs.ActionArgs().try_as<TerminalApp::CloseTabArgs>())
    {
        if (realArgs.Index()) {
            // The user provided an `index`

            const auto index = realArgs.Index().Value();
            const bool handled = _CloseTheNthTab(index); // TODO: This function would need to be implemented of course
            args.Handled(handled); 
        }
        else
        {
            // No index was provided - close the currently active tab.
            _CloseFocusedTab();
             args.Handled(true);
        }
    }
}
@zadjii-msft commented on GitHub (Aug 25, 2020): @KimKiHyuk Pretty much yea - except, it'll be more like how it's implemented in #7390. So the implementation would be more like: ```cpp void TerminalPage::_HandleCloseTab(const IInspectable& /*sender*/, const TerminalApp::ActionEventArgs& args) { if (const auto& realArgs = actionArgs.ActionArgs().try_as<TerminalApp::CloseTabArgs>()) { if (realArgs.Index()) { // The user provided an `index` const auto index = realArgs.Index().Value(); const bool handled = _CloseTheNthTab(index); // TODO: This function would need to be implemented of course args.Handled(handled); } else { // No index was provided - close the currently active tab. _CloseFocusedTab(); args.Handled(true); } } }
claunia commented 2026-01-31 02:09:41 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 14, 2021):

:tada:This issue was addressed in #10447, which has now been successfully released as Windows Terminal Preview v1.10.1933.0.🎉

Handy links:

@ghost commented on GitHub (Jul 14, 2021): :tada:This issue was addressed in #10447, which has now been successfully released as `Windows Terminal Preview v1.10.1933.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.10.1933.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings good first issue Help Wanted Issue-Task Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9997
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?