starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Closing tab hangs when using VS Dev tools and Powershell Core #18507

New Issue
Closed
opened 2026-01-31 06:16:11 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 06:16:11 +00:00
Owner
Copy Link

Originally created by @phil-scott-78 on GitHub (Sep 19, 2022).

Originally assigned to: @lhecker on GitHub.

Windows Terminal version

1.16.2524.0

Windows build number

10.0.25201.0

Other Software

  • Visual Studio 2022
  • Powershell Core 7.2.6

Steps to reproduce

  1. Create a profile using pwsh.exe in Windows Terminal Preview
  2. Execute the following lines to add the VS dev tools
Import-Module "C:\Program Files\Microsoft Visual Studio\2022\Preview\Common7\Tools\Microsoft.VisualStudio.DevShell.dll"
Enter-VsDevShell 8ee891c5 -SkipAutomaticLocation -DevCmdArguments "-arch=x64 -host_arch=x64"
  1. Close the tab

Expected Behavior

Tab closes quickly.

Actual Behavior

wt locks up entirely doing...something.

Animation

I've tested this with the release version of Windows Terminal and also regular powershell.exe. Both of those don't exhibit the behavior. It is only with Powershell Core, the most recent release of wt.exe and the Visual Studio dev tools

Originally created by @phil-scott-78 on GitHub (Sep 19, 2022). Originally assigned to: @lhecker on GitHub. ### Windows Terminal version 1.16.2524.0 ### Windows build number 10.0.25201.0 ### Other Software * Visual Studio 2022 * Powershell Core 7.2.6 ### Steps to reproduce 1. Create a profile using `pwsh.exe` in Windows Terminal Preview 2. Execute the following lines to add the VS dev tools ```powershell Import-Module "C:\Program Files\Microsoft Visual Studio\2022\Preview\Common7\Tools\Microsoft.VisualStudio.DevShell.dll" Enter-VsDevShell 8ee891c5 -SkipAutomaticLocation -DevCmdArguments "-arch=x64 -host_arch=x64" ``` 3. Close the tab ### Expected Behavior Tab closes quickly. ### Actual Behavior wt locks up entirely doing...something. ![Animation](https://user-images.githubusercontent.com/2447331/190947485-bf79b9ca-82a6-4de5-bb15-7987e7b4dc3d.gif) I've tested this with the release version of Windows Terminal and also regular powershell.exe. Both of those don't exhibit the behavior. It is only with Powershell Core, the most recent release of wt.exe and the Visual Studio dev tools
claunia commented 2026-01-31 06:16:13 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Sep 19, 2022):

Ah, this could (possibly?) be fallout from #13882. /cc @lhecker for when he's got time.
Thanks for the report!

@DHowett commented on GitHub (Sep 19, 2022): Ah, this could (possibly?) be fallout from #13882. /cc @lhecker for when he's got time. Thanks for the report!
claunia commented 2026-01-31 06:16:14 +00:00
Author
Owner
Copy Link

@phil-scott-78 commented on GitHub (Sep 19, 2022):

I suspect you are right, I did a few heap dumps to see if I could spot anything of note and I noticed they were both hung on the same line related to the conpty connect, specifically this line https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalConnection/ConptyConnection.cpp#L557

@phil-scott-78 commented on GitHub (Sep 19, 2022): I suspect you are right, I did a few heap dumps to see if I could spot anything of note and I noticed they were both hung on the same line related to the conpty connect, specifically this line https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalConnection/ConptyConnection.cpp#L557
claunia commented 2026-01-31 06:16:14 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Sep 19, 2022):

I debugged this just now and and it's actually hung somewhere else for me:
(It's hung in WaitForSingleObject(pPty->hConPtyProcess, INFINITE);)

image

@lhecker commented on GitHub (Sep 19, 2022): I debugged this just now and and it's actually hung somewhere else for me: (It's hung in `WaitForSingleObject(pPty->hConPtyProcess, INFINITE);`) ![image](https://user-images.githubusercontent.com/2256941/191125460-f1f9cf53-ab4d-4845-9959-942837b134d4.png)
claunia commented 2026-01-31 06:16:14 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Sep 19, 2022):

Ah right... The old version used to close the connection in the background only, so it didn't matter how long it took and it wasn't visually apparent either: 666c446bc3 (diff-baa2e4fc26af1b8722a4eec13221622ef4ae566e4f7a8658bc58806f96b7e9b8L1525-L1526)
But as mentioned in the PR, that's not viable at all, because that's a pretty nasty race condition.

@lhecker commented on GitHub (Sep 19, 2022): Ah right... The old version used to close the connection in the background only, so it didn't matter how long it took and it wasn't visually apparent either: https://github.com/microsoft/terminal/commit/666c446bc38f741a7fc17b481ea1c665a4f31d13#diff-baa2e4fc26af1b8722a4eec13221622ef4ae566e4f7a8658bc58806f96b7e9b8L1525-L1526 But as mentioned in the PR, that's not viable at all, because that's a pretty nasty race condition.
claunia commented 2026-01-31 06:16:14 +00:00
Author
Owner
Copy Link

@phil-scott-78 commented on GitHub (Sep 20, 2022):

@lhecker, I just double checked - I'm hung on the same line. The one I posted earlier was down further in the stack.

@phil-scott-78 commented on GitHub (Sep 20, 2022): @lhecker, I just double checked - I'm hung on the same line. The one I posted earlier was down further in the stack.
claunia commented 2026-01-31 06:16:14 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Sep 23, 2022):

:tada:This issue was addressed in #14041, which has now been successfully released as Windows Terminal Preview v1.16.2641.0.🎉

Handy links:

@ghost commented on GitHub (Sep 23, 2022): :tada:This issue was addressed in #14041, which has now been successfully released as `Windows Terminal Preview v1.16.2641.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.16.2641.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 06:16:14 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 18, 2022):

:tada:This issue was addressed in #14041, which has now been successfully released as Windows Terminal v1.15.2874.🎉

Handy links:

@ghost commented on GitHub (Oct 18, 2022): :tada:This issue was addressed in #14041, which has now been successfully released as `Windows Terminal v1.15.2874`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.15.2874) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Issue-Bug Needs-Triage Priority-1 Product-Conpty Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18507
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?