starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Saving SETTINGS.JSON starts 11 processes #13882

New Issue
Closed
opened 2026-01-31 03:54:47 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 03:54:47 +00:00
Owner
Copy Link

Originally created by @vefatica on GitHub (May 24, 2021).

Windows Terminal version (or Windows build number)

Microsoft Windows 10 Pro for Workstations 10.0.19042.985 (2009, 20H2) WindowsTerminal: 1.8.1092.0

Other Software

No response

Steps to reproduce

With none of the WSL-related services running, open SETTINGS.JSON vie the settings UI and save it, noting the time.

Observe the processes that were started at that time.

Expected Behavior

Saving SETTINGS.JSON should not cause new processes to start.

Actual Behavior

I saved the file at 11:53:21 and got

Start  Time            Pid       CPU(s)     WS(M)  Name
--------------------------------------------------------------------------------
05/24  11:53:21.392  10204        0.156      12.4  LxssManager             LxssManager
05/24  11:53:21.439   6980        0.016      10.9  vmcompute               Hyper-V Host Compute Service
05/24  11:53:21.587   5088        0.078      12.9  hns                     Host Network Service
05/24  11:53:21.604   5204        0.078       7.5  nvagent                 Network Virtualization Service
05/24  11:53:21.622   7548        0.031      18.8  SharedAccess            Internet Connection Sharing (ICS)
05/24  11:53:21.666   9552        0.125       6.7  NetSetupSvc             NetSetupSvc
05/24  11:53:21.457   9376        0.125      19.3  vmwp.exe
05/24  11:53:21.478   3556        0.531     418.0  vmmem
05/24  11:53:22.215  10188        0.016       4.8  wslhost.exe
05/24  11:53:22.222   8164        0.000      10.9  conhost.exe
05/24  11:53:22.235   3612        0.016       8.8  dllhost.exe

That does not happen when I start WindowsTerminal, possibly because I have "Windows.Terminal.Wsl" among "disabledProfileSources". My guess is that it need not happen when the settings are reloaded.

Originally created by @vefatica on GitHub (May 24, 2021). ### Windows Terminal version (or Windows build number) Microsoft Windows 10 Pro for Workstations 10.0.19042.985 (2009, 20H2) WindowsTerminal: 1.8.1092.0 ### Other Software _No response_ ### Steps to reproduce With none of the WSL-related services running, open SETTINGS.JSON vie the settings UI and save it, noting the time. Observe the processes that were started at that time. ### Expected Behavior Saving SETTINGS.JSON should not cause new processes to start. ### Actual Behavior I saved the file at 11:53:21 and got ``` Start Time Pid CPU(s) WS(M) Name -------------------------------------------------------------------------------- 05/24 11:53:21.392 10204 0.156 12.4 LxssManager LxssManager 05/24 11:53:21.439 6980 0.016 10.9 vmcompute Hyper-V Host Compute Service 05/24 11:53:21.587 5088 0.078 12.9 hns Host Network Service 05/24 11:53:21.604 5204 0.078 7.5 nvagent Network Virtualization Service 05/24 11:53:21.622 7548 0.031 18.8 SharedAccess Internet Connection Sharing (ICS) 05/24 11:53:21.666 9552 0.125 6.7 NetSetupSvc NetSetupSvc 05/24 11:53:21.457 9376 0.125 19.3 vmwp.exe 05/24 11:53:21.478 3556 0.531 418.0 vmmem 05/24 11:53:22.215 10188 0.016 4.8 wslhost.exe 05/24 11:53:22.222 8164 0.000 10.9 conhost.exe 05/24 11:53:22.235 3612 0.016 8.8 dllhost.exe ``` That does not happen when I start WindowsTerminal, possibly because I have "Windows.Terminal.Wsl" among "disabledProfileSources". My guess is that it need not happen when the settings are reloaded.
claunia commented 2026-01-31 03:54:48 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 24, 2021):

Huh. Weird that we'd boot WSL even if it is disabled. We probably shouldn't do that.

@zadjii-msft commented on GitHub (May 24, 2021): Huh. Weird that we'd boot WSL even if it is disabled. We probably shouldn't do that.
claunia commented 2026-01-31 03:54:48 +00:00
Author
Owner
Copy Link

@vefatica commented on GitHub (May 24, 2021):

Hmmm! Apparently it's happening when the startingDirectory path in my user-defined Ubuntu profile is validated. It doesn't happen if I comment out the startingDirectory. Does it have to do that?

"startingDirectory": "\\\\wsl$\\Ubuntu\\home\\vefatica"
@vefatica commented on GitHub (May 24, 2021): Hmmm! Apparently it's happening when the startingDirectory path in my user-defined Ubuntu profile is validated. It doesn't happen if I comment out the startingDirectory. Does it have to do that? ``` "startingDirectory": "\\\\wsl$\\Ubuntu\\home\\vefatica" ```
claunia commented 2026-01-31 03:54:48 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 24, 2021):

Fortunately, I think we just removed the code that does that.

@DHowett commented on GitHub (May 24, 2021): Fortunately, I think we just removed the code that does that.
claunia commented 2026-01-31 03:54:48 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 24, 2021):

Oh good catch! Turns out, it won't anymore! See #10045. We're gonna stop doing that in 1.9.

@zadjii-msft commented on GitHub (May 24, 2021): Oh good catch! Turns out, _it won't anymore_! See #10045. We're gonna stop doing that in 1.9.
claunia commented 2026-01-31 03:54:49 +00:00
Author
Owner
Copy Link

@vefatica commented on GitHub (May 24, 2021):

That sounds good.

@vefatica commented on GitHub (May 24, 2021): That sounds good.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Help Wanted Issue-Bug Needs-Triage Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13882
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?