starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13882] [MERGED] Fix a ControlCore race condition on connection close #29796

New Issue
Open
opened 2026-01-31 09:36:57 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:36:57 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13882
Author: @lhecker
Created: 8/30/2022
Status: ✅ Merged
Merged: 9/6/2022
Merged by: @undefined

Base: main ← Head: dev/lhecker/13880-connection-close-race

📝 Commits (2)

  • 9cd5ea6 Fix a ControlCore race condition on connection close
  • 9ca1a19 Merge Dustin's feedback

📊 Changes

4 files changed (+12 additions, -48 deletions)

View changed files

📝 src/cascadia/TerminalConnection/AzureConnection.cpp (+4 -3)
📝 src/cascadia/TerminalConnection/ConptyConnection.cpp (+7 -10)
📝 src/cascadia/TerminalControl/ControlCore.cpp (+1 -33)
📝 src/cascadia/TerminalControl/ControlCore.h (+0 -2)

📄 Description

As noted by the winrt::event documentation:

[...] But for asynchronous events, even after revoking [...], an in-flight
event might reach your object after it has started destructing.

This is because while adding/removing/calling event handlers might be
thread-safe, there's no guarantee that they run mutually exclusive.

This commit fixes the issue by reverting 6f0f245. Since we never checked
the result of closing a terminal connection anyways, this commit simply drops
the wait on the connection being teared down to ensure #1996 doesn't regress.

Closes #13880

Validation Steps Performed

  • Open tab, close tab, open tab, close tab, open tab, close tab
    • ConPTY ✅
    • Azure ✅
  • Closing a tab with a huge amount of panes ✅
  • Opening a bunch of tabs and then closing the window ✅
  • Closing a tab while it's busy with VT ✅
  • wtd -w 0 nt cmd /c exit ✅
  • wtd -w -1 cmd /c exit
    • No WerFault spawns ✅

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13882 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 8/30/2022 **Status:** ✅ Merged **Merged:** 9/6/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/13880-connection-close-race` --- ### 📝 Commits (2) - [`9cd5ea6`](https://github.com/microsoft/terminal/commit/9cd5ea6fef8d49371aa08f3fd5effced2af24a2e) Fix a ControlCore race condition on connection close - [`9ca1a19`](https://github.com/microsoft/terminal/commit/9ca1a19be8098c4885a7688fe4c11f6dfadd0b34) Merge Dustin's feedback ### 📊 Changes **4 files changed** (+12 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalConnection/AzureConnection.cpp` (+4 -3) 📝 `src/cascadia/TerminalConnection/ConptyConnection.cpp` (+7 -10) 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+1 -33) 📝 `src/cascadia/TerminalControl/ControlCore.h` (+0 -2) </details> ### 📄 Description As noted by the `winrt::event` documentation: > [...] But for asynchronous events, even after revoking [...], an in-flight > event might reach your object after it has started destructing. This is because while adding/removing/calling event handlers might be thread-safe, there's no guarantee that they run mutually exclusive. This commit fixes the issue by reverting 6f0f245. Since we never checked the result of closing a terminal connection anyways, this commit simply drops the wait on the connection being teared down to ensure #1996 doesn't regress. Closes #13880 ## Validation Steps Performed * Open tab, close tab, open tab, close tab, open tab, close tab * ConPTY ✅ * Azure ✅ * Closing a tab with a huge amount of panes ✅ * Opening a bunch of tabs and then closing the window ✅ * Closing a tab while it's busy with VT ✅ * `wtd -w 0 nt cmd /c exit` ✅ * `wtd -w -1 cmd /c exit` * No WerFault spawns ✅ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:36:57 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29796
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?