starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Block Elements not rendering correctly with AtlasEngine enabled #18558

New Issue
Closed
opened 2026-01-31 06:17:36 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 06:17:36 +00:00
Owner
Copy Link

Originally created by @Dan-Albrecht on GitHub (Sep 28, 2022).

Originally assigned to: @lhecker on GitHub.

Windows Terminal version

1.16.2642.0

Windows build number

10.0.22000.0

Other Software

No response

Steps to reproduce

In PowerShell with the default Cascadia Mono font, run: Write-Host "`u{2595}`u{2594}`n`u{2595}`u{2581}"

Expected Behavior

In version 1.15.2525.0 or 1.16.2642.0 with AtlasEngine disabled:
image

Actual Behavior

The top is cut off:
image

Originally created by @Dan-Albrecht on GitHub (Sep 28, 2022). Originally assigned to: @lhecker on GitHub. ### Windows Terminal version 1.16.2642.0 ### Windows build number 10.0.22000.0 ### Other Software _No response_ ### Steps to reproduce In PowerShell with the default Cascadia Mono font, run: ``Write-Host "`u{2595}`u{2594}`n`u{2595}`u{2581}"`` ### Expected Behavior In version 1.15.2525.0 or 1.16.2642.0 with AtlasEngine disabled: <img width="401" alt="image" src="https://user-images.githubusercontent.com/7351388/192859338-6757f670-6bb3-4993-a349-e93f466929bd.png"> ### Actual Behavior The top is cut off: <img width="404" alt="image" src="https://user-images.githubusercontent.com/7351388/192859478-619f29e5-f8da-4633-a567-70b9c12ce3a1.png">
claunia commented 2026-01-31 06:17:38 +00:00
Author
Owner
Copy Link

@Dan-Albrecht commented on GitHub (Sep 28, 2022):

Might be same underlying issue as #14022

@Dan-Albrecht commented on GitHub (Sep 28, 2022): Might be same underlying issue as #14022
claunia commented 2026-01-31 06:17:39 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Sep 28, 2022):

Note to self/team: The block character scaling technique in _getCachedGlyphLayout is inherently flawed as I realized yesterday. What it does is:

  • Get the glyph's advance width/height
  • Resize to match the cell size

This doesn't work with fonts that use side bearings for block characters. A better way would be to assume that all fonts that define any block character also probably define the U+2588 Full Block character. That way we can do:

  • Get the font's full block glyph
  • Get the actual size including side bearings of the full block
  • Resize to match the cell size but apply the scale to the given glyph instead
@lhecker commented on GitHub (Sep 28, 2022): Note to self/team: The block character scaling technique in `_getCachedGlyphLayout` is inherently flawed as I realized yesterday. What it does is: * Get the glyph's advance width/height * Resize to match the cell size This doesn't work with fonts that use side bearings for block characters. A better way would be to assume that all fonts that define any block character also probably define the U+2588 Full Block character. That way we can do: * Get the font's full block glyph * Get the actual size including side bearings of the full block * Resize to match the cell size but apply the scale to the given glyph instead
claunia commented 2026-01-31 06:17:39 +00:00
Author
Owner
Copy Link

@Dan-Albrecht commented on GitHub (Oct 19, 2022):

@lhecker, while I agree your change is correctly called righer-er, I think we need a even-more-righter followup as my issue is not resolved. I'm built from source at bfd480b. U+2594 seems to be causing problems and doesn't seem to be in the torture test.

Write-Host "`u{2595}`u{2594}`n`u{2595}`u{2581}"
Write-Host "`nXXX`n`u{2594}`nXXX`n"

Atlas Off:
image

Atlas On:
image

@Dan-Albrecht commented on GitHub (Oct 19, 2022): @lhecker, while I agree your change is correctly called `righer-er`, I think we need a `even-more-righter` followup as my issue is not resolved. I'm built from source at bfd480b. `U+2594` seems to be causing problems and doesn't seem to be in the torture test. ``` Write-Host "`u{2595}`u{2594}`n`u{2595}`u{2581}" Write-Host "`nXXX`n`u{2594}`nXXX`n" ``` Atlas Off: <img width="570" alt="image" src="https://user-images.githubusercontent.com/7351388/196575674-384be401-e5c1-4692-8ab4-1f4f160adab7.png"> Atlas On: <img width="574" alt="image" src="https://user-images.githubusercontent.com/7351388/196575339-58596b72-7912-4691-bf86-9072318616eb.png">
claunia commented 2026-01-31 06:17:39 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Oct 19, 2022):

@Dan-Albrecht Somewhat "late" in the development cycle I changed the algorithm so that it doesn't touch characters found in the given user font. My intention was that glyphs in the user's font remain untouched. If we don't do that this leads to other display issues (incorrect alginment, etc.). U+2594 is part of Cascadia Mono and so it won't get "adjusted" to fit the cell and I forgot to re-test it as part of the PR, focusing only on Consolas, etc.

Not sure what to do about this issue now: I should try to see if it helps to round up ascend/descend after all. But I'm not certain we can merge that - people have complained in the past when I did that. Otherwise we'll either have to wait for the next big AtlasEngine update which brings support for overlapping glyphs, or support for line height adjustments (which I'm submitting tomorrow).

@lhecker commented on GitHub (Oct 19, 2022): @Dan-Albrecht Somewhat "late" in the development cycle I changed the algorithm so that it doesn't touch characters found in the given user font. My intention was that glyphs in the user's font remain untouched. If we don't do that this leads to other display issues (incorrect alginment, etc.). U+2594 is part of Cascadia Mono and so it won't get "adjusted" to fit the cell and I forgot to re-test it as part of the PR, focusing only on Consolas, etc. Not sure what to do about this issue now: I should try to see if it helps to round up ascend/descend after all. But I'm not certain we can merge that - people have complained in the past when I did that. Otherwise we'll either have to wait for the next big AtlasEngine update which brings support for overlapping glyphs, or support for line height adjustments (which I'm submitting tomorrow).
claunia commented 2026-01-31 06:17:39 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Dec 14, 2022):

:tada:This issue was addressed in #14099, which has now been successfully released as Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0.🎉

Handy links:

@ghost commented on GitHub (Dec 14, 2022): :tada:This issue was addressed in #14099, which has now been successfully released as `Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.16.3464.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-AtlasEngine In-PR Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18558
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?