starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[1.17] Launch Params in SUI needs a little cleanup #19067

New Issue
Closed
opened 2026-01-31 06:32:48 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 06:32:48 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Dec 14, 2022).

Originally assigned to: @carlos-zamora on GitHub.

Bug 1: Launch Params resizes as you type X/Y val

Duped to #13495 image

Then when you click off of it, it looks like the num box buttons appear over the text? Weird.
image

Bug 2: rework Launch Params preview

I still feel like "Default,Default" should be something like…

"Let system position window" or "system position" or whatever

Should "Use system default" be renamed to "Let system position window"

Originally created by @carlos-zamora on GitHub (Dec 14, 2022). Originally assigned to: @carlos-zamora on GitHub. # Bug 1: Launch Params resizes as you type X/Y val <details> <summary>Duped to #13495</summary> <img width="358" alt="image" src="https://user-images.githubusercontent.com/11050425/207737443-104ee2c6-c331-4fe6-b369-0c8232c059eb.png"> Then when you click off of it, it looks like the num box buttons appear over the text? Weird. <img width="93" alt="image" src="https://user-images.githubusercontent.com/11050425/207737476-59c3a7cc-5828-4933-a8e5-89d28dba7d9a.png"> </details> # Bug 2: rework Launch Params preview I still feel like "Default,Default" should be something like… "Let system position window" or "system position" or whatever Should "Use system default" be renamed to "Let system position window"
claunia commented 2026-01-31 06:32:50 +00:00
Author
Owner
Copy Link

@ianjoneill commented on GitHub (Dec 15, 2022):

I think bug 1 may be a dupe of #13495 - the history size input does exactly the same thing.

@ianjoneill commented on GitHub (Dec 15, 2022): I think bug 1 may be a dupe of #13495 - the history size input does exactly the same thing.
claunia commented 2026-01-31 06:32:50 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 15, 2022):

I think bug 1 may be a dupe of https://github.com/microsoft/terminal/issues/13495

Yes it is

Should "Use system default" be renamed to "Let system position window"

absolutely yes

@zadjii-msft commented on GitHub (Dec 15, 2022): > I think bug 1 may be a dupe of https://github.com/microsoft/terminal/issues/13495 Yes it is > Should "Use system default" be renamed to "Let system position window" absolutely yes
claunia commented 2026-01-31 06:32:50 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Dec 15, 2022):

@zadjii-msft Hmm... Since #13495 is tracking upgrading to WinUI 2.8 (which would fix the bug, of course, but it's a lot of extra work). How do we feel about changing the SpinButtonPlacementMode from Inline to Compact? I assume that fixes the problem and it would be super simple.

@carlos-zamora commented on GitHub (Dec 15, 2022): @zadjii-msft Hmm... Since #13495 is tracking upgrading to WinUI 2.8 (which would fix the bug, of course, but it's a lot of extra work). How do we feel about changing the `SpinButtonPlacementMode` from `Inline` to `Compact`? I assume that fixes the problem and it would be super simple.
claunia commented 2026-01-31 06:32:50 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 15, 2022):

How do we feel about changing the SpinButtonPlacementMode from Inline to Compact? I assume that fixes the problem and it would be super simple.

I mean, would it? I'm honestly fine leaving that half of the bug as is (and waiting for eventually figuring out winui 2.8), it only happens with huge numbers anyways, yea?

@zadjii-msft commented on GitHub (Dec 15, 2022): > How do we feel about changing the SpinButtonPlacementMode from Inline to Compact? I assume that fixes the problem and it would be super simple. I mean, _would it_? I'm honestly fine leaving that half of the bug as is (and waiting for eventually figuring out winui 2.8), it only happens with huge numbers anyways, yea?
claunia commented 2026-01-31 06:32:51 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Dec 15, 2022):

How do we feel about changing the SpinButtonPlacementMode from Inline to Compact? I assume that fixes the problem and it would be super simple.

I mean, would it? I'm honestly fine leaving that half of the bug as is (and waiting for eventually figuring out winui 2.8), it only happens with huge numbers anyways, yea?

I did the thing: #14569

@carlos-zamora commented on GitHub (Dec 15, 2022): > > How do we feel about changing the SpinButtonPlacementMode from Inline to Compact? I assume that fixes the problem and it would be super simple. > > I mean, _would it_? I'm honestly fine leaving that half of the bug as is (and waiting for eventually figuring out winui 2.8), it only happens with huge numbers anyways, yea? I did the thing: #14569
claunia commented 2026-01-31 06:32:51 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 24, 2023):

:tada:This issue was addressed in #14569, which has now been successfully released as Windows Terminal Preview v1.17.1023.🎉

Handy links:

@ghost commented on GitHub (Jan 24, 2023): :tada:This issue was addressed in #14569, which has now been successfully released as `Windows Terminal Preview v1.17.1023`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.17.1023) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Issue-Bug Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19067
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?