starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Setting Appearance to "Use Windows Theme" only half respects it #19291

New Issue
Closed
opened 2026-01-31 06:39:09 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 06:39:09 +00:00
Owner
Copy Link

Originally created by @blowdart on GitHub (Jan 30, 2023).

Originally assigned to: @zadjii-msft on GitHub.

Windows Terminal version

1.16.10261.09

Windows build number

10.0.22621.0

Other Software

No response

Steps to reproduce

Change settings in Terminal to Use Windows Theme
Set Windows to have WIndows Mode as Dark and App Mode as Light
Glare at tab background colour in disgust

Expected Behavior

In mixed dark/light other apps, such as Edge and Explorer, use the app colour for the tab background, I would expect Terminal to do the same, rather than end up with a dark tab background

Screenshot 2023-01-30 045815

Actual Behavior

Screenshot 2023-01-30 045258

The tab background is always dark.

Originally created by @blowdart on GitHub (Jan 30, 2023). Originally assigned to: @zadjii-msft on GitHub. ### Windows Terminal version 1.16.10261.09 ### Windows build number 10.0.22621.0 ### Other Software _No response_ ### Steps to reproduce Change settings in Terminal to Use Windows Theme Set Windows to have WIndows Mode as Dark and App Mode as Light Glare at tab background colour in disgust ### Expected Behavior In mixed dark/light other apps, such as Edge and Explorer, use the app colour for the tab background, I would expect Terminal to do the same, rather than end up with a dark tab background ![Screenshot 2023-01-30 045815](https://user-images.githubusercontent.com/796298/215484145-03b00ed1-a166-468f-a6ba-cfaafd602b12.png) ### Actual Behavior ![Screenshot 2023-01-30 045258](https://user-images.githubusercontent.com/796298/215483707-e5c48a7d-4125-4a2a-aaab-09607ea4cbc9.png) The tab background is always dark.
claunia added the Issue-QuestionIssue-BugResolution-Duplicate labels 2026-01-31 06:39:09 +00:00
claunia commented 2026-01-31 06:39:10 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 2, 2023):

Ah so, yes, this might need to be clarified too. This is a side effect of some of the Theme changes in 1.16. I'm workshopping some messaging in https://github.com/MicrosoftDocs/terminal/issues/635#issuecomment-1405272392. I'll add a note about this.

Basically, in 1.16, the default themes will always use the Terminal's background color as the default color for the tab. So, in the default case, with a black terminal window, you're going to get a black tab. With a blue color scheme (like Campbell PowerShell), you'll get a blue tab. This is to give the Terminal that "seemless" feel.

In light mode, that obviously creates a bit of a weird case where you get a black tab on a white tab row. No worries though! With 1.16, you can customize the theme of the Terminal in lots of new ways. So, if you want a theme where the tabs are white again, you can do something like:

    "theme": "White Tabs",
    "themes":
    [
        {
            "name": "White Tabs",
            "tab":
            {
                "background": "#ffffffff",
            },
            "window":
            {
                "applicationTheme": "light"
            }
        },
    ]

ALTERNATIVELY, you could set the color scheme of the Terminal to something with a white background. If you're using light theme, then maybe that's what you want?

1.17 is going to make this even better, because we've added the ability to set different color schemes depending on the theme of the window, so you can set your scheme like:

"colorScheme":
{
    "light": "One Half Light",
    "dark": "One Half Dark",
},

and now presto - the terminal background will change in accordance with the window.applicationTheme of the Terminal.

Does that all make sense/?

@zadjii-msft commented on GitHub (Feb 2, 2023): Ah so, yes, this might need to be clarified too. This is a side effect of some of the Theme changes in 1.16. I'm workshopping some messaging in https://github.com/MicrosoftDocs/terminal/issues/635#issuecomment-1405272392. I'll add a note about this. Basically, in 1.16, the default themes will always use the Terminal's background color as the default color for the tab. So, in the default case, with a black terminal window, you're going to get a black tab. With a blue color scheme (like Campbell PowerShell), you'll get a blue tab. This is to give the Terminal that "seemless" feel. In light mode, that obviously creates a bit of a weird case where you get a black tab on a white tab row. No worries though! With 1.16, you can customize the theme of the Terminal in lots of new ways. So, if you want a theme where the tabs are white again, you can do something like: ```json "theme": "White Tabs", "themes": [ { "name": "White Tabs", "tab": { "background": "#ffffffff", }, "window": { "applicationTheme": "light" } }, ] ``` ALTERNATIVELY, you could set the color scheme of the Terminal to something with a white background. If you're using light theme, then maybe that's what you want? 1.17 is going to make this even better, because we've added the ability to set different color schemes depending on the theme of the window, so you can set your scheme like: ```json "colorScheme": { "light": "One Half Light", "dark": "One Half Dark", }, ``` and now presto - the terminal background will change in accordance with the `window.applicationTheme` of the Terminal. Does that all make sense/?
claunia commented 2026-01-31 06:39:11 +00:00
Author
Owner
Copy Link

@fxzxmic commented on GitHub (Feb 9, 2023):

image
I'm glad to see that there is still a solution, because I really don't like this feature, which is too odd. I prefer dark interfaces but bright tabs.

And it seems that 1.17 has made an interesting attempt to provide more customizable features. But I think if it would be better to add tab color setting to the color scheme? You cannot follow the system mode if you set it alone. Or add system option for the tab background.

@fxzxmic commented on GitHub (Feb 9, 2023): ![image](https://user-images.githubusercontent.com/54622331/217779689-d21aa5c9-9995-4c19-8bee-1bc06989c2df.png) I'm glad to see that there is still a solution, because I really don't like this feature, which is too odd. I prefer dark interfaces but bright tabs. And it seems that 1.17 has made an interesting attempt to provide more customizable features. ~~But I think if it would be better to add tab color setting to the color scheme? You cannot follow the system mode if you set it alone.~~ Or add `system` option for the tab background.
claunia commented 2026-01-31 06:39:11 +00:00
Author
Owner
Copy Link

@blowdart commented on GitHub (Feb 9, 2023):

Apologies, github didn't alert me to your response.

While I suppose it makes sense the method to meet my expectations is, well, complicated. I suppose this boils down to a difference of opinions on whether the tab is part of the individual prompt window or part of the UI of terminal itself. Windows itself had real problems with Task Manager when you mixed light and dark mode too.

That light mode produces "odd" results is perhaps an assumption on what developers prefer - it's almost a VI versus EMACS religious crusade, but at my age light mode is easier on the eyes.

I'm afraid I agree with @fxzxmic here. A setting of "Use Windows color schemes" rather than the terminal unique ones would be simpler. I don't want white tabs, I want it to match Windows itself, depending on what the current Windows schemes are, but even that may still have the same problem, depending on how you see the tab ownership. It becomes a question of do you mimic windows, or do you go your own way?

@blowdart commented on GitHub (Feb 9, 2023): Apologies, github didn't alert me to your response. While I suppose it makes sense the method to meet my expectations is, well, complicated. I suppose this boils down to a difference of opinions on whether the tab is part of the individual prompt window or part of the UI of terminal itself. Windows itself had real problems with Task Manager when you mixed light and dark mode too. That light mode produces "odd" results is perhaps an assumption on what developers prefer - it's almost a VI versus EMACS religious crusade, but at my age light mode is easier on the eyes. I'm afraid I agree with @fxzxmic here. A setting of "Use Windows color schemes" rather than the terminal unique ones would be simpler. I don't want white tabs, I want it to match Windows itself, depending on what the current Windows schemes are, but even that may still have the same problem, depending on how you see the tab ownership. It becomes a question of do you mimic windows, or do you go your own way?
claunia commented 2026-01-31 06:39:11 +00:00
Author
Owner
Copy Link

@fireattack commented on GitHub (Feb 9, 2023):

To me, the UI, and the "content" inside (or the "canvas"), are two different parts.

The UI should be controlled by the theme, while the canvas should be controlled by something else (in WT's case, the color scheme for that profile).

Just like the you can set page color in Word without affecting the UI elements. Or how tabs look like in browsers.

Another change I don't understand is why it defaults to dark instead of "use Windows theme".

@fireattack commented on GitHub (Feb 9, 2023): To me, the UI, and the "content" inside (or the "canvas"), are two different parts. The UI should be controlled by the theme, while the canvas should be controlled by something else (in WT's case, the color scheme for that profile). Just like the you can set page color in Word without affecting the UI elements. Or how tabs look like in browsers. Another change I don't understand is why it defaults to dark instead of "use Windows theme".
claunia commented 2026-01-31 06:39:11 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 10, 2023):

I'm gonna close this to merge the discussion with /dup #14815

@zadjii-msft commented on GitHub (Feb 10, 2023): I'm gonna close this to merge the discussion with /dup #14815
claunia commented 2026-01-31 06:39:11 +00:00
Author
Owner
Copy Link

@microsoft-github-policy-service[bot] commented on GitHub (Feb 10, 2023):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service[bot] commented on GitHub (Feb 10, 2023): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Issue-Question Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19291
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?