starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Resizing terminal clears selection #14815

New Issue
Open
opened 2026-01-31 04:20:12 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 04:20:12 +00:00
Owner
Copy Link

Originally created by @Don-Vito on GitHub (Aug 8, 2021).

Windows Terminal version (or Windows build number)

Dev - latest

Other Software

No response

Steps to reproduce

  1. Select text.
  2. Resize the terminal vertically
  3. Select text
  4. Resize terminal horizontally

Expected Behavior

  • After 2: the selection should be preserved (both block and non-block selection)
  • After 4: probably, non-block selection should remain adjusted to the new position of the selected text

Actual Behavior

Selection is cleared both after 2 and 4 (inside _doResizeUnderLock)

Originally created by @Don-Vito on GitHub (Aug 8, 2021). ### Windows Terminal version (or Windows build number) Dev - latest ### Other Software _No response_ ### Steps to reproduce 1. Select text. 2. Resize the terminal vertically 3. Select text 4. Resize terminal horizontally ### Expected Behavior - After 2: the selection should be preserved (both block and non-block selection) - After 4: probably, non-block selection should remain adjusted to the new position of the selected text ### Actual Behavior Selection is cleared both after 2 and 4 (inside _doResizeUnderLock)
claunia commented 2026-01-31 04:20:13 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 10, 2021):

Yea, I can be open to the idea of doing this again.

We reverted this at some point because we weren't doing it right in Terminal. See #1368 for some context there. I don't believe conhost ever persisted the selection on a resize, so I think that's why we were okay breaking it again.

@zadjii-msft commented on GitHub (Aug 10, 2021): Yea, I can be open to the idea of doing this again. We reverted this at some point because we weren't doing it right in Terminal. See #1368 for some context there. I don't believe conhost _ever_ persisted the selection on a resize, so I think that's why we were okay breaking it again.
claunia commented 2026-01-31 04:20:13 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Aug 15, 2021):

Yea, I can be open to the idea of doing this again.

We reverted this at some point because we weren't doing it right in Terminal. See #1368 for some context there. I don't believe conhost ever persisted the selection on a resize, so I think that's why we were okay breaking it again.

Oh.. I looked for it but didn't find it. BTW conhost does not clear selection upon vertical-only resize.

@Don-Vito commented on GitHub (Aug 15, 2021): > > > Yea, I can be open to the idea of doing this again. > > We reverted this at some point because we weren't doing it right in Terminal. See #1368 for some context there. I don't believe conhost _ever_ persisted the selection on a resize, so I think that's why we were okay breaking it again. Oh.. I looked for it but didn't find it. BTW conhost does not clear selection upon vertical-only resize.
claunia commented 2026-01-31 04:20:13 +00:00
Author
Owner
Copy Link

@sourabh112 commented on GitHub (Aug 21, 2021):

Can I take on this issue( If it is not too difficult for a newbie)?
As I'm quite new to this so I might also need some guidance on where should I start.

@sourabh112 commented on GitHub (Aug 21, 2021): Can I take on this issue( If it is not too difficult for a newbie)? As I'm quite new to this so I might also need some guidance on where should I start.
claunia commented 2026-01-31 04:20:14 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 21, 2021):

@sourabh112 You're welcome to try, but I'm guessing that this might be one of the harder issues. The trick is that the resize is handled by TextBuffer::Reflow, but the selection endpoints are stored totally elsewhere - in TerminalSelection and in SCREEN_INFORMATION. So somehow you'd need to pass those points in to Reflow to then track where they should be once the buffer's been resized. Not impossible, but probably not the best issue as a starter IMO. These issues might be better suited for a first issue.

@zadjii-msft commented on GitHub (Aug 21, 2021): @sourabh112 You're welcome to try, but I'm guessing that this might be one of the harder issues. The trick is that the resize is handled by `TextBuffer::Reflow`, but the selection endpoints are stored totally elsewhere - in `TerminalSelection` and in `SCREEN_INFORMATION`. So somehow you'd need to pass those points in to `Reflow` to then track where they should be once the buffer's been resized. Not impossible, but probably not the best issue as a starter IMO. [These issues might be better suited for a first issue](https://github.com/microsoft/terminal/issues?q=is%3Aopen+is%3Aissue+label%3A%22Easy+Starter%22).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Help Wanted Issue-Bug Priority-2 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14815
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?