starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 16:34:42 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Tab background should use opacity from profile #19370

New Issue
Open
opened 2026-01-31 06:41:17 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 06:41:17 +00:00
Owner
Copy Link

Originally created by @mosterme on GitHub (Feb 12, 2023).

The tab background color is picked from the current profile, but the opacity is not.
Which makes the tabs appear even darker than the actual tab contents.

terminal-1 terminal-2

Light theme and GitBash on Solarized Dark with 70 opacity and useAcrylic.
Windows-Terminal Version: 1.16.10262.0

Setting RGBA color values for tab colors in themes already works.
But then you lose the color hue from the current profile.

Hovering over an inactive tab comes close to the expected result.

terminal-3

This is somewhat related to #14026 and #14815.

Originally created by @mosterme on GitHub (Feb 12, 2023). The tab background color is picked from the current profile, but the opacity is not. Which makes the tabs appear even darker than the actual tab contents. ![terminal-1](https://user-images.githubusercontent.com/6878281/218296616-576a83f9-6c0c-41c8-bee3-6cb9264b1491.png) ![terminal-2](https://user-images.githubusercontent.com/6878281/218296617-a690d986-d841-4142-a8d8-9a52959530a5.png) _Light theme and GitBash on Solarized Dark with 70 opacity and useAcrylic. Windows-Terminal Version: 1.16.10262.0_ Setting RGBA color values for tab colors in themes already works. But then you lose the color hue from the current profile. Hovering over an inactive tab comes close to the expected result. ![terminal-3](https://user-images.githubusercontent.com/6878281/218299141-6e628c30-717b-4777-a53b-24b61ebc19d5.png) This is somewhat related to #14026 and #14815.
claunia added the Issue-FeatureProduct-TerminalArea-Theming labels 2026-01-31 06:41:18 +00:00
claunia commented 2026-01-31 06:41:19 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 4, 2023):

Huh, why doesn't this work?

PERHAPS

if (const auto themeBrush{ tab->_themeColor.Evaluate(Application::Current().Resources(), terminalBrush, false) })
{
    // ThemeColor.Evaluate will get us a Brush (because the
    // TermControl could have an acrylic BG, for example). Take
    // that brush, and get the color out of it. We don't really
    // want to have the tab items themselves be acrylic.
    tab->_ApplyTabColorOnUIThread(til::color{ ThemeColor::ColorFromBrush(themeBrush) });
}

I wonder if we're setting the .Opacity on the brush, rather than the alpha, and doing the ThemeColor::Evaluate -> ColorFromBrush trip loses that Opacity that should really act as an alpha...

@zadjii-msft commented on GitHub (Apr 4, 2023): Huh, why doesn't this work? PERHAPS ```c++ if (const auto themeBrush{ tab->_themeColor.Evaluate(Application::Current().Resources(), terminalBrush, false) }) { // ThemeColor.Evaluate will get us a Brush (because the // TermControl could have an acrylic BG, for example). Take // that brush, and get the color out of it. We don't really // want to have the tab items themselves be acrylic. tab->_ApplyTabColorOnUIThread(til::color{ ThemeColor::ColorFromBrush(themeBrush) }); } ``` I wonder if we're setting the `.Opacity` on the brush, rather than the `alpha`, and doing the `ThemeColor::Evaluate` -> `ColorFromBrush` trip loses that `Opacity` that should really act as an alpha...
claunia commented 2026-01-31 06:41:19 +00:00
Author
Owner
Copy Link

@mosterme commented on GitHub (May 6, 2023):

After looking at #15294, I tried testing out https://learn.microsoft.com/en-us/windows/terminal/customize-settings/themes again.

    "theme": "theme1",
    "themes": [
        {
            "name": "theme1",
            "tab":
            {
                "background": "terminalBackground"
            },
            "window":
            {
                "applicationTheme": "system"
            }
        }       
    ],
    "useAcrylicInTabRow": true,

This is the result. First tab is inactive, second tab is hovering over, third tab is the active one. Inactive tabs already look nicer now.

terminal-4

But the following sentences from the documentation make me doubt the desired result can currently be achieved with themes.

This color is always treated as a solid color, even if set to a terminalBackground of a pane with an acrylic background.

When set to terminalBackground or accent, this will automatically use an alpha value of 30%, to be semi-transparent.

@mosterme commented on GitHub (May 6, 2023): After looking at #15294, I tried testing out https://learn.microsoft.com/en-us/windows/terminal/customize-settings/themes again. ``` "theme": "theme1", "themes": [ { "name": "theme1", "tab": { "background": "terminalBackground" }, "window": { "applicationTheme": "system" } } ], "useAcrylicInTabRow": true, ``` This is the result. First tab is inactive, second tab is hovering over, third tab is the active one. Inactive tabs already look nicer now. ![terminal-4](https://user-images.githubusercontent.com/6878281/236599004-5b7748c6-a5e1-4cd5-8556-994bad04d671.png) But the following sentences from the documentation make me doubt the desired result can currently be achieved with themes. > This color is always treated as a solid color, even if set to a terminalBackground of a pane with an acrylic background. > When set to terminalBackground or accent, this will automatically use an alpha value of 30%, to be semi-transparent.
claunia commented 2026-01-31 06:41:19 +00:00
Author
Owner
Copy Link

@Anutrix commented on GitHub (Apr 6, 2024):

Not sure if this should be separate ticket but currently there's no way to set opacity of Tab-Row. Only acrylic blur is possible.
Terminal section itself has both opacity and acrylic settings but tab-row only has Acrylic Blur setting.

image
What if I want this part transparent?
See how I can read words behind terminal but there's block where you can't read anything.
Note that I am not taking about the tab titles but about the tab-row behind it.

@Anutrix commented on GitHub (Apr 6, 2024): Not sure if this should be separate ticket but currently there's no way to set opacity of Tab-Row. Only acrylic blur is possible. Terminal section itself has both opacity and acrylic settings but tab-row only has Acrylic Blur setting. ![image](https://github.com/microsoft/terminal/assets/11459028/a9aab72a-6f08-462e-a529-cdf23624b59f) What if I want this part transparent? See how I can read words behind terminal but there's block where you can't read anything. Note that I am not taking about the tab titles but about the tab-row behind it.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Theming Issue-Feature Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19370
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?