starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Infinite loop in TerminalWindow::OnDirectKeyEvent #19816

New Issue
Closed
opened 2026-01-31 06:54:23 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 06:54:23 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (May 4, 2023).

Windows Terminal version

Commit 97a617a909

Windows build number

10.0.19045.2728

Other Software

No response

Steps to reproduce

  1. Open the Settings page in Windows Terminal.
  2. Click on the button that opens the settings.json file (for me this is associated with Notepad, which might be a factor).
  3. Change some value in the settings.json file and save the changes.
  4. Press Alt+F4 to close the editor, returning the focus back to the Terminal.

Expected Behavior

Focus should be returned to the terminal and not hang.

Actual Behavior

The terminal is frozen, and from the debugger and I can see that it's stuck in an infinite loop in TerminalWindow::OnDirectKeyEvent. Every couple of iterations it finds a focusedObject with a IDirectKeyListener, which calls through to TerminalPage::OnDirectKeyEvent, but the key isn't handled (it appears to be a VK_MENU key), and so the loop doesn't exit. And while it keeps calling focusedElement.Parent() to bubble the event, that doesn't end it either. It eventually gets back to the same focusedObject as before.

I'm not positive that the steps given above will always reproduce the issue, but I get it a lot.

Originally created by @j4james on GitHub (May 4, 2023). ### Windows Terminal version Commit 97a617a909f1dd3664daf3a1764c9a7e8996a1b8 ### Windows build number 10.0.19045.2728 ### Other Software _No response_ ### Steps to reproduce 1. Open the _Settings_ page in Windows Terminal. 2. Click on the button that opens the `settings.json` file (for me this is associated with Notepad, which might be a factor). 3. Change some value in the `settings.json` file and save the changes. 4. Press <kbd>Alt</kbd>+<kbd>F4</kbd> to close the editor, returning the focus back to the Terminal. ### Expected Behavior Focus should be returned to the terminal and not hang. ### Actual Behavior The terminal is frozen, and from the debugger and I can see that it's stuck in an infinite loop in `TerminalWindow::OnDirectKeyEvent`. Every couple of iterations it finds a `focusedObject` with a `IDirectKeyListener`, which calls through to `TerminalPage::OnDirectKeyEvent`, but the key isn't handled (it appears to be a `VK_MENU` key), and so the loop doesn't exit. And while it keeps calling `focusedElement.Parent()` to bubble the event, that doesn't end it either. It eventually gets back to the same `focusedObject` as before. I'm not positive that the steps given above will always reproduce the issue, but I get it a lot.
claunia commented 2026-01-31 06:54:25 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 4, 2023):

Thanks for filing this! This is definitely a real issue that I started something for in #15253. We need to loop back on that and get that fixed.

@zadjii-msft commented on GitHub (May 4, 2023): Thanks for filing this! This is definitely a real issue that I started something for in #15253. We need to loop back on that and get that fixed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface In-PR Issue-Bug Needs-Tag-Fix Product-Terminal Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19816
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?