starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

All nested commands get keybindings (ctrl+t) in command palette? #22151

New Issue
Open
opened 2026-01-31 08:04:51 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 08:04:51 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Aug 23, 2024).

main, ~ e006f75f6

Something is WRONG with all nested commands:

image

You'll note, they seemingly all have ctrl+t as their keychord text.

This doesn't repro for me on 1.22.2334.0

Looking now at my settings to see if there's something sus in there...

Originally created by @zadjii-msft on GitHub (Aug 23, 2024). `main`, ~ e006f75f6 Something is WRONG with all nested commands: ![image](https://github.com/user-attachments/assets/c1e3cbba-c5a4-44e9-80eb-693eb2fb9360) You'll note, they seemingly all have `ctrl+t` as their keychord text. This doesn't repro for me on `1.22.2334.0` Looking now at my settings to see if there's something sus in there...
claunia added the Area-SettingsIssue-BugProduct-TerminalArea-CmdPal labels 2026-01-31 08:04:52 +00:00
claunia commented 2026-01-31 08:04:52 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 23, 2024):

image

Yes this is sus...

I actually have quite a few of these:

        {
            "id": null,
            "keys": "ctrl+t"
        },
        {
            "id": "User.showContextMenu",
            "keys": "ctrl+z"
        },
        {
            "id": "User.scrollToMark.6CD791B",
            "keys": "ctrl+pgdn"
        },
        {
            "id": "User.movePane.6E7070F6",
            "keys": "f3"
        },
        {
            "id": "User.movePane.B137036",
            "keys": "f4"
        },
        {
            "id": "User.closeTab.0",
            "keys": "ctrl+w"
        },
        {
            "id": "User.showSuggestions.807E15EE",
            "keys": "ctrl+shift+h"
        },
        {
            "id": null,
            "keys": "ctrl+shift+comma"
        },
        {
            "id": null,
            "keys": "ctrl+shift+period"
        },
        {
            "id": null,
            "keys": "ctrl+shift+/"
        },
        {
            "id": null,
            "keys": "ctrl+shift+;"
        },

I have no memory of what these were. Alas, sublime doesn't have the undo stack to a state before they were added. If I had to guess, commands that are no longer valid? Like, I bet ctrl+t was tasks (which over the course of time was turned into showSuggestions)

@zadjii-msft commented on GitHub (Aug 23, 2024): ![image](https://github.com/user-attachments/assets/cc049353-b2de-465f-9a28-579bfb1b8a20) Yes this is sus... I actually have quite a few of these: ``` { "id": null, "keys": "ctrl+t" }, { "id": "User.showContextMenu", "keys": "ctrl+z" }, { "id": "User.scrollToMark.6CD791B", "keys": "ctrl+pgdn" }, { "id": "User.movePane.6E7070F6", "keys": "f3" }, { "id": "User.movePane.B137036", "keys": "f4" }, { "id": "User.closeTab.0", "keys": "ctrl+w" }, { "id": "User.showSuggestions.807E15EE", "keys": "ctrl+shift+h" }, { "id": null, "keys": "ctrl+shift+comma" }, { "id": null, "keys": "ctrl+shift+period" }, { "id": null, "keys": "ctrl+shift+/" }, { "id": null, "keys": "ctrl+shift+;" }, ``` I have no memory of what these were. Alas, sublime doesn't have the undo stack to a state before they were added. If I had to guess, commands that are no longer valid? Like, I bet `ctrl+t` was `tasks` (which over the course of time was turned into `showSuggestions`)
claunia commented 2026-01-31 08:04:53 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 23, 2024):

Deleting those fixes it. And adding back a


        {
            "id": null,
            "keys": "ctrl+x"
        },

adds back a ctrl+x label to the cmdpal. I guess we're just handling the logic in here a little wack.

  • We probably shouldn't be assigning a keychord for the "null" command ID to every nested command?
  • Nested commands should have their command labels not on top of the > arrow (s.t. when #10209 is added, this will look right)
@zadjii-msft commented on GitHub (Aug 23, 2024): Deleting those fixes it. And adding back a ```jsonc { "id": null, "keys": "ctrl+x" }, ``` adds back a ctrl+x label to the cmdpal. I guess we're just handling the logic in here a little wack. * We probably shouldn't be assigning a keychord for the "null" command ID to every nested command? * Nested commands should have their command labels not on top of the `>` arrow (s.t. when #10209 is added, this will look right)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CmdPal Area-Settings Issue-Bug Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22151
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?