[PR #2987] [MERGED] When reverse indexing, preserve RGB/256 attributes #25181

Open
opened 2026-01-31 09:07:48 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/2987
Author: @zadjii-msft
Created: 9/30/2019
Status: ✅ Merged
Merged: 10/1/2019
Merged by: @zadjii-msft

Base: master ← Head: dev/migrie/b/2702-fix-256-RI


📝 Commits (1)

📊 Changes

2 files changed (+47 additions, -14 deletions)

View changed files

📝 src/host/getset.cpp (+19 -6)
📝 src/host/ut_host/ScreenBufferTests.cpp (+28 -8)

📄 Description

Summary of the Pull Request

Literally the same thing as #2668, but with RI as well.

References

#2668, #2505, #832

PR Checklist


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/2987 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 9/30/2019 **Status:** ✅ Merged **Merged:** 10/1/2019 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `master` ← **Head:** `dev/migrie/b/2702-fix-256-RI` --- ### 📝 Commits (1) - [`8a2a069`](https://github.com/microsoft/terminal/commit/8a2a06999563e4006979dbcbcc243e2c84266318) Fixes #2702 and adds a test ### 📊 Changes **2 files changed** (+47 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/host/getset.cpp` (+19 -6) 📝 `src/host/ut_host/ScreenBufferTests.cpp` (+28 -8) </details> ### 📄 Description ## Summary of the Pull Request Literally the same thing as #2668, but with RI as well. ## References #2668, #2505, #832 ## PR Checklist * [x] Closes #2702 * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:07:48 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25181