Don't resize the terminal buffer until dragging is released #2987

Open
opened 2026-01-30 23:10:18 +00:00 by claunia · 2 comments
Owner

Originally created by @zadjii-msft on GitHub (Jul 29, 2019).

Add a setting to enable this behavior.

Maybe the user might not want to reflow the buffer in real-time as they resize the window. Maybe they only want to have the resize occur when they finish resizing.

I'd love to see an E2E spec of this scenario before code starts getting written, because I feel it might be a little wonky in certain scenarios. Questions that would be good to be answered:

  • How will we communicate the start of a move/size loop from WindowsTerminal down to the TerminalApp?
  • How will this play with panes that aren't terminals?
  • how do we handle maximize/restore?
  • Should we pause rendering while this is happening? How should this look to the user?

From discussion in #1465

Originally created by @zadjii-msft on GitHub (Jul 29, 2019). Add a _setting_ to enable this behavior. Maybe the user might not want to reflow the buffer in real-time as they resize the window. Maybe they only want to have the resize occur when they _finish_ resizing. I'd love to see an E2E spec of this scenario before code starts getting written, because I feel it might be a little wonky in certain scenarios. Questions that would be good to be answered: * How will we communicate the start of a move/size loop from WindowsTerminal down to the TerminalApp? * How will this play with panes that aren't terminals? * how do we handle maximize/restore? * Should we pause rendering while this is happening? How should this _look_ to the user? From discussion in #1465
claunia added the Issue-FeatureHelp WantedProduct-TerminalArea-UserInterface labels 2026-01-30 23:10:18 +00:00
Author
Owner

@miniksa commented on GitHub (Jul 29, 2019):

I thought this was already handled for us by the operating system in this option:
image

If that's off, the OS shouldn't be telling us the move/size messages until it is released.
If it's on, the OS tells us.

Are we saying that's not enough or that we need to override that further?

@miniksa commented on GitHub (Jul 29, 2019): I thought this was already handled for us by the operating system in this option: ![image](https://user-images.githubusercontent.com/18221333/62078528-abe2f500-b201-11e9-92b0-c05d032dc2cd.png) If that's off, the OS shouldn't be telling us the move/size messages until it is released. If it's on, the OS tells us. Are we saying that's not enough or that we need to override that further?
Author
Owner

@zadjii-msft commented on GitHub (Jul 29, 2019):

Yea I think this is for a more refined feature on top of that. Since conpty does re-rendering on resizes, people might want to only have the terminal actually process the new buffer size at the end of the resize.

@zadjii-msft commented on GitHub (Jul 29, 2019): Yea I think this is for a more refined feature on top of that. Since conpty does re-rendering on resizes, people might want to only have the terminal actually process the new buffer size at the end of the resize.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#2987