starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Updating DoSrvPrivateReverseLineFeed with a direct call to ScrollRegion? #3799

New Issue
Closed
opened 2026-01-30 23:30:25 +00:00 by claunia · 1 comment
claunia commented 2026-01-30 23:30:25 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Sep 9, 2019).

Originally assigned to: @zadjii-msft on GitHub.

Would it not be worthwhile updating DoSrvPrivateReverseLineFeed at the same time, assuming it's just a matter of replacing the ScrollConsoleScreenBufferWImpl call with a direct call to ScrollRegion?

As for the testing, I've added a whole bunch of scrolling tests in PR #2505 which I think could easily be adapted to use 256 colors once this is merged. Although that PR is going to need to be rebased and updated first.

Originally posted by @j4james in https://github.com/microsoft/terminal/pull/2668#issuecomment-528646590

We should also make sure to add some tests for this case as well. I'll do it as a separate PR to make sure we get each one in correctly.

Originally created by @zadjii-msft on GitHub (Sep 9, 2019). Originally assigned to: @zadjii-msft on GitHub. Would it not be worthwhile updating `DoSrvPrivateReverseLineFeed` at the same time, assuming it's just a matter of replacing the `ScrollConsoleScreenBufferWImpl` call with a direct call to `ScrollRegion`? As for the testing, I've added a whole bunch of scrolling tests in PR #2505 which I think could easily be adapted to use 256 colors once this is merged. Although that PR is going to need to be rebased and updated first. _Originally posted by @j4james in https://github.com/microsoft/terminal/pull/2668#issuecomment-528646590_ <hr> We should also make sure to add some tests for this case as well. I'll do it as a separate PR to make sure we get each one in correctly.
claunia commented 2026-01-30 23:30:26 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 4, 2019):

:tada:This issue was addressed in #2987, which has now been successfully released as Windows Terminal Preview v0.5.2762.0.🎉

Handy links:

@ghost commented on GitHub (Oct 4, 2019): :tada:This issue was addressed in #2987, which has now been successfully released as `Windows Terminal Preview v0.5.2762.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.5.2762.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-VT Issue-Bug Priority-2 Product-Conhost Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#3799
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?