starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

SFX Command Binding #8346

New Issue
Closed
opened 2026-01-31 01:27:04 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 01:27:04 +00:00
Owner
Copy Link

Originally created by @timmkrause on GitHub (May 20, 2020).

Description of the new feature/enhancement

To improve gamification and making the use of (the) terminal(s) even more engaging, I'd like to propose a "SFX Command Binding" feature.

For me, it started with this tweet: https://twitter.com/timmkrause/status/1263009434231549952

A colleague wrote "Wait, I still need to push it." and I wrote back "You should play https://www.youtube.com/watch?v=vCadcBR95oU while pushing." and while writing I just thought how cool would it be, to let a small piece of audio be played when git push is being executed.

This should be configurable in a dynamic manner of course.

Maybe something like this:

{
    "profiles": [
      {
        "guid": "{guid}",
        "name": "PowerShell Core",
        "source": "Windows.Terminal.PowershellCore",
        "fontFace": "Cascadia Code PL",
        "sfxCommandBindings": [
            { "command": "git push", "soundEffect": "ms-appdata:///roaming/salt-n-pepa-push-it-short.mp3" }
        ]
      }
    ]
}

What do you think?? :)

Originally created by @timmkrause on GitHub (May 20, 2020). # Description of the new feature/enhancement To improve gamification and making the use of (the) terminal(s) even more engaging, I'd like to propose a "SFX Command Binding" feature. For me, it started with this tweet: https://twitter.com/timmkrause/status/1263009434231549952 A colleague wrote "Wait, I still need to push it." and I wrote back "You should play https://www.youtube.com/watch?v=vCadcBR95oU while pushing." and while writing I just thought how cool would it be, to let a small piece of audio be played when `git push` is being executed. This should be configurable in a dynamic manner of course. Maybe something like this: ``` { "profiles": [ { "guid": "{guid}", "name": "PowerShell Core", "source": "Windows.Terminal.PowershellCore", "fontFace": "Cascadia Code PL", "sfxCommandBindings": [ { "command": "git push", "soundEffect": "ms-appdata:///roaming/salt-n-pepa-push-it-short.mp3" } ] } ] } ``` What do you think?? :)
claunia commented 2026-01-31 01:27:05 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (May 20, 2020):

Architecturally, the actual text/command that is being run is the shell's job, not the terminal. So, we wouldn't be able to introduce something like "command": "git push".

That said, a workaround we've been thinking of is #3799. You can think of this like "paste X text" and define X in the keybinding for the settings.

This could be an extension to that, and I do love the thought of audio clips when I do a git push haha.

@carlos-zamora commented on GitHub (May 20, 2020): Architecturally, the actual text/command that is being run is the shell's job, not the terminal. So, we wouldn't be able to introduce something like `"command": "git push"`. That said, a workaround we've been thinking of is #3799. You can think of this like "paste X text" and define X in the keybinding for the settings. This _could_ be an extension to that, and I do _love_ the thought of audio clips when I do a git push haha.
claunia commented 2026-01-31 01:27:06 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 10, 2020):

Thanks for the request!

Thinking about this more... I believe it would be best if the CLI application itself handled playing sounds. Here's why!

First, the terminal can't actually tell that you've run a command. When you type in "git push", all the terminal sees is g i t space p u s h coming off the keyboard. Now, that might be enough to conclusively identify that you're doing a git push, but you could also be using vim and running g (go to, nowhere), i (insert), t push ... Only the shell knows what those characters mean!

Second, if you write a script that runs git push and then plays a sound, you get a lot more control! Imagine you wanted to play a different sound if the push failed. Terminal has no way of knowing 😄 but your script absolutely does.

@DHowett commented on GitHub (Jun 10, 2020): Thanks for the request! Thinking about this more... I believe it would be best if the CLI application itself handled playing sounds. Here's why! First, the terminal can't actually tell that you've run a command. When you type in "git push", all the terminal sees is `g` `i` `t` `space` `p` `u` `s` `h` coming off the keyboard. Now, that might be enough to conclusively identify that you're doing a `git push`, but you could also be using vim and running `g` (go to, nowhere), `i` (insert), `t push` ... Only the shell knows what those characters mean! Second, if you write a script that runs `git push` and then plays a sound, you get a lot more control! Imagine you wanted to play a different sound if the push _failed_. Terminal has no way of knowing :smile: but your script absolutely does.
claunia commented 2026-01-31 01:27:06 +00:00
Author
Owner
Copy Link

@timmkrause commented on GitHub (Jun 10, 2020):

Sounds reasonable. Do you know a „global hook“ for PS Core to realize this?

@timmkrause commented on GitHub (Jun 10, 2020): Sounds reasonable. Do you know a „global hook“ for PS Core to realize this?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Extensibility Issue-Feature Needs-Triage Product-Terminal Resolution-Won't-Fix
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#8346
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?