[PR #3262] [MERGED] Break if an early exit can not be found in InsertAttrRuns #25288

Open
opened 2026-01-31 09:08:32 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3262
Author: @skyline75489
Created: 10/20/2019
Status: ✅ Merged
Merged: 11/4/2019
Merged by: @miniksa

Base: master ← Head: fix/insertRunPerf-2


📝 Commits (1)

  • 8d46025 Break if an early exit can not be found in InsertAttrRuns

📊 Changes

1 file changed (+7 additions, -0 deletions)

View changed files

📝 src/buffer/out/AttrRow.cpp (+7 -0)

📄 Description

Summary of the Pull Request

A follow-up of #2937

References

#2937

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3262 **Author:** [@skyline75489](https://github.com/skyline75489) **Created:** 10/20/2019 **Status:** ✅ Merged **Merged:** 11/4/2019 **Merged by:** [@miniksa](https://github.com/miniksa) **Base:** `master` ← **Head:** `fix/insertRunPerf-2` --- ### 📝 Commits (1) - [`8d46025`](https://github.com/microsoft/terminal/commit/8d4602506ef173f2fe528ab3ca7675dd9d899f61) Break if an early exit can not be found in InsertAttrRuns ### 📊 Changes **1 file changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/buffer/out/AttrRow.cpp` (+7 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request A follow-up of #2937 <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References #2937 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #xxx * [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:08:32 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25288