starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-05-06 20:34:29 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

When a dialog is open, the titlebar is the wrong color #2937

New Issue
Closed
opened 2026-01-30 23:09:14 +00:00 by claunia · 3 comments
claunia commented 2026-01-30 23:09:14 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Jul 25, 2019).

Originally assigned to: @DHowett-MSFT on GitHub.

related to #1625.

image

This one's tricky - the Background of the TabRow doesn't actually change here, it's just being combined with the overlay of the ContentDialog. We'd have to compose that color ourselves in the NonClientWindow class.

Originally created by @zadjii-msft on GitHub (Jul 25, 2019). Originally assigned to: @DHowett-MSFT on GitHub. related to #1625. ![image](https://user-images.githubusercontent.com/18356694/61895322-04e81b80-aed8-11e9-8ecc-ce908f185e69.png) This one's tricky - the Background of the TabRow doesn't actually change here, it's just being combined with the overlay of the ContentDialog. We'd have to compose that color ourselves in the NonClientWindow class.
claunia commented 2026-01-30 23:09:15 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jul 25, 2019):

Alternatively, we may want to disable the cutout when a dialog is up.

@DHowett-MSFT commented on GitHub (Jul 25, 2019): Alternatively, we may want to disable the cutout when a dialog is up.
claunia commented 2026-01-30 23:09:15 +00:00
Author
Owner
Copy Link

@beviu commented on GitHub (Feb 18, 2020):

I have an idea. Would it be possible to replace the SetWindowRgn trickery by a completely transparent, invisible window that we put on top of the drag bar and that catches all of the mouse events? If this works then it means that the XAML can draw its own drag bar so this bug goes away and also it will allow for acrylic title bar.

I got this idea by using looking at the Settings UWP app's window using a tool called Spy++.
It looks like it does something similar to this (but not exactly this because the window's size is not exactly the same as the title bar's size) with a window called ApplicationFrameInputSinkWindow that only receive messages when I put my mouse on the drag bar:
image

I don't know if that would work but I might try to do it when I have free time. EDIT: I probably won't do it because I don't have free time but I'm leaving the idea here. Maybe it could be interesting.

@beviu commented on GitHub (Feb 18, 2020): I have an idea. Would it be possible to replace the `SetWindowRgn` trickery by a completely transparent, invisible window that we put on top of the drag bar and that catches all of the mouse events? If this works then it means that the XAML can draw its own drag bar so this bug goes away and also it will allow for acrylic title bar. I got this idea by using looking at the Settings UWP app's window using a tool called Spy++. It looks like it does something similar to this (but not exactly this because the window's size is not exactly the same as the title bar's size) with a window called `ApplicationFrameInputSinkWindow` that only receive messages when I put my mouse on the drag bar: ![image](https://user-images.githubusercontent.com/56923875/74767398-15eae680-5287-11ea-9440-1e8725b86684.png) I don't know if that would work but I might try to do it when I have free time. **EDIT:** I probably won't do it because I don't have free time but I'm leaving the idea here. Maybe it could be interesting.
claunia commented 2026-01-30 23:09:15 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 5, 2020):

:tada:This issue was addressed in #5485, which has now been successfully released as Windows Terminal Release Candidate v0.11.1251.0 (1.0rc1).🎉

Handy links:

@ghost commented on GitHub (May 5, 2020): :tada:This issue was addressed in #5485, which has now been successfully released as `Windows Terminal Release Candidate v0.11.1251.0 (1.0rc1)`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.11.1251.0 (1.0rc1)) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Needs-Tag-Fix Priority-2 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#2937
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?