[PR #3530] [MERGED] Add "format : color" to Profiles Schema color items #25410

Open
opened 2026-01-31 09:09:20 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3530
Author: @TheBrain0110
Created: 11/12/2019
Status: ✅ Merged
Merged: 11/20/2019
Merged by: @carlos-zamora

Base: master ← Head: master


📝 Commits (1)

  • 5894a3a Add "format : color" to Schema color items

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+2 -1)

📄 Description

Summary of the Pull Request

A simple one-liner addition to profiles.schema.json.

Enables VSCode to recognize Color-type entries in profiles.json and show a color decorator in the editor.

"format" : "color" is a nonstandard, VSCode-specific extension to the schema format, but it shouldn't hurt validation for this case.

PR Checklist

  • Closes Cannot launch Store version, but Dev Build works fine (#3287)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed

Tested manually.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3530 **Author:** [@TheBrain0110](https://github.com/TheBrain0110) **Created:** 11/12/2019 **Status:** ✅ Merged **Merged:** 11/20/2019 **Merged by:** [@carlos-zamora](https://github.com/carlos-zamora) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`5894a3a`](https://github.com/microsoft/terminal/commit/5894a3a166e80873652cc4a62ad0c7d74ad27fd0) Add "format : color" to Schema color items ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+2 -1) </details> ### 📄 Description ## Summary of the Pull Request A simple one-liner addition to `profiles.schema.json`. Enables VSCode to recognize Color-type entries in `profiles.json` and show a color decorator in the editor. `"format" : "color"` is a nonstandard, VSCode-specific extension to the schema format, but it shouldn't hurt validation for this case. ## PR Checklist - [ ] Closes #3287 - [x] CLA signed. If not, go over here and sign the CLA - [ ] Tests added/passed - [ ] Requires documentation to be updated - [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx ## Validation Steps Performed Tested manually. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:09:20 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25410