[PR #4648] [MERGED] Migrate the ConPTY functional tests out of Windows #25863

Open
opened 2026-01-31 09:12:18 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4648
Author: @DHowett-MSFT
Created: 2/19/2020
Status: ✅ Merged
Merged: 2/19/2020
Merged by: @DHowett-MSFT

Base: master ← Head: dev/duhowett/ft_pty


📝 Commits (2)

  • 718e080 conpty: add feature tests from windows
  • 70f4bf9 and make them build

📊 Changes

5 files changed (+528 additions, -0 deletions)

View changed files

📝 OpenConsole.sln (+17 -0)
➕ src/winconpty/ft_pty/ConPtyTests.cpp (+456 -0)
➕ src/winconpty/ft_pty/precomp.cpp (+4 -0)
➕ src/winconpty/ft_pty/precomp.h (+12 -0)
➕ src/winconpty/ft_pty/winconpty.FeatureTests.vcxproj (+39 -0)

📄 Description

Summary of the Pull Request

This will allow us to run the ConPTY tests in CI.

PR Checklist

  • Closes MSFT:24265197, Closes #3851
  • I've discussed this with core contributors already.

Validation Steps Performed

I've run the tests.

Please note: this code is unchanged (apart from wil::ScopeExit -> wil::scope_exit) from Windows. Now is not the time to comment on their perfectness.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4648 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 2/19/2020 **Status:** ✅ Merged **Merged:** 2/19/2020 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/duhowett/ft_pty` --- ### 📝 Commits (2) - [`718e080`](https://github.com/microsoft/terminal/commit/718e080d8d55c6be8b11b2ae0cdb9464ee506fa3) conpty: add feature tests from windows - [`70f4bf9`](https://github.com/microsoft/terminal/commit/70f4bf918bdde76f669d21263e71cbdef7a003df) and make them build ### 📊 Changes **5 files changed** (+528 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `OpenConsole.sln` (+17 -0) ➕ `src/winconpty/ft_pty/ConPtyTests.cpp` (+456 -0) ➕ `src/winconpty/ft_pty/precomp.cpp` (+4 -0) ➕ `src/winconpty/ft_pty/precomp.h` (+12 -0) ➕ `src/winconpty/ft_pty/winconpty.FeatureTests.vcxproj` (+39 -0) </details> ### 📄 Description ## Summary of the Pull Request This will allow us to run the ConPTY tests in CI. ## PR Checklist * [x] Closes MSFT:24265197, Closes #3851 * [X] I've discussed this with core contributors already. ## Validation Steps Performed I've run the tests. Please note: this code is unchanged (apart from `wil::ScopeExit` -> `wil::scope_exit`) from Windows. Now is not the time to comment on their perfectness. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:12:18 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25863