starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

_tabView.Items() and _tabs should not need to be kept in sync manually #3851

New Issue
Closed
opened 2026-01-30 23:31:36 +00:00 by claunia · 2 comments
claunia commented 2026-01-30 23:31:36 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Sep 12, 2019).

Originally assigned to: @leonMSFT on GitHub.

Right now in TerminalPage, we have two separate vectors of "tabs" that need to be kept in sync:

  1. Our own vector<shared_ptr<Tab>> _tabs
  2. The vector owned by _tabView of all the TabViewItems.

This is kinda silly, we should probably just use the _tabView.Items() vector, and more closely associate the Tab with them.

Case in point is TerminalPage::_RemoveTabViewItem, where we need to both remove the tab from both the tabs and the tabView.Items().

We could probably make tabs an observable vector or something, so the tabview is inherently tied to the tabs collection. I did a bit of similar prototyping in the command palette prototype, see #2046 for that branch.

Originally created by @zadjii-msft on GitHub (Sep 12, 2019). Originally assigned to: @leonMSFT on GitHub. Right now in TerminalPage, we have two separate vectors of "tabs" that need to be kept in sync: 1. Our own `vector<shared_ptr<Tab>> _tabs` 2. The vector owned by `_tabView` of all the `TabViewItem`s. This is kinda silly, we should probably just use the `_tabView.Items()` vector, and more closely associate the `Tab` with them. Case in point is `TerminalPage::_RemoveTabViewItem`, where we need to both remove the tab from both the tabs and the tabView.Items(). We could probably make tabs an observable vector or something, so the tabview is inherently tied to the tabs collection. I did a bit of similar prototyping in the command palette prototype, see #2046 for that branch.
claunia added the Issue-TaskNeeds-Tag-FixProduct-TerminalArea-CodeHealth labels 2026-01-30 23:31:36 +00:00
claunia commented 2026-01-30 23:31:37 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Sep 14, 2019):

yes please! If we make Tab a WinRT runtime class or something, we can probably even use it as the TabView Item.

@DHowett-MSFT commented on GitHub (Sep 14, 2019): _yes please_! If we make Tab a WinRT runtime class or something, we can probably even use it _as_ the TabView Item.
claunia commented 2026-01-30 23:31:37 +00:00
Author
Owner
Copy Link

@leonMSFT commented on GitHub (Jun 22, 2020):

Closing because we actually need access to the TabViewItem to perform some of our custom modifications like tab color and tab title boxes (and maybe future modifications), and so letting us have total control of our TabViewItems is needed, so this in fact is the way

@leonMSFT commented on GitHub (Jun 22, 2020): Closing because we actually need access to the TabViewItem to perform some of our custom modifications like tab color and tab title boxes (and maybe future modifications), and so letting us have total control of our TabViewItems is needed, so this in fact is the way
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Issue-Task Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#3851
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?