starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Profile::Set...(std::wstring param) not using std::move #2590

New Issue
Closed
opened 2026-01-30 22:59:09 +00:00 by claunia · 6 comments
claunia commented 2026-01-30 22:59:09 +00:00
Owner
Copy Link

Originally created by @yves-dolce on GitHub (Jul 5, 2019).

Let me start by saying I did not read the whole source so I might have missed important details.

I was looking at the source code to understand how you're handling the commandline setting and saw that many methods in the Profile class do not move the instance of the std::wstring received and instead create a copy.

Also, why do you mark the methods noexcept when some strings might not be small enough to allow SSO? (e.g. a long command line)

Proposed technical implementation details (optional)

void Profile::SetCommandline(std::wstring cmdline) noexcept
{
    _commandline = std::move(cmdline);
}
Originally created by @yves-dolce on GitHub (Jul 5, 2019). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> Let me start by saying I did not read the whole source so I might have missed important details. I was looking at the source code to understand how you're handling the `commandline` setting and saw that many methods in the `Profile` class do not move the instance of the `std::wstring` received and instead create a copy. Also, why do you mark the methods `noexcept` when some strings might not be small enough to allow SSO? (e.g. a long command line) <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> # Proposed technical implementation details (optional) ``` void Profile::SetCommandline(std::wstring cmdline) noexcept { _commandline = std::move(cmdline); } ``` <!-- A clear and concise description of what you want to happen. -->
claunia commented 2026-01-30 22:59:10 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 8, 2019):

I'm sure that no one really thought too hard about it - seems like that would work to me.

I'm not sure I know why they're marked noexcept. I bet that we assumed that all the setters in Profile were just simple setters that couldn't possibly throw.

@zadjii-msft commented on GitHub (Jul 8, 2019): I'm sure that no one really thought too hard about it - seems like that would work to me. I'm not sure I know why they're marked noexcept. I bet that we assumed that all the setters in `Profile` were just simple setters that couldn't possibly throw.
claunia commented 2026-01-30 22:59:10 +00:00
Author
Owner
Copy Link

@yves-dolce commented on GitHub (Jul 8, 2019):

If I'm confident you'll take the PR, I can spend time forking and submitting a PR. Just tell me.

@yves-dolce commented on GitHub (Jul 8, 2019): If I'm confident you'll take the PR, I can spend time forking and submitting a PR. Just tell me.
claunia commented 2026-01-30 22:59:10 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jul 8, 2019):

We would definitely take any PR that makes our code better. Thanks 😄

@DHowett-MSFT commented on GitHub (Jul 8, 2019): We would definitely take any PR that makes our code better. Thanks :smile:
claunia commented 2026-01-30 22:59:11 +00:00
Author
Owner
Copy Link

@yves-dolce commented on GitHub (Jul 9, 2019):

OK. So I'm ready to submit it but when I follow the README.MD and call testcon, it ends with:

Summary of TAEF Warnings:
    Warning: TAEF: The test file "......\terminal.fork\bin\x64\Debug\ConHost.Api.Tests.dll" does not exist.
    Warning: TAEF: The test file "file ......\terminal.fork\bin\x64\Debug\ConHost.Resize.Tests.dll" does not exist.
    Warning: TAEF: The test file "file ......\terminal.fork\bin\x64\Debug\ConHost.CJK.Tests.dll" does not exist.

Summary of Non-passing Tests:
    ClipboardTests::CanConvertCharsOutsideKeyboardLayout [Failed]

Summary: Total=1054, Passed=1053, Failed=1, Blocked=0, Not Run=0, Skipped=0

Is this a known issue of the UT?

@yves-dolce commented on GitHub (Jul 9, 2019): OK. So I'm ready to submit it but when I follow the README.MD and call testcon, it ends with: ``` Summary of TAEF Warnings: Warning: TAEF: The test file "......\terminal.fork\bin\x64\Debug\ConHost.Api.Tests.dll" does not exist. Warning: TAEF: The test file "file ......\terminal.fork\bin\x64\Debug\ConHost.Resize.Tests.dll" does not exist. Warning: TAEF: The test file "file ......\terminal.fork\bin\x64\Debug\ConHost.CJK.Tests.dll" does not exist. Summary of Non-passing Tests: ClipboardTests::CanConvertCharsOutsideKeyboardLayout [Failed] Summary: Total=1054, Passed=1053, Failed=1, Blocked=0, Not Run=0, Skipped=0 ``` Is this a known issue of the UT?
claunia commented 2026-01-30 22:59:11 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jul 10, 2019):

I believe so. The UTs might not work if your system codepage is not 1252 😄

@DHowett-MSFT commented on GitHub (Jul 10, 2019): I believe so. The UTs might not work if your system codepage is not 1252 :smile:
claunia commented 2026-01-30 22:59:11 +00:00
Author
Owner
Copy Link

@yves-dolce commented on GitHub (Jul 10, 2019):

Just submitted my first ever Open Source PR #1899 ...

@yves-dolce commented on GitHub (Jul 10, 2019): Just submitted my first ever Open Source PR #1899 ...
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Help Wanted Issue-Task Needs-Tag-Fix Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#2590
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?