starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Every copyOnSelect action crashes the Terminal now #3850

New Issue
Closed
opened 2026-01-30 23:31:31 +00:00 by claunia · 7 comments
claunia commented 2026-01-30 23:31:31 +00:00
Owner
Copy Link

Originally created by @JDQuackers on GitHub (Sep 12, 2019).

Originally assigned to: @carlos-zamora on GitHub.

Environment

Windows build number: Win32NT     10.0.18362.0     Microsoft Windows NT 10.0.18362.0

Windows Terminal version (if applicable): 0.4.2382.0  (installed via Microsoft Store, profiles.json attached)

[profiles.txt](https://github.com/microsoft/terminal/files/3607091/profiles.txt)

Steps to reproduce

With the latest version of Windows Terminal, using the attached profiles.json file with copyOnSelect = True, every time I copy text the Terminal will hang for 1-2 seconds and then crash. After the most recent update to 0.4.2382.0, I enabled copyOnSelect and only saw this crash maybe once a day. Since yesterday (9/11), it happens every time I copy text. No settings changes happened, but I do heavily use the Terminal every day with lots of copy/pasting, so as of yesterday my workflow is severely interrupted

Expected behavior

copyOnSelect adds the selected text to clipboard, and Terminal continues to operate as intended

Actual behavior

As soon as the selection period is over, the Terminal hangs for 1-2 seconds with a spinning cursor, then crashes. No text is copied to the clipboard

Also, here is the Feedback Hub posting: https://aka.ms/AA627yk

Originally created by @JDQuackers on GitHub (Sep 12, 2019). Originally assigned to: @carlos-zamora on GitHub. # Environment ```none Windows build number: Win32NT 10.0.18362.0 Microsoft Windows NT 10.0.18362.0 Windows Terminal version (if applicable): 0.4.2382.0 (installed via Microsoft Store, profiles.json attached) [profiles.txt](https://github.com/microsoft/terminal/files/3607091/profiles.txt) ``` # Steps to reproduce With the latest version of Windows Terminal, using the attached `profiles.json` file with `copyOnSelect = True`, every time I copy text the Terminal will hang for 1-2 seconds and then crash. After the most recent update to 0.4.2382.0, I enabled `copyOnSelect` and only saw this crash maybe once a day. Since yesterday (9/11), it happens every time I copy text. No settings changes happened, but I do heavily use the Terminal every day with lots of copy/pasting, so as of yesterday my workflow is severely interrupted # Expected behavior copyOnSelect adds the selected text to clipboard, and Terminal continues to operate as intended # Actual behavior As soon as the selection period is over, the Terminal hangs for 1-2 seconds with a spinning cursor, then crashes. No text is copied to the clipboard **Also, here is the Feedback Hub posting:** https://aka.ms/AA627yk
claunia commented 2026-01-30 23:31:32 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 12, 2019):

@carlos-zamora Do we have a dupe for this one? Presumably this is different than the last copy->crash bug

@zadjii-msft commented on GitHub (Sep 12, 2019): @carlos-zamora Do we have a dupe for this one? Presumably this is different than the last copy->crash bug
claunia commented 2026-01-30 23:31:33 +00:00
Author
Owner
Copy Link

@JDQuackers commented on GitHub (Sep 12, 2019):

Accidentally attached the file within the code block so it didn't attach correctly. Here is with a .txt extension to make Github happy:

profiles.txt

@JDQuackers commented on GitHub (Sep 12, 2019): Accidentally attached the file within the code block so it didn't attach correctly. Here is with a .txt extension to make Github happy: [profiles.txt](https://github.com/microsoft/terminal/files/3607094/profiles.txt)
claunia commented 2026-01-30 23:31:33 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Sep 12, 2019):

@carlos-zamora Carlos Zamora FTE Do we have a dupe for this one? Presumably this is different than the last copy->crash bug

I don't see a dup for this. But this came after the copy->crash bugfix. So, potentially related?

@carlos-zamora commented on GitHub (Sep 12, 2019): > @carlos-zamora Carlos Zamora FTE Do we have a dupe for this one? Presumably this is different than the last copy->crash bug I don't see a dup for this. But this came after the copy->crash bugfix. So, potentially related?
claunia commented 2026-01-30 23:31:33 +00:00
Author
Owner
Copy Link

@spatiebot commented on GitHub (Sep 13, 2019):

I can confirm this bug.

@spatiebot commented on GitHub (Sep 13, 2019): I can confirm this bug.
claunia commented 2026-01-30 23:31:33 +00:00
Author
Owner
Copy Link

@mcpiroman commented on GitHub (Sep 16, 2019):

Does this happen when you disable copyOnSelect and copy things manually (with right click or shift+ctrl+c or whatever)? It also crashes to me but regardless of copyOnSelect.

In particular, changing this line to catch(...) { } stopped the crash for me:
125e1771ae/src/cascadia/TerminalApp/TerminalPage.cpp (L1025)

@mcpiroman commented on GitHub (Sep 16, 2019): Does this happen when you disable `copyOnSelect` and copy things manually (with right click or `shift+ctrl+c` or whatever)? It also crashes to me but regardless of `copyOnSelect`. In particular, changing this line to `catch(...) { }` stopped the crash for me: https://github.com/microsoft/terminal/blob/125e1771aed0a7b4e516e7fba1934c78f18c749b/src/cascadia/TerminalApp/TerminalPage.cpp#L1025
claunia commented 2026-01-30 23:31:33 +00:00
Author
Owner
Copy Link

@JDQuackers commented on GitHub (Sep 16, 2019):

Does this happen when you disable copyOnSelect and copy things manually (with right click or shift+ctrl+c or whatever)?

So, interestingly, this problem is no longer happening. Just to try this manual copy, I toggled the setting to false, and confirmed that I could copy manually without crash. Then I re-enabled the setting to true, and can still perform copyOnSelect without crash. This is bizarre. The behavior lasted from 9/11 until 9/14.

Since opening the bug and seeing the behavior go away, I know I rebooted the machine, but otherwise no updates or settings changes occurred. Maybe it is related to having extensive uptime of the machine with many, many Windows Terminal sessions open over an extended period of time. I typically open 2 or 3 Terminal windows throughout the day with 3-4 tabs open, and leave them open for many hours during the day. The uptime of my machine is on average about 15 days. In case any of that is useful information.

Since the problem went away for me, should I close this Issue?

@JDQuackers commented on GitHub (Sep 16, 2019): > Does this happen when you disable `copyOnSelect` and copy things manually (with right click or `shift+ctrl+c` or whatever)? So, interestingly, this problem is no longer happening. Just to try this manual copy, I toggled the setting to `false`, and confirmed that I could copy manually without crash. Then I re-enabled the setting to `true`, and can still perform copyOnSelect without crash. This is bizarre. The behavior lasted from 9/11 until 9/14. Since opening the bug and seeing the behavior go away, I know I rebooted the machine, but otherwise no updates or settings changes occurred. Maybe it is related to having extensive uptime of the machine with _many, many_ Windows Terminal sessions open over an extended period of time. I typically open 2 or 3 Terminal windows throughout the day with 3-4 tabs open, and leave them open for many hours during the day. The uptime of my machine is on average about 15 days. In case any of that is useful information. Since the problem went away for me, should I close this Issue?
claunia commented 2026-01-30 23:31:34 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Sep 16, 2019):

Aha! So it sounds like this is actually a dup of #2685. Sometimes, the clipboard isn't available (why?, idk), but that definitely would get fixed by a reboot. This issue should be fixed with PR #2590.

Closing as dup. Code change is in master, if you care to use it. Otherwise, this will definitely be in the next update :) Thanks!

@carlos-zamora commented on GitHub (Sep 16, 2019): Aha! So it sounds like this is actually a dup of #2685. Sometimes, the clipboard isn't available (why?, idk), but that definitely would get fixed by a reboot. This issue should be fixed with PR #2590. Closing as dup. Code change is in master, if you care to use it. Otherwise, this will definitely be in the next update :) Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Issue-Bug Needs-Tag-Fix Product-Terminal Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#3850
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?