starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #4729] [MERGED] Convert TermControl to .xaml #25914

New Issue
Open
opened 2026-01-31 09:12:36 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:12:36 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4729
Author: @DHowett-MSFT
Created: 2/26/2020
Status: ✅ Merged
Merged: 2/27/2020
Merged by: @DHowett-MSFT

Base: master ← Head: dev/duhowett/xaml_all_the_thangs

📝 Commits (3)

  • 22a8ce0 Convert TermControl to a XAML file
  • 1cd20f8 TermControl: Background doesn't work on UserControls...
  • 89464a0 Revisit comment in TCon

📊 Changes

4 files changed (+198 additions, -249 deletions)

View changed files

📝 src/cascadia/TerminalControl/TermControl.cpp (+104 -228)
📝 src/cascadia/TerminalControl/TermControl.h (+5 -18)
➕ src/cascadia/TerminalControl/TermControl.xaml (+81 -0)
📝 src/cascadia/TerminalControl/TerminalControl.vcxproj (+8 -3)

📄 Description

This commit removes all of the custom UI initialization code in
TermControl and replaces it with a xaml file. Some dead or reundant code
was removed as part of this refactoring.

It also fixes two (quasi-related) issues:

  • The search box, on first launch, was offset by the scrollbar even if
    the scrollbar was invisible.
  • The scrollbar state wasn't hot-reloadable.

PR Checklist

  • Closes [a thing that's been hounding me since the beginning, but no real issue]

Validation Steps Performed

Launched, opened, closed, searched and TSF-inputted-into controls.

Fixes #4920

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4729 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 2/26/2020 **Status:** ✅ Merged **Merged:** 2/27/2020 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/duhowett/xaml_all_the_thangs` --- ### 📝 Commits (3) - [`22a8ce0`](https://github.com/microsoft/terminal/commit/22a8ce0bc3c2c5629883aba6eecf439e408f46d7) Convert TermControl to a XAML file - [`1cd20f8`](https://github.com/microsoft/terminal/commit/1cd20f8e5e03d2b628a5547ac1583df6de40f8ef) TermControl: Background doesn't work on UserControls... - [`89464a0`](https://github.com/microsoft/terminal/commit/89464a04af0cd8dfb35c73ef30f20acde068726a) Revisit comment in TCon ### 📊 Changes **4 files changed** (+198 additions, -249 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+104 -228) 📝 `src/cascadia/TerminalControl/TermControl.h` (+5 -18) ➕ `src/cascadia/TerminalControl/TermControl.xaml` (+81 -0) 📝 `src/cascadia/TerminalControl/TerminalControl.vcxproj` (+8 -3) </details> ### 📄 Description This commit removes all of the custom UI initialization code in TermControl and replaces it with a xaml file. Some dead or reundant code was removed as part of this refactoring. It also fixes two (quasi-related) issues: * The search box, on first launch, was offset by the scrollbar even if the scrollbar was invisible. * The scrollbar state wasn't hot-reloadable. ## PR Checklist * [ ] Closes [a thing that's been hounding me since the beginning, but no real issue] ## Validation Steps Performed Launched, opened, closed, searched and TSF-inputted-into controls. Fixes #4920 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:12:36 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25914
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?