starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-05-06 20:34:29 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

"Close all tabs?" dialog should highlight the "default" option #4729

New Issue
Closed
opened 2026-01-30 23:55:09 +00:00 by claunia · 6 comments
claunia commented 2026-01-30 23:55:09 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Oct 30, 2019).

refer to screenshot:

image

Pressing enter here closes the window, because that's the focused/default button on this dialog. However, there's no way of knowing which is the selected button right now. We should either use the accent color with the button, or manually display the focus rect (is that even possible)?

Also for discussion: Should "close" be the default option here?

Originally created by @zadjii-msft on GitHub (Oct 30, 2019). refer to screenshot: ![image](https://user-images.githubusercontent.com/18356694/67896977-7238c780-fb2b-11e9-8899-f232d649e234.png) Pressing enter here _closes the window_, because that's the focused/default button on this dialog. However, there's no way of knowing which is the selected button right now. We should either use the accent color with the button, or manually display the focus rect (is that even possible)? Also for discussion: Should "close" be the default option here?
claunia commented 2026-01-30 23:55:10 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 30, 2019):

Gut feeling: cancel should be the default option.

@DHowett-MSFT commented on GitHub (Oct 30, 2019): Gut feeling: cancel should be the default option.
claunia commented 2026-01-30 23:55:11 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Nov 2, 2019):

Classic Edge:
image

Pressing Enter does trigger "Close all". Surprisingly, they don't make it clear that that's the default button here. We definitely should though.

On a separate note, consider adding that checkbox? (that should definitely be it's own issue though)

@carlos-zamora commented on GitHub (Nov 2, 2019): Classic Edge: ![image](https://user-images.githubusercontent.com/11050425/68063455-5c173c80-fcce-11e9-9d1a-ba5c9e3c0d38.png) Pressing Enter does trigger "Close all". Surprisingly, they don't make it clear that that's the default button here. We definitely should though. On a separate note, consider adding that checkbox? (that should definitely be it's own issue though)
claunia commented 2026-01-30 23:55:11 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (Nov 2, 2019):

You could use the Accented Button style for the default option

@mdtauk commented on GitHub (Nov 2, 2019): You could use the Accented Button style for the default option
claunia commented 2026-01-30 23:55:11 +00:00
Author
Owner
Copy Link

@jantari commented on GitHub (Nov 3, 2019):

My opinion is that you should use the focus rectangle.

When you only have two buttons and they are different colors it is still not clear which one is active.

@jantari commented on GitHub (Nov 3, 2019): My opinion is that you should use the focus rectangle. When you only have two buttons and they are different colors it is still not clear which one is active.
claunia commented 2026-01-30 23:55:11 +00:00
Author
Owner
Copy Link

@cinnamon-msft commented on GitHub (Jan 22, 2020):

Along with this issue, the styling should be fixed as well to match the other dialog boxes.
Mockup proposal:
image

In terms of what should be default, I'd argue if we have the checkbox for "don't show this again", it should be Cancel. Otherwise, Close All Tabs should be default.

@cinnamon-msft commented on GitHub (Jan 22, 2020): Along with this issue, the styling should be fixed as well to match the other dialog boxes. Mockup proposal: ![image](https://user-images.githubusercontent.com/48369326/72943040-df728800-3d29-11ea-8f49-ad4bae3f105b.png) In terms of what should be default, I'd argue if we have the checkbox for "don't show this again", it should be Cancel. Otherwise, Close All Tabs should be default.
claunia commented 2026-01-30 23:55:11 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Feb 13, 2020):

:tada:This issue was addressed in #4401, which has now been successfully released as Windows Terminal Preview v0.9.433.0.🎉

Handy links:

@ghost commented on GitHub (Feb 13, 2020): :tada:This issue was addressed in #4401, which has now been successfully released as `Windows Terminal Preview v0.9.433.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.9.433.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4729
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?