starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #4826] [MERGED] Fire UIA Events for Output and Cursor Movement #25966

New Issue
Open
opened 2026-01-31 09:12:58 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:12:58 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4826
Author: @carlos-zamora
Created: 3/6/2020
Status: ✅ Merged
Merged: 3/18/2020
Merged by: @undefined

Base: master ← Head: dev/cazamor/acc/sig/output

📝 Commits (6)

📊 Changes

5 files changed (+84 additions, -5 deletions)

View changed files

📝 src/cascadia/TerminalControl/TermControlAutomationPeer.cpp (+10 -1)
📝 src/renderer/uia/UiaRenderer.cpp (+27 -4)
📝 src/renderer/uia/UiaRenderer.hpp (+2 -0)
📝 src/types/UiaTracing.cpp (+37 -0)
📝 src/types/UiaTracing.h (+8 -0)

📄 Description

Summary of the Pull Request

This notifies automation clients (i.e.: NVDA, narrator, etc...) of new output being rendered to the screen.

References

Close #2447 - Signaling for new output and cursor
Close #3791 - fixed by signaling cursor changes

Detailed Description of the Pull Request / Additional comments

  • Added tracing for UiaRenderer. This makes it easier to debug issues with notifying an automation client.
  • Fire TextChanged automation events when new content is output to the screen.

Validation Steps Performed

Verified with NVDA [1]

Narrator

Narrator works better, but is unable to detect new output consistently. There is no harm for narrator when this change goes in.

[1] https://github.com/microsoft/terminal/issues/2447#issuecomment-595879890

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4826 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 3/6/2020 **Status:** ✅ Merged **Merged:** 3/18/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/cazamor/acc/sig/output` --- ### 📝 Commits (6) - [`c588844`](https://github.com/microsoft/terminal/commit/c588844921bf91c5070478707e10c54fbfba6737) Signaling Output - v1 - [`56bfc6b`](https://github.com/microsoft/terminal/commit/56bfc6b00a8fc7fd3664a12d858942ed19f22682) undo comment - [`522b99a`](https://github.com/microsoft/terminal/commit/522b99a74e0a9dd4fbb279ff6c5834283092bcbf) signal cursor changed events - [`00ee354`](https://github.com/microsoft/terminal/commit/00ee35479dbdd13710f2aed72e66fe5a9878a671) appropriately send cursor events. - [`457ee3c`](https://github.com/microsoft/terminal/commit/457ee3cfc4e7c2b22cdd6268d44df94212fbb0d5) fix tracing - [`6214d6b`](https://github.com/microsoft/terminal/commit/6214d6b4ebb558f2e999682cb2ec2632db8881af) add comment on bad event ### 📊 Changes **5 files changed** (+84 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/TermControlAutomationPeer.cpp` (+10 -1) 📝 `src/renderer/uia/UiaRenderer.cpp` (+27 -4) 📝 `src/renderer/uia/UiaRenderer.hpp` (+2 -0) 📝 `src/types/UiaTracing.cpp` (+37 -0) 📝 `src/types/UiaTracing.h` (+8 -0) </details> ### 📄 Description ## Summary of the Pull Request This notifies automation clients (i.e.: NVDA, narrator, etc...) of new output being rendered to the screen. ## References Close #2447 - Signaling for new output and cursor Close #3791 - fixed by signaling cursor changes ## Detailed Description of the Pull Request / Additional comments - Added tracing for UiaRenderer. This makes it easier to debug issues with notifying an automation client. - Fire TextChanged automation events when new content is output to the screen. ## Validation Steps Performed Verified with NVDA [1] ## Narrator Narrator works _better_, but is unable to detect new output consistently. There is no harm for narrator when this change goes in. [1] https://github.com/microsoft/terminal/issues/2447#issuecomment-595879890 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:12:58 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25966
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?